* PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
@ 2001-03-20 10:37 Alessandro Suardi
2001-03-20 12:06 ` Jeff Garzik
2001-03-20 16:16 ` Linus Torvalds
0 siblings, 2 replies; 8+ messages in thread
From: Alessandro Suardi @ 2001-03-20 10:37 UTC (permalink / raw
To: linux-kernel; +Cc: torvalds, alan
Sorry to repost the issue but I got no reply...
2.4.3-pre3 and synced-up versions of the -ac series remove support for
PCMCIA serial CardBus. In drivers/char/pcmcia the Makefile and Config.in
files are modified to exclude serial_cb and the serial_cb.c file itself
is removed by the patch. As a net result, my Xircom modem port becomes
invisible to the kernel and I can't dial out through it.
As a temporary measure I backed out the changes in drivers/char/pcmcia
and my 2.4.3-pre4 kernel seems happy (in fact I am dialing out through
said Xircom modem).
Did I miss some announcement for replacement features for serial_cb or
did a bad patch slip in ?
Thanks & ciao,
--alessandro <alessandro.suardi@oracle.com> <asuardi@uninetcom.it>
Linux: kernel 2.2.19p17/2.4.3p4 glibc-2.2 gcc-2.96-69 binutils-2.11.90.0.1
Oracle: Oracle8i 8.1.7.0.1 Enterprise Edition for Linux
motto: Tell the truth, there's less to remember.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 10:37 PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later Alessandro Suardi
@ 2001-03-20 12:06 ` Jeff Garzik
2001-03-20 16:16 ` Linus Torvalds
1 sibling, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2001-03-20 12:06 UTC (permalink / raw
To: Alessandro Suardi; +Cc: linux-kernel, torvalds, alan
Alessandro Suardi wrote:
>
> Sorry to repost the issue but I got no reply...
>
> 2.4.3-pre3 and synced-up versions of the -ac series remove support for
> PCMCIA serial CardBus. In drivers/char/pcmcia the Makefile and Config.in
> files are modified to exclude serial_cb and the serial_cb.c file itself
> is removed by the patch. As a net result, my Xircom modem port becomes
> invisible to the kernel and I can't dial out through it.
>
> As a temporary measure I backed out the changes in drivers/char/pcmcia
> and my 2.4.3-pre4 kernel seems happy (in fact I am dialing out through
> said Xircom modem).
>
> Did I miss some announcement for replacement features for serial_cb or
> did a bad patch slip in ?
Neither. serial.c does serial_cb's job now. It looks like serial.c
needs to scan for modems as well as serial ports, and tytso agrees with
me on that. We just need to check and see if winmodems reports
themselves as real modems before fixing this.
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
[not found] <3AB759F4.F9F5F35D@oracle.com>
@ 2001-03-20 14:11 ` Jeff Garzik
2001-03-20 15:17 ` Alessandro Suardi
0 siblings, 1 reply; 8+ messages in thread
From: Jeff Garzik @ 2001-03-20 14:11 UTC (permalink / raw
To: Alessandro Suardi; +Cc: Linux-Kernel, tytso, guthrie
On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> Jeff Garzik wrote:
> > Neither. serial.c does serial_cb's job now. It looks like serial.c
> > needs to scan for modems as well as serial ports, and tytso agrees with
> > me on that. We just need to check and see if winmodems reports
> > themselves as real modems before fixing this.
> OK, thanks. I assume you mean "serial.c should do serial_cb's job now",
> since it doesn't :) If you want me to test patches etc. just let me know.
Re-CC'd to linux-kernel, hope you don't mind.
Anyone interested in testing patches, this simple change is what needs
testing on various PCI and CardBus modems:
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg34097.html
(since it's a web archive, you may have to hack the patch in manually...)
It seems straightforward enough, and both tytso and I think the change
is ok, but (at tytso's suggestion) I'm going to test some various
winmodem and other use cases because assuring ourselves that it is good
enough for a general rule...
Regards,
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 14:11 ` Jeff Garzik
@ 2001-03-20 15:17 ` Alessandro Suardi
0 siblings, 0 replies; 8+ messages in thread
From: Alessandro Suardi @ 2001-03-20 15:17 UTC (permalink / raw
To: Jeff Garzik; +Cc: Linux-Kernel, tytso, guthrie
Jeff Garzik wrote:
>
> On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> > Jeff Garzik wrote:
> > > Neither. serial.c does serial_cb's job now. It looks like serial.c
> > > needs to scan for modems as well as serial ports, and tytso agrees with
> > > me on that. We just need to check and see if winmodems reports
> > > themselves as real modems before fixing this.
>
> > OK, thanks. I assume you mean "serial.c should do serial_cb's job now",
> > since it doesn't :) If you want me to test patches etc. just let me know.
>
> Re-CC'd to linux-kernel, hope you don't mind.
No problem for me, of course.
> Anyone interested in testing patches, this simple change is what needs
> testing on various PCI and CardBus modems:
> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg34097.html
> (since it's a web archive, you may have to hack the patch in manually...)
I performed this hand-diff...
[asuardi@princess char]$ diff serial.c serial.c-2.4.3p4
4613,4614c4613
< if (!((dev->class >> 8) == PCI_CLASS_COMMUNICATION_SERIAL ||
< (dev->class >> 8) == PCI_CLASS_COMMUNICATION_MODEM) ||
---
> if ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL ||
...and still my Xircom modem tty isn't detected :(
> It seems straightforward enough, and both tytso and I think the change
> is ok, but (at tytso's suggestion) I'm going to test some various
> winmodem and other use cases because assuring ourselves that it is good
> enough for a general rule...
Available for further testing (or fixing my diff if I patched it badly).
Thanks & ciao,
--alessandro <alessandro.suardi@oracle.com> <asuardi@uninetcom.it>
Linux: kernel 2.2.19p17/2.4.3p4 glibc-2.2 gcc-2.96-69 binutils-2.11.90.0.1
Oracle: Oracle8i 8.1.7.0.1 Enterprise Edition for Linux
motto: Tell the truth, there's less to remember.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 10:37 PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later Alessandro Suardi
2001-03-20 12:06 ` Jeff Garzik
@ 2001-03-20 16:16 ` Linus Torvalds
2001-03-20 16:56 ` Pau
1 sibling, 1 reply; 8+ messages in thread
From: Linus Torvalds @ 2001-03-20 16:16 UTC (permalink / raw
To: Alessandro Suardi; +Cc: linux-kernel, alan
On Tue, 20 Mar 2001, Alessandro Suardi wrote:
>
> 2.4.3-pre3 and synced-up versions of the -ac series remove support for
> PCMCIA serial CardBus. In drivers/char/pcmcia the Makefile and Config.in
> files are modified to exclude serial_cb and the serial_cb.c file itself
> is removed by the patch. As a net result, my Xircom modem port becomes
> invisible to the kernel and I can't dial out through it.
The regular serial.c should handle it natively. Just make sure you have
CONFIG_SERIAL enabled, along with hotplugging support etc.
Linus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 16:16 ` Linus Torvalds
@ 2001-03-20 16:56 ` Pau
2001-03-20 17:00 ` Alessandro Suardi
0 siblings, 1 reply; 8+ messages in thread
From: Pau @ 2001-03-20 16:56 UTC (permalink / raw
To: lkml
On Tue, 20 Mar 2001, Linus Torvalds wrote:
>
>
> On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> >
> > 2.4.3-pre3 and synced-up versions of the -ac series remove support for
> > PCMCIA serial CardBus. In drivers/char/pcmcia the Makefile and Config.in
> > files are modified to exclude serial_cb and the serial_cb.c file itself
> > is removed by the patch. As a net result, my Xircom modem port becomes
> > invisible to the kernel and I can't dial out through it.
>
> The regular serial.c should handle it natively. Just make sure you have
> CONFIG_SERIAL enabled, along with hotplugging support etc.
In fact it does. I discovered it last weekend when my modem -them same one
than Alessandro's- stopped working.
Removing "alias char-major-4 serial_cb" from modules.conf did the trick
and the serial driver worked flawlessly. Modules serial got loaded
instead.
Pau
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 16:56 ` Pau
@ 2001-03-20 17:00 ` Alessandro Suardi
2001-03-20 17:11 ` Pau
0 siblings, 1 reply; 8+ messages in thread
From: Alessandro Suardi @ 2001-03-20 17:00 UTC (permalink / raw
To: Pau; +Cc: lkml, jgarzik
Pau wrote:
>
> On Tue, 20 Mar 2001, Linus Torvalds wrote:
>
> >
> >
> > On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> > >
> > > 2.4.3-pre3 and synced-up versions of the -ac series remove support for
> > > PCMCIA serial CardBus. In drivers/char/pcmcia the Makefile and Config.in
> > > files are modified to exclude serial_cb and the serial_cb.c file itself
> > > is removed by the patch. As a net result, my Xircom modem port becomes
> > > invisible to the kernel and I can't dial out through it.
> >
> > The regular serial.c should handle it natively. Just make sure you have
> > CONFIG_SERIAL enabled, along with hotplugging support etc.
>
> In fact it does. I discovered it last weekend when my modem -them same one
> than Alessandro's- stopped working.
>
> Removing "alias char-major-4 serial_cb" from modules.conf did the trick
> and the serial driver worked flawlessly. Modules serial got loaded
> instead.
Cool... but I have used for a while serial_cb in kernel, not as a module
so there is nothing to remove here :) as for Jeff's surprise I have had
basically no problem in using kernel PCMCIA stuff in 2.4 series, apart
from the usual Tx hang bug of the Xircom.
Built with Jeff's latest patch, rebooting....
--alessandro <alessandro.suardi@oracle.com> <asuardi@uninetcom.it>
Linux: kernel 2.2.19p17/2.4.3p4 glibc-2.2 gcc-2.96-69 binutils-2.11.90.0.1
Oracle: Oracle8i 8.1.7.0.1 Enterprise Edition for Linux
motto: Tell the truth, there's less to remember.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later
2001-03-20 17:00 ` Alessandro Suardi
@ 2001-03-20 17:11 ` Pau
0 siblings, 0 replies; 8+ messages in thread
From: Pau @ 2001-03-20 17:11 UTC (permalink / raw
To: Alessandro Suardi; +Cc: lkml, jgarzik
On Tue, 20 Mar 2001, Alessandro Suardi wrote:
> > Removing "alias char-major-4 serial_cb" from modules.conf did the trick
> > and the serial driver worked flawlessly. Modules serial got loaded
> > instead.
>
> Cool... but I have used for a while serial_cb in kernel, not as a module
> so there is nothing to remove here :) as for Jeff's surprise I have had
> basically no problem in using kernel PCMCIA stuff in 2.4 series, apart
> from the usual Tx hang bug of the Xircom.
I've been using it since first 2.3 series :)
I still have the Tx hang basically with NFS, but also when moving high
amount of Mb in the LAN.
I've moved from pcmcia-cs to hotplug and it works too :)
Pau
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2001-03-20 17:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-03-20 10:37 PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later Alessandro Suardi
2001-03-20 12:06 ` Jeff Garzik
2001-03-20 16:16 ` Linus Torvalds
2001-03-20 16:56 ` Pau
2001-03-20 17:00 ` Alessandro Suardi
2001-03-20 17:11 ` Pau
[not found] <3AB759F4.F9F5F35D@oracle.com>
2001-03-20 14:11 ` Jeff Garzik
2001-03-20 15:17 ` Alessandro Suardi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.