All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@nl.linux.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux MM <linux-mm@kvack.org>,
	Linux Kernel <linux-kernel@vger.rutgers.edu>
Subject: Re: 2.2.1{3,4,5pre*} VM bug found
Date: Wed, 26 Jan 2000 01:48:43 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.10.10001260146290.1373-100000@mirkwood.dummy.home> (raw)
In-Reply-To: <Pine.LNX.4.10.10001251906370.14600-100000@d251.suse.de>

On Tue, 25 Jan 2000, Andrea Arcangeli wrote:

> Before calling schedule() you always gets registered in a
> waitqueue so you can't deadlock or wait too much.
> 
> If something there is the opposite problem. If you do:
> 
> 	__set_current_state(TASK_UNINTERRUPTIBLE);
> 	get_page(GFP_KERNEL);
> 	XXXXXXXXXXXXXXXXXXXX
> 	schedule();
> 
> then at point XXXXXXX you may become a task running and you don't
> block anymore.

The problem in this case is that schedule() may be called
from within get_page(GFP_KERNEL). This already was possible
in 2.2.14 and before (if the task had to wait for I/O on
try_to_free_pages()), but the explicit schedule() in my
stuff in 2.2.15pre4 amplified the problem and made it
visible.

A fix for this problem is in one of my other emails and
at my web page:  http://www.surriel.com/patches/

regards,

Rik
--
The Internet is not a network of computers. It is a network
of people. That is its real strength.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

  reply	other threads:[~2000-01-26  0:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-01-25  3:27 2.2.1{3,4,5pre*} VM bug found Rik van Riel
2000-01-25 18:15 ` Andrea Arcangeli
2000-01-26  0:48   ` Rik van Riel [this message]
2000-01-27 19:09     ` Stephen C. Tweedie
2000-01-27 19:07 ` Stephen C. Tweedie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10001260146290.1373-100000@mirkwood.dummy.home \
    --to=riel@nl.linux.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.rutgers.edu \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.