* [PATCH] rootfs.py: Fix logger error message format
@ 2024-04-17 19:56 John Ripple
2024-04-19 14:19 ` [OE-core] " Tim Orling
0 siblings, 1 reply; 2+ messages in thread
From: John Ripple @ 2024-04-17 19:56 UTC (permalink / raw
To: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
This patch adds a missing "%s" format in a logger.error call. Without
this addition the logger itself would error out and not print a useful
message.
Signed-off-by: John Ripple <john.ripple@keysight.com>
---
scripts/lib/wic/plugins/source/rootfs.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py
index e29f3a4c2f..c990143c0d 100644
--- a/scripts/lib/wic/plugins/source/rootfs.py
+++ b/scripts/lib/wic/plugins/source/rootfs.py
@@ -43,7 +43,7 @@ class RootfsPlugin(SourcePlugin):
# directory, or modify a directory outside OpenEmbedded).
full_path = os.path.realpath(os.path.join(rootfs_dir, path))
if not full_path.startswith(os.path.realpath(rootfs_dir)):
- logger.error("%s: Must point inside the rootfs:" % (cmd, path))
+ logger.error("%s: Must point inside the rootfs: %s" % (cmd, path))
sys.exit(1)
return full_path
--
2.34.1
[-- Attachment #2: Type: text/html, Size: 7355 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [OE-core] [PATCH] rootfs.py: Fix logger error message format
2024-04-17 19:56 [PATCH] rootfs.py: Fix logger error message format John Ripple
@ 2024-04-19 14:19 ` Tim Orling
0 siblings, 0 replies; 2+ messages in thread
From: Tim Orling @ 2024-04-19 14:19 UTC (permalink / raw
To: john.ripple; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
On Wed, Apr 17, 2024 at 12:56 PM John Ripple via lists.openembedded.org
<john.ripple=keysight.com@lists.openembedded.org> wrote:
> This patch adds a missing "%s" format in a logger.error call. Without
> this addition the logger itself would error out and not print a useful
> message.
>
> Signed-off-by: John Ripple <john.ripple@keysight.com>
> ---
> scripts/lib/wic/plugins/source/rootfs.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/rootfs.py
> b/scripts/lib/wic/plugins/source/rootfs.py
> index e29f3a4c2f..c990143c0d 100644
> --- a/scripts/lib/wic/plugins/source/rootfs.py
> +++ b/scripts/lib/wic/plugins/source/rootfs.py
> @@ -43,7 +43,7 @@ class RootfsPlugin(SourcePlugin):
> # directory, or modify a directory outside OpenEmbedded).
> full_path = os.path.realpath(os.path.join(rootfs_dir, path))
> if not full_path.startswith(os.path.realpath(rootfs_dir)):
> - logger.error("%s: Must point inside the rootfs:" % (cmd,
> path))
> + logger.error("%s: Must point inside the rootfs: %s" % (cmd,
> path))
>
Nice catch. Thank you.
Reviewed-by: Tim Orling <tim.orling@konsulko.com>
sys.exit(1)
>
> return full_path
> --
> 2.34.1
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#198476):
> https://lists.openembedded.org/g/openembedded-core/message/198476
> Mute This Topic: https://lists.openembedded.org/mt/105585009/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 8680 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-19 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-17 19:56 [PATCH] rootfs.py: Fix logger error message format John Ripple
2024-04-19 14:19 ` [OE-core] " Tim Orling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.