All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/intel_compute: Do not assume engine class
@ 2024-03-14 21:37 Nirmoy Das
  2024-03-15  0:13 ` ✓ CI.xeBAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Nirmoy Das @ 2024-03-14 21:37 UTC (permalink / raw
  To: igt-dev; +Cc: Nirmoy Das, Zbigniew Kempczyński, Janga Rahul Kumar

Let the test decide what engine class to use instead of
a lib function deciding it for tests.

Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 lib/intel_compute.c      | 20 +++-----------------
 tests/intel/xe_compute.c | 21 ++++++++++++++++++++-
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 9d3b97efe..c96e60027 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -81,24 +81,10 @@ static void bo_execenv_create(int fd, struct bo_execenv *execenv,
 	execenv->driver = get_intel_driver(fd);
 
 	if (execenv->driver == INTEL_DRIVER_XE) {
+		igt_fail_on(eci == NULL);
 		execenv->vm = xe_vm_create(fd, 0, 0);
-
-		if (eci) {
-			execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm,
-								   eci, 0);
-		} else {
-			uint16_t engine_class;
-			uint32_t devid = intel_get_drm_devid(fd);
-			const struct intel_device_info *info = intel_get_device_info(devid);
-
-			if (info->graphics_ver >= 12 && info->graphics_rel < 60)
-				engine_class = DRM_XE_ENGINE_CLASS_RENDER;
-			else
-				engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
-
-			execenv->exec_queue = xe_exec_queue_create_class(fd, execenv->vm,
-									 engine_class);
-		}
+		execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm, eci,
+							   0);
 	}
 }
 
diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c
index 42f42ca0c..cb98b00d5 100644
--- a/tests/intel/xe_compute.c
+++ b/tests/intel/xe_compute.c
@@ -163,9 +163,28 @@ test_compute_kernel_with_ccs_mode(int num_gt)
 static void
 test_compute_square(int fd)
 {
-	igt_require_f(run_intel_compute_kernel(fd), "GPU not supported\n");
+	struct drm_xe_engine_class_instance *hwe;
+	const struct intel_device_info *info;
+	uint16_t engine_class;
+	uint32_t devid = intel_get_drm_devid(fd);
+
+	info = intel_get_device_info(devid);
+
+	if (info->graphics_ver >= 12 && info->graphics_rel < 60)
+		engine_class = DRM_XE_ENGINE_CLASS_RENDER;
+	else
+		engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
+
+	xe_for_each_engine(fd, hwe) {
+		if (hwe->engine_class != engine_class)
+			continue;
+
+		igt_require_f(xe_run_intel_compute_kernel_on_engine(fd, hwe),
+			      "GPU not supported\n");
+	}
 }
 
+
 igt_main
 {
 	int xe, num_gt;
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* ✓ CI.xeBAT: success for lib/intel_compute: Do not assume engine class
  2024-03-14 21:37 [PATCH i-g-t] lib/intel_compute: Do not assume engine class Nirmoy Das
@ 2024-03-15  0:13 ` Patchwork
  2024-03-15  0:18 ` ✗ Fi.CI.BAT: failure " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2024-03-15  0:13 UTC (permalink / raw
  To: Nirmoy Das; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

== Series Details ==

Series: lib/intel_compute: Do not assume engine class
URL   : https://patchwork.freedesktop.org/series/131154/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7766_BAT -> XEIGTPW_10838_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts


Changes
-------

  No changes found


Build changes
-------------

  * IGT: IGT_7766 -> IGTPW_10838
  * Linux: xe-943-c44e29a7b62293355744fd857aad93cbf43e5126 -> xe-945-349b729c661c449da8151a079c6f237f0c796b24

  IGTPW_10838: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/index.html
  IGT_7766: 08cf1b2fa6b2f422f417ea74f41b12b93e91156f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-943-c44e29a7b62293355744fd857aad93cbf43e5126: c44e29a7b62293355744fd857aad93cbf43e5126
  xe-945-349b729c661c449da8151a079c6f237f0c796b24: 349b729c661c449da8151a079c6f237f0c796b24

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10838/index.html

[-- Attachment #2: Type: text/html, Size: 1682 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* ✗ Fi.CI.BAT: failure for lib/intel_compute: Do not assume engine class
  2024-03-14 21:37 [PATCH i-g-t] lib/intel_compute: Do not assume engine class Nirmoy Das
  2024-03-15  0:13 ` ✓ CI.xeBAT: success for " Patchwork
@ 2024-03-15  0:18 ` Patchwork
  2024-03-15  9:06 ` [PATCH i-g-t] " Kumar, Janga Rahul
  2024-03-18  9:55 ` Zbigniew Kempczyński
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2024-03-15  0:18 UTC (permalink / raw
  To: Nirmoy Das; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 3973 bytes --]

== Series Details ==

Series: lib/intel_compute: Do not assume engine class
URL   : https://patchwork.freedesktop.org/series/131154/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14436 -> IGTPW_10838
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10838 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10838, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/index.html

Participating hosts (36 -> 33)
------------------------------

  Missing    (3): fi-blb-e6850 bat-dg1-7 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10838:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@gem_contexts:
    - bat-mtlp-8:         [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14436/bat-mtlp-8/igt@i915_selftest@live@gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-mtlp-8/igt@i915_selftest@live@gem_contexts.html

  
Known issues
------------

  Here are the changes found in IGTPW_10838 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-jsl-1:          NOTRUN -> [SKIP][3] ([i915#9318])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@debugfs_test@basic-hwmon.html

  * igt@gem_huc_copy@huc-copy:
    - bat-jsl-1:          NOTRUN -> [SKIP][4] ([i915#2190])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@verify-random:
    - bat-jsl-1:          NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@gem_lmem_swapping@verify-random.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-jsl-1:          NOTRUN -> [SKIP][6] ([i915#4103]) +1 other test skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - bat-jsl-1:          NOTRUN -> [SKIP][7] ([i915#3555] / [i915#9886])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-jsl-1:          NOTRUN -> [SKIP][8]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-jsl-1:          NOTRUN -> [SKIP][9] ([i915#3555])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/bat-jsl-1/igt@kms_setmode@basic-clone-single-crtc.html

  
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
  [i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7766 -> IGTPW_10838

  CI-20190529: 20190529
  CI_DRM_14436: 349b729c661c449da8151a079c6f237f0c796b24 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10838: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/index.html
  IGT_7766: 08cf1b2fa6b2f422f417ea74f41b12b93e91156f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10838/index.html

[-- Attachment #2: Type: text/html, Size: 4845 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH i-g-t] lib/intel_compute: Do not assume engine class
  2024-03-14 21:37 [PATCH i-g-t] lib/intel_compute: Do not assume engine class Nirmoy Das
  2024-03-15  0:13 ` ✓ CI.xeBAT: success for " Patchwork
  2024-03-15  0:18 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-03-15  9:06 ` Kumar, Janga Rahul
  2024-03-18  9:55 ` Zbigniew Kempczyński
  3 siblings, 0 replies; 6+ messages in thread
From: Kumar, Janga Rahul @ 2024-03-15  9:06 UTC (permalink / raw
  To: Das, Nirmoy, igt-dev@lists.freedesktop.org; +Cc: Kempczynski, Zbigniew



> -----Original Message-----
> From: Das, Nirmoy <nirmoy.das@intel.com>
> Sent: Friday, March 15, 2024 3:08 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Das, Nirmoy <nirmoy.das@intel.com>; Kempczynski, Zbigniew
> <zbigniew.kempczynski@intel.com>; Kumar, Janga Rahul
> <janga.rahul.kumar@intel.com>
> Subject: [PATCH i-g-t] lib/intel_compute: Do not assume engine class
> 
> Let the test decide what engine class to use instead of a lib function deciding it
> for tests.
> 
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>

 LGTM,
Acked-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

> ---
>  lib/intel_compute.c      | 20 +++-----------------
>  tests/intel/xe_compute.c | 21 ++++++++++++++++++++-
>  2 files changed, 23 insertions(+), 18 deletions(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c index
> 9d3b97efe..c96e60027 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -81,24 +81,10 @@ static void bo_execenv_create(int fd, struct
> bo_execenv *execenv,
>  	execenv->driver = get_intel_driver(fd);
> 
>  	if (execenv->driver == INTEL_DRIVER_XE) {
> +		igt_fail_on(eci == NULL);
>  		execenv->vm = xe_vm_create(fd, 0, 0);
> -
> -		if (eci) {
> -			execenv->exec_queue = xe_exec_queue_create(fd,
> execenv->vm,
> -								   eci, 0);
> -		} else {
> -			uint16_t engine_class;
> -			uint32_t devid = intel_get_drm_devid(fd);
> -			const struct intel_device_info *info =
> intel_get_device_info(devid);
> -
> -			if (info->graphics_ver >= 12 && info->graphics_rel <
> 60)
> -				engine_class =
> DRM_XE_ENGINE_CLASS_RENDER;
> -			else
> -				engine_class =
> DRM_XE_ENGINE_CLASS_COMPUTE;
> -
> -			execenv->exec_queue =
> xe_exec_queue_create_class(fd, execenv->vm,
> -
> engine_class);
> -		}
> +		execenv->exec_queue = xe_exec_queue_create(fd, execenv-
> >vm, eci,
> +							   0);
>  	}
>  }
> 
> diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c index
> 42f42ca0c..cb98b00d5 100644
> --- a/tests/intel/xe_compute.c
> +++ b/tests/intel/xe_compute.c
> @@ -163,9 +163,28 @@ test_compute_kernel_with_ccs_mode(int num_gt)
> static void  test_compute_square(int fd)  {
> -	igt_require_f(run_intel_compute_kernel(fd), "GPU not supported\n");
> +	struct drm_xe_engine_class_instance *hwe;
> +	const struct intel_device_info *info;
> +	uint16_t engine_class;
> +	uint32_t devid = intel_get_drm_devid(fd);
> +
> +	info = intel_get_device_info(devid);
> +
> +	if (info->graphics_ver >= 12 && info->graphics_rel < 60)
> +		engine_class = DRM_XE_ENGINE_CLASS_RENDER;
> +	else
> +		engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
> +
> +	xe_for_each_engine(fd, hwe) {
> +		if (hwe->engine_class != engine_class)
> +			continue;
> +
> +		igt_require_f(xe_run_intel_compute_kernel_on_engine(fd,
> hwe),
> +			      "GPU not supported\n");
> +	}
>  }
> 
> +
>  igt_main
>  {
>  	int xe, num_gt;
> --
> 2.42.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH i-g-t] lib/intel_compute: Do not assume engine class
  2024-03-14 21:37 [PATCH i-g-t] lib/intel_compute: Do not assume engine class Nirmoy Das
                   ` (2 preceding siblings ...)
  2024-03-15  9:06 ` [PATCH i-g-t] " Kumar, Janga Rahul
@ 2024-03-18  9:55 ` Zbigniew Kempczyński
  2024-03-18 10:07   ` Nirmoy Das
  3 siblings, 1 reply; 6+ messages in thread
From: Zbigniew Kempczyński @ 2024-03-18  9:55 UTC (permalink / raw
  To: Nirmoy Das; +Cc: igt-dev, Janga Rahul Kumar

On Thu, Mar 14, 2024 at 10:37:48PM +0100, Nirmoy Das wrote:
> Let the test decide what engine class to use instead of
> a lib function deciding it for tests.
> 
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  lib/intel_compute.c      | 20 +++-----------------
>  tests/intel/xe_compute.c | 21 ++++++++++++++++++++-
>  2 files changed, 23 insertions(+), 18 deletions(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 9d3b97efe..c96e60027 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -81,24 +81,10 @@ static void bo_execenv_create(int fd, struct bo_execenv *execenv,
>  	execenv->driver = get_intel_driver(fd);
>  
>  	if (execenv->driver == INTEL_DRIVER_XE) {
> +		igt_fail_on(eci == NULL);
>  		execenv->vm = xe_vm_create(fd, 0, 0);
> -
> -		if (eci) {
> -			execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm,
> -								   eci, 0);
> -		} else {
> -			uint16_t engine_class;
> -			uint32_t devid = intel_get_drm_devid(fd);
> -			const struct intel_device_info *info = intel_get_device_info(devid);
> -
> -			if (info->graphics_ver >= 12 && info->graphics_rel < 60)
> -				engine_class = DRM_XE_ENGINE_CLASS_RENDER;
> -			else
> -				engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
> -
> -			execenv->exec_queue = xe_exec_queue_create_class(fd, execenv->vm,
> -									 engine_class);
> -		}
> +		execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm, eci,
> +							   0);
>  	}
>  }
>  

I don't like this. You're moving logic which is common for compute
users outside, giving possibility to pass invalid queue. I vote
to not merge this.

--
Zbigniew

> diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c
> index 42f42ca0c..cb98b00d5 100644
> --- a/tests/intel/xe_compute.c
> +++ b/tests/intel/xe_compute.c
> @@ -163,9 +163,28 @@ test_compute_kernel_with_ccs_mode(int num_gt)
>  static void
>  test_compute_square(int fd)
>  {
> -	igt_require_f(run_intel_compute_kernel(fd), "GPU not supported\n");
> +	struct drm_xe_engine_class_instance *hwe;
> +	const struct intel_device_info *info;
> +	uint16_t engine_class;
> +	uint32_t devid = intel_get_drm_devid(fd);
> +
> +	info = intel_get_device_info(devid);
> +
> +	if (info->graphics_ver >= 12 && info->graphics_rel < 60)
> +		engine_class = DRM_XE_ENGINE_CLASS_RENDER;
> +	else
> +		engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
> +
> +	xe_for_each_engine(fd, hwe) {
> +		if (hwe->engine_class != engine_class)
> +			continue;
> +
> +		igt_require_f(xe_run_intel_compute_kernel_on_engine(fd, hwe),
> +			      "GPU not supported\n");
> +	}
>  }
>  
> +
>  igt_main
>  {
>  	int xe, num_gt;
> -- 
> 2.42.0
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH i-g-t] lib/intel_compute: Do not assume engine class
  2024-03-18  9:55 ` Zbigniew Kempczyński
@ 2024-03-18 10:07   ` Nirmoy Das
  0 siblings, 0 replies; 6+ messages in thread
From: Nirmoy Das @ 2024-03-18 10:07 UTC (permalink / raw
  To: Zbigniew Kempczyński; +Cc: igt-dev, Janga Rahul Kumar


On 3/18/2024 10:55 AM, Zbigniew Kempczyński wrote:
> On Thu, Mar 14, 2024 at 10:37:48PM +0100, Nirmoy Das wrote:
>> Let the test decide what engine class to use instead of
>> a lib function deciding it for tests.
>>
>> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> ---
>>   lib/intel_compute.c      | 20 +++-----------------
>>   tests/intel/xe_compute.c | 21 ++++++++++++++++++++-
>>   2 files changed, 23 insertions(+), 18 deletions(-)
>>
>> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
>> index 9d3b97efe..c96e60027 100644
>> --- a/lib/intel_compute.c
>> +++ b/lib/intel_compute.c
>> @@ -81,24 +81,10 @@ static void bo_execenv_create(int fd, struct bo_execenv *execenv,
>>   	execenv->driver = get_intel_driver(fd);
>>   
>>   	if (execenv->driver == INTEL_DRIVER_XE) {
>> +		igt_fail_on(eci == NULL);
>>   		execenv->vm = xe_vm_create(fd, 0, 0);
>> -
>> -		if (eci) {
>> -			execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm,
>> -								   eci, 0);
>> -		} else {
>> -			uint16_t engine_class;
>> -			uint32_t devid = intel_get_drm_devid(fd);
>> -			const struct intel_device_info *info = intel_get_device_info(devid);
>> -
>> -			if (info->graphics_ver >= 12 && info->graphics_rel < 60)
>> -				engine_class = DRM_XE_ENGINE_CLASS_RENDER;
>> -			else
>> -				engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
>> -
>> -			execenv->exec_queue = xe_exec_queue_create_class(fd, execenv->vm,
>> -									 engine_class);
>> -		}
>> +		execenv->exec_queue = xe_exec_queue_create(fd, execenv->vm, eci,
>> +							   0);
>>   	}
>>   }
>>   
> I don't like this. You're moving logic which is common for compute
> users outside, giving possibility to pass invalid queue.

>   I vote
> to not merge this.

Yes, I waited for that :) Let's ignore the patch. I am fine with having 
a default eci if user doesn't pass anything.,

>
> --
> Zbigniew
>
>> diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c
>> index 42f42ca0c..cb98b00d5 100644
>> --- a/tests/intel/xe_compute.c
>> +++ b/tests/intel/xe_compute.c
>> @@ -163,9 +163,28 @@ test_compute_kernel_with_ccs_mode(int num_gt)
>>   static void
>>   test_compute_square(int fd)
>>   {
>> -	igt_require_f(run_intel_compute_kernel(fd), "GPU not supported\n");
>> +	struct drm_xe_engine_class_instance *hwe;
>> +	const struct intel_device_info *info;
>> +	uint16_t engine_class;
>> +	uint32_t devid = intel_get_drm_devid(fd);
>> +
>> +	info = intel_get_device_info(devid);
>> +
>> +	if (info->graphics_ver >= 12 && info->graphics_rel < 60)
>> +		engine_class = DRM_XE_ENGINE_CLASS_RENDER;
>> +	else
>> +		engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
>> +
>> +	xe_for_each_engine(fd, hwe) {
>> +		if (hwe->engine_class != engine_class)
>> +			continue;
>> +
>> +		igt_require_f(xe_run_intel_compute_kernel_on_engine(fd, hwe),
>> +			      "GPU not supported\n");
>> +	}
>>   }
>>   
>> +
>>   igt_main
>>   {
>>   	int xe, num_gt;
>> -- 
>> 2.42.0
>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-03-18 10:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-14 21:37 [PATCH i-g-t] lib/intel_compute: Do not assume engine class Nirmoy Das
2024-03-15  0:13 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-15  0:18 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-15  9:06 ` [PATCH i-g-t] " Kumar, Janga Rahul
2024-03-18  9:55 ` Zbigniew Kempczyński
2024-03-18 10:07   ` Nirmoy Das

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.