* [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon).
@ 2023-04-22 1:36 Srinivasan Shanmugam
2023-04-24 17:22 ` Zuo, Jerry
0 siblings, 1 reply; 3+ messages in thread
From: Srinivasan Shanmugam @ 2023-04-22 1:36 UTC (permalink / raw
To: Jerry Zuo, Aurabindo Pillai; +Cc: Fangzhi Zuo, Srinivasan Shanmugam, amd-gfx
if check over DSC passthrough is removed, as this is not for
MST use case. It is for DP-HDMI pcon use case. sst pcon is
detected as sst not mst. In sst pcon dsc passthrough message
will not get below log printed
'Fixes: 8dc5bfdab0ecf ("drm/amd/display: Check & log if receiver supports
MST, DSC & FEC.")'
Suggested-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
.../drm/amd/display/dc/link/protocols/link_dp_capability.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
index 84265dc66bba..577f74cc50fb 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
@@ -1820,9 +1820,8 @@ static bool retrieve_link_cap(struct dc_link *link)
str_yes_no(is_fec_supported));
DC_LOG_DC("%s: DSC_Basic_Sink_Support: %s\n", __func__,
str_yes_no(is_dsc_basic_supported));
- if (link->dpcd_caps.is_mst_capable)
- DC_LOG_DC("%s: DSC_Passthrough_Sink_Support: %s\n", __func__,
- str_yes_no(is_dsc_passthrough_supported));
+ DC_LOG_DC("%s: DSC_Passthrough_Sink_Support: %s\n", __func__,
+ str_yes_no(is_dsc_passthrough_supported));
}
if (link->dpcd_caps.dongle_type != DISPLAY_DONGLE_NONE) {
status = core_link_read_dpcd(
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon).
2023-04-22 1:36 [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon) Srinivasan Shanmugam
@ 2023-04-24 17:22 ` Zuo, Jerry
2023-04-25 2:15 ` SHANMUGAM, SRINIVASAN
0 siblings, 1 reply; 3+ messages in thread
From: Zuo, Jerry @ 2023-04-24 17:22 UTC (permalink / raw
To: SHANMUGAM, SRINIVASAN, Pillai, Aurabindo; +Cc: amd-gfx@lists.freedesktop.org
[AMD Official Use Only - General]
Reviewed-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>
> Sent: Friday, April 21, 2023 9:36 PM
> To: Zuo, Jerry <Jerry.Zuo@amd.com>; Pillai, Aurabindo
> <Aurabindo.Pillai@amd.com>
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com>
> Subject: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon
> (SST pcon).
>
> if check over DSC passthrough is removed, as this is not for MST use case. It
> is for DP-HDMI pcon use case. sst pcon is detected as sst not mst. In sst pcon
> dsc passthrough message will not get below log printed
>
> 'Fixes: 8dc5bfdab0ecf ("drm/amd/display: Check & log if receiver supports
> MST, DSC & FEC.")'
> Suggested-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> .../drm/amd/display/dc/link/protocols/link_dp_capability.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
> a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index 84265dc66bba..577f74cc50fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -1820,9 +1820,8 @@ static bool retrieve_link_cap(struct dc_link *link)
> str_yes_no(is_fec_supported));
> DC_LOG_DC("%s: DSC_Basic_Sink_Support: %s\n",
> __func__,
> str_yes_no(is_dsc_basic_supported));
> - if (link->dpcd_caps.is_mst_capable)
> - DC_LOG_DC("%s:
> DSC_Passthrough_Sink_Support: %s\n", __func__,
> -
> str_yes_no(is_dsc_passthrough_supported));
> + DC_LOG_DC("%s:
> DSC_Passthrough_Sink_Support: %s\n", __func__,
> + str_yes_no(is_dsc_passthrough_supported));
> }
> if (link->dpcd_caps.dongle_type != DISPLAY_DONGLE_NONE)
> {
> status = core_link_read_dpcd(
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon).
2023-04-24 17:22 ` Zuo, Jerry
@ 2023-04-25 2:15 ` SHANMUGAM, SRINIVASAN
0 siblings, 0 replies; 3+ messages in thread
From: SHANMUGAM, SRINIVASAN @ 2023-04-25 2:15 UTC (permalink / raw
To: Zuo, Jerry, Pillai, Aurabindo; +Cc: amd-gfx@lists.freedesktop.org
[AMD Official Use Only - General]
Thanks a lot Jerry! and Aurabindo!, much appreciate for your help in reviewing this patch.
-----Original Message-----
From: Zuo, Jerry <Jerry.Zuo@amd.com>
Sent: Monday, April 24, 2023 10:52 PM
To: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon).
[AMD Official Use Only - General]
Reviewed-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
> -----Original Message-----
> From: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>
> Sent: Friday, April 21, 2023 9:36 PM
> To: Zuo, Jerry <Jerry.Zuo@amd.com>; Pillai, Aurabindo
> <Aurabindo.Pillai@amd.com>
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
> <SRINIVASAN.SHANMUGAM@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com>
> Subject: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon
> (SST pcon).
>
> if check over DSC passthrough is removed, as this is not for MST use
> case. It is for DP-HDMI pcon use case. sst pcon is detected as sst not
> mst. In sst pcon dsc passthrough message will not get below log
> printed
>
> 'Fixes: 8dc5bfdab0ecf ("drm/amd/display: Check & log if receiver
> supports MST, DSC & FEC.")'
> Suggested-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> .../drm/amd/display/dc/link/protocols/link_dp_capability.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
> a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index 84265dc66bba..577f74cc50fb 100644
> ---
> a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability
> +++ .c
> @@ -1820,9 +1820,8 @@ static bool retrieve_link_cap(struct dc_link *link)
> str_yes_no(is_fec_supported));
> DC_LOG_DC("%s: DSC_Basic_Sink_Support: %s\n", __func__,
> str_yes_no(is_dsc_basic_supported));
> - if (link->dpcd_caps.is_mst_capable)
> - DC_LOG_DC("%s:
> DSC_Passthrough_Sink_Support: %s\n", __func__,
> -
> str_yes_no(is_dsc_passthrough_supported));
> + DC_LOG_DC("%s:
> DSC_Passthrough_Sink_Support: %s\n", __func__,
> + str_yes_no(is_dsc_passthrough_supported));
> }
> if (link->dpcd_caps.dongle_type != DISPLAY_DONGLE_NONE) {
> status = core_link_read_dpcd(
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-25 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-22 1:36 [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon) Srinivasan Shanmugam
2023-04-24 17:22 ` Zuo, Jerry
2023-04-25 2:15 ` SHANMUGAM, SRINIVASAN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.