* [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage
[not found] <20240322123923.16346-1-tjjh89017@hotmail.com>
@ 2024-03-22 12:39 ` Date Huang
2024-03-22 12:54 ` Nikolay Aleksandrov
2024-03-22 12:39 ` [PATCH iproute2-next v2 2/2] " Date Huang
1 sibling, 1 reply; 6+ messages in thread
From: Date Huang @ 2024-03-22 12:39 UTC (permalink / raw
To: roopa, razor, jiri; +Cc: netdev, bridge, tjjh89017
Fix the incorrect short opt for compressvlans and color
in usage
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
---
bridge/bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bridge/bridge.c b/bridge/bridge.c
index f4805092..ef592815 100644
--- a/bridge/bridge.c
+++ b/bridge/bridge.c
@@ -39,7 +39,7 @@ static void usage(void)
"where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
" OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
" -o[neline] | -t[imestamp] | -n[etns] name |\n"
-" -c[ompressvlans] -color -p[retty] -j[son] }\n");
+" -com[pressvlans] -c[olor] -p[retty] -j[son] }\n");
exit(-1);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage
[not found] <20240322123923.16346-1-tjjh89017@hotmail.com>
2024-03-22 12:39 ` [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage Date Huang
@ 2024-03-22 12:39 ` Date Huang
2024-03-22 12:54 ` Nikolay Aleksandrov
2024-03-22 15:41 ` Stephen Hemminger
1 sibling, 2 replies; 6+ messages in thread
From: Date Huang @ 2024-03-22 12:39 UTC (permalink / raw
To: roopa, razor, jiri; +Cc: netdev, bridge, tjjh89017
Add the missing 'compressvlans' to man page
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
---
man/man8/bridge.8 | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index eeea4073..bb02bd27 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
\fB\-s\fR[\fItatistics\fR] |
\fB\-n\fR[\fIetns\fR] name |
\fB\-b\fR[\fIatch\fR] filename |
+\fB\-com\fR[\fIpressvlans\fR] |
\fB\-c\fR[\fIolor\fR] |
\fB\-p\fR[\fIretty\fR] |
\fB\-j\fR[\fIson\fR] |
@@ -345,6 +346,11 @@ Don't terminate bridge command on errors in batch mode.
If there were any errors during execution of the commands, the application
return code will be non zero.
+.TP
+.BR "\-com", " \-compressvlans"
+Show compressed VLAN list. It will show continuous VLANs with the range instead
+of separated VLANs. Default is off.
+
.TP
.BR \-c [ color ][ = { always | auto | never }
Configure color output. If parameter is omitted or
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage
2024-03-22 12:39 ` [PATCH iproute2-next v2 2/2] " Date Huang
@ 2024-03-22 12:54 ` Nikolay Aleksandrov
2024-03-22 15:41 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2024-03-22 12:54 UTC (permalink / raw
To: Date Huang, roopa, jiri; +Cc: netdev, bridge
On 3/22/24 14:39, Date Huang wrote:
> Add the missing 'compressvlans' to man page
>
> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
> ---
> man/man8/bridge.8 | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
> index eeea4073..bb02bd27 100644
> --- a/man/man8/bridge.8
> +++ b/man/man8/bridge.8
> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
> \fB\-s\fR[\fItatistics\fR] |
> \fB\-n\fR[\fIetns\fR] name |
> \fB\-b\fR[\fIatch\fR] filename |
> +\fB\-com\fR[\fIpressvlans\fR] |
> \fB\-c\fR[\fIolor\fR] |
> \fB\-p\fR[\fIretty\fR] |
> \fB\-j\fR[\fIson\fR] |
> @@ -345,6 +346,11 @@ Don't terminate bridge command on errors in batch mode.
> If there were any errors during execution of the commands, the application
> return code will be non zero.
>
> +.TP
> +.BR "\-com", " \-compressvlans"
> +Show compressed VLAN list. It will show continuous VLANs with the range instead
> +of separated VLANs. Default is off.
> +
How about:
Show a compressed VLAN list of continuous VLAN IDs as ranges. All VLANs
in a range have identical configuration. Default is off (show each VLAN
separately).
> .TP
> .BR \-c [ color ][ = { always | auto | never }
> Configure color output. If parameter is omitted or
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage
2024-03-22 12:39 ` [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage Date Huang
@ 2024-03-22 12:54 ` Nikolay Aleksandrov
0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2024-03-22 12:54 UTC (permalink / raw
To: Date Huang, roopa, jiri; +Cc: netdev, bridge
On 3/22/24 14:39, Date Huang wrote:
> Fix the incorrect short opt for compressvlans and color
> in usage
>
> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
> ---
> bridge/bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bridge/bridge.c b/bridge/bridge.c
> index f4805092..ef592815 100644
> --- a/bridge/bridge.c
> +++ b/bridge/bridge.c
> @@ -39,7 +39,7 @@ static void usage(void)
> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
> -" -c[ompressvlans] -color -p[retty] -j[son] }\n");
> +" -com[pressvlans] -c[olor] -p[retty] -j[son] }\n");
> exit(-1);
> }
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage
2024-03-22 12:39 ` [PATCH iproute2-next v2 2/2] " Date Huang
2024-03-22 12:54 ` Nikolay Aleksandrov
@ 2024-03-22 15:41 ` Stephen Hemminger
2024-03-25 5:34 ` Date Huang
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-03-22 15:41 UTC (permalink / raw
To: Date Huang; +Cc: roopa, razor, jiri, netdev, bridge
On Fri, 22 Mar 2024 20:39:23 +0800
Date Huang <tjjh89017@hotmail.com> wrote:
> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
> index eeea4073..bb02bd27 100644
> --- a/man/man8/bridge.8
> +++ b/man/man8/bridge.8
> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
> \fB\-s\fR[\fItatistics\fR] |
> \fB\-n\fR[\fIetns\fR] name |
> \fB\-b\fR[\fIatch\fR] filename |
> +\fB\-com\fR[\fIpressvlans\fR] |
> \fB\-c\fR[\fIolor\fR] |
> \fB\-p\fR[\fIretty\fR] |
> \fB\-j\fR[\fIson\fR] |
> @@ -345,6 +346,11 @@ Don't terminate bridge command on errors in batch mode.
> If there were any errors during execution of the commands, the application
> return code will be non zero.
>
> +.TP
> +.BR "\-com", " \-compressvlans"
> +Show compressed VLAN list. It will show continuous VLANs with the range instead
> +of separated VLANs. Default is off.
> +
Overlapping option strings can cause problems, maybe a better word?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage
2024-03-22 15:41 ` Stephen Hemminger
@ 2024-03-25 5:34 ` Date Huang
0 siblings, 0 replies; 6+ messages in thread
From: Date Huang @ 2024-03-25 5:34 UTC (permalink / raw
To: Stephen Hemminger; +Cc: roopa, razor, jiri, netdev, bridge
Hi Stephen
On 3/22/2024 11:41 PM, Stephen Hemminger wrote:
> On Fri, 22 Mar 2024 20:39:23 +0800
> Date Huang <tjjh89017@hotmail.com> wrote:
>
>> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>> index eeea4073..bb02bd27 100644
>> --- a/man/man8/bridge.8
>> +++ b/man/man8/bridge.8
>> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
>> \fB\-s\fR[\fItatistics\fR] |
>> \fB\-n\fR[\fIetns\fR] name |
>> \fB\-b\fR[\fIatch\fR] filename |
>> +\fB\-com\fR[\fIpressvlans\fR] |
>> \fB\-c\fR[\fIolor\fR] |
>> \fB\-p\fR[\fIretty\fR] |
>> \fB\-j\fR[\fIson\fR] |
>> @@ -345,6 +346,11 @@ Don't terminate bridge command on errors in batch mode.
>> If there were any errors during execution of the commands, the application
>> return code will be non zero.
>>
>> +.TP
>> +.BR "\-com", " \-compressvlans"
>> +Show compressed VLAN list. It will show continuous VLANs with the range instead
>> +of separated VLANs. Default is off.
>> +
>
> Overlapping option strings can cause problems, maybe a better word?
I just add the missing manual page and change the usage for the current
implementation. Maybe you could suggest some better option string for us?
Thank you
Date
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-25 5:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240322123923.16346-1-tjjh89017@hotmail.com>
2024-03-22 12:39 ` [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage Date Huang
2024-03-22 12:54 ` Nikolay Aleksandrov
2024-03-22 12:39 ` [PATCH iproute2-next v2 2/2] " Date Huang
2024-03-22 12:54 ` Nikolay Aleksandrov
2024-03-22 15:41 ` Stephen Hemminger
2024-03-25 5:34 ` Date Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.