From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434F0C48BCF for ; Sat, 12 Jun 2021 18:23:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3245361108 for ; Sat, 12 Jun 2021 18:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3245361108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 54CB7800D9; Sat, 12 Jun 2021 20:23:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qOnbD6kB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 21F4180377; Sat, 12 Jun 2021 20:23:48 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 91101800AA for ; Sat, 12 Jun 2021 20:23:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ej1-x62b.google.com with SMTP id og14so9513657ejc.5 for ; Sat, 12 Jun 2021 11:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:date:message-id:cc:subject :from:to:references:in-reply-to; bh=0XibiVlHb4UWK2T6CtLDcaFu1vto9cdz8ZVN4BL+Di8=; b=qOnbD6kBBO7fdAQZ2EwRcB9HvzL53NrLsGIEscPKmGggpBWz7YpGMe3uU8D0U9d42Y 2+2q7QZ79zpC3lleaRX6GhuLGQiEnHT9CZCX5Me45JVCZaVLFtOB7ny6ZOYO4dMeMvIm UDkEMKMbS/LE+qWrM3a77C/5Bd3E7ytXsSqtNJM14r85pKmepPg8ZG4rzBTG0BxyzgRv kDQ5UHK8RCHHts0wh8+RXiTsQJeYFQ3SjwUKPWnxFPvjSZPjofQcuRb3zs+eLot9Sj2W 9Rby7Q/y/kkv1W2qK7EmpsNEMpqJGjLGJ9w/ZcBITVaMIkS9rESpoWui4xNLb86FjTcJ sBPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:cc:subject:from:to:references:in-reply-to; bh=0XibiVlHb4UWK2T6CtLDcaFu1vto9cdz8ZVN4BL+Di8=; b=UoaV7rDtO8eT9K4RN0GLH5guv5w7tm7TTpseBgnt1tKLVxvvPkeiIGkndvhHQO7A+Q FBe+NLWR+ZHEzhZKLCw7ua36c9yvKi0EdiF1kCt6LJDIfiwZUCfN07ewyqxkGR35fe5i n37B95ygXYrMn66qC0VdCs+kZsPf8NiZqru4aRWCi/1fjNIxIE46ReENPFm2jEh9R9Bt jiyvV2AMY3vW3QhPzyeMIbaFXwweFZVf5aed/lBTeohclcIWH2xW7BtIO9oi9y61WNlq QFcnEJ6zgpebB21IvW5uQsH9lOy/WNucUMc6YUWe2waRke4nx0J9pCbeiPVj7UD2Ny68 5V3Q== X-Gm-Message-State: AOAM533NV2y4VNCvHrrxExtkXkvgxksotY64P7yrSiZ/fcvlNQUFot73 axi3OSiqjxfbKQMxpHkCsEc= X-Google-Smtp-Source: ABdhPJwpnm+lt02XFSHpKHiZ3uzF5gkbIdOUeGsEQ4vpfxb/lUskxjfCOw+CSkq9amZOHdgcn2k22Q== X-Received: by 2002:a17:906:3e1a:: with SMTP id k26mr8556765eji.423.1623522225208; Sat, 12 Jun 2021 11:23:45 -0700 (PDT) Received: from localhost ([2a00:a040:198:e68a::1004]) by smtp.gmail.com with ESMTPSA id z20sm3427354ejd.18.2021.06.12.11.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Jun 2021 11:23:44 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 12 Jun 2021 21:23:42 +0300 Message-Id: Cc: "Hannu Lounento" , "Martyn Welch" , "Sebastian Reichel" , "U-Boot Mailing List" Subject: Re: [PATCH] net: e1000: do not attempt to set hwaddr for i210 without FLASH From: "Ramon Fried" To: "Tim Harvey" , "Joe Hershberger" References: <20210416202509.3943-1-tharvey@gateworks.com> In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri Jun 11, 2021 at 7:01 PM IDT, Tim Harvey wrote: > On Thu, Apr 22, 2021 at 5:11 PM Ramon Fried > wrote: > > > > On Fri, Apr 16, 2021 at 11:25 PM Tim Harvey wro= te: > > > > > > commit f1bcad22dd19 ("net: e1000: add support for writing to EEPROM") > > > adds support for storing hwaddr in EEPROM however i210 devices do not > > > support this and thus results in errors such as: > > > Warning: e1000#0 failed to set MAC address' > > > > > > Check if a flash device is present and if not return -ENOSYS indicati= ng > > > this is not supported. > > > > > > Signed-off-by: Tim Harvey > > > --- > > > drivers/net/e1000.c | 4 ++++ > > > drivers/net/e1000.h | 1 + > > > 2 files changed, 5 insertions(+) > > > > > > diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c > > > index 694114eca7..60613b7df0 100644 > > > --- a/drivers/net/e1000.c > > > +++ b/drivers/net/e1000.c > > > @@ -5673,6 +5673,10 @@ static int e1000_write_hwaddr(struct eth_devic= e *dev) > > > > > > DEBUGOUT("%s: mac=3D%pM\n", __func__, mac); > > > > > > + if ((hw->eeprom.type =3D=3D e1000_eeprom_invm) && > > > + !(E1000_READ_REG(hw, EECD) & E1000_EECD_FLASH_DETECTED_I2= 10)) > > > + return -ENOSYS; > > > + > > > memset(current_mac, 0, 6); > > > > > > /* Read from EEPROM, not from registers, to make sure > > > diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h > > > index 072851ba31..082154a997 100644 > > > --- a/drivers/net/e1000.h > > > +++ b/drivers/net/e1000.h > > > @@ -1245,6 +1245,7 @@ struct e1000_hw { > > > #define E1000_EECD_FLUPD 0x00080000 /* Update FLASH */ > > > #define E1000_EECD_FLUPD_I210 0x00800000 /* Update FLASH */ > > > #define E1000_EECD_FLUDONE_I210 0x04000000 /* Update FLASH done*= / > > > +#define E1000_EECD_FLASH_DETECTED_I210 0x00080000 /* FLASH detected = */ > > > #define E1000_FLUDONE_ATTEMPTS 20000 > > > #define E1000_EECD_AUPDEN 0x00100000 /* Enable Autonomous FLASH u= pdate */ > > > #define E1000_EECD_SHADV 0x00200000 /* Shadow RAM Data Valid */ > > > -- > > > 2.17.1 > > > > > Reviewed-by: Ramon Fried > > Joe / Ramon, > > Can one of you pick this up? If I need to re-submit with Ramon's > 'reviewed by' please let me know. > > Best regards, > > Tim Applied to u-boot-net/master, thanks! Best regards, Ramon Fried