From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sun, 24 Sep 2017 22:15:39 -0400
Subject: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with
	pr_err()
In-Reply-To: <1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>
References: <1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>
 <1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>
Message-ID: <CAPnjgZ2ToabKduZpa39txkxgh5quTUQL-Gw5B73ho_W8w5u2Nw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 15 September 2017 at 23:10, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> U-Boot widely uses error() as a bit noisier variant of printf().
>
> This macro causes name conflict with the following line in
> include/linux/compiler-gcc.h:
>
>   # define __compiletime_error(message) __attribute__((error(message)))
>
> This prevents us from using __compiletime_error(), and makes it
> difficult to fully sync BUILD_BUG macros with Linux.  (Notice
> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)
>
> Let's convert error() into now treewide-available pr_err().
>
> Done with the help of Coccinelle, excluing tools/ directory.
>
> The semantic patch I used is as follows:
>
> // <smpl>
> @@@@
> -error
> +pr_err
>  (...)
> // </smpl>
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2: None
>

Reviewed-by: Simon Glass <sjg@chromium.org>