From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 24 Sep 2017 22:15:35 -0400 Subject: [U-Boot] [PATCH v2 8/8] dm: define dev_*() log functions in DM header In-Reply-To: <1505538646-19191-9-git-send-email-yamada.masahiro@socionext.com> References: <1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com> <1505538646-19191-9-git-send-email-yamada.masahiro@socionext.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15 September 2017 at 23:10, Masahiro Yamada wrote: > Many drivers use dev_err, dev_info, etc. for logging. Currently, > we are relying on , but I guess the best home is > , taking into account that Linux defines them in > . > > For now, I am keeping the ones in because lots of > Linux-originated code uses dev_*() just for the purpose of syncing, > but the first argument is not struct udevice, so we need to ignore > it. Once this issue is ironed out, it would be possible to prefix > log messages with a device name that emitted it, like Linux. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - newly added > > include/dm/device.h | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/compat.h | 17 ++++++++++++ > 2 files changed, 89 insertions(+) Reviewed-by: Simon Glass But shouldn't it be emerg rather than emerge? - Simon