From: Ulf Hansson <ulf.hansson@linaro.org>
To: Ricky Wu <ricky_wu@realtek.com>
Cc: wenchao.chen@unisoc.com, ricardo@marliere.net, marex@denx.de,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: core: resume not check card exist before powerup
Date: Thu, 28 Mar 2024 13:38:24 +0100 [thread overview]
Message-ID: <CAPDyKFo3dkzDDEU7Lk14zH0td0AP=z2RJQibj8SP6JeUuz=iFA@mail.gmail.com> (raw)
In-Reply-To: <20240327024545.138351-1-ricky_wu@realtek.com>
On Wed, 27 Mar 2024 at 03:46, Ricky Wu <ricky_wu@realtek.com> wrote:
>
> _mmc_sd_resume
> add get_cd before call powerup, make sure the card exist
Please elaborate more on what problem you are trying to solve, the
above doesn't make much sense to me, sorry.
Yes, the card may be removed while the system is suspended. Then, even
if ->get_cd() indicates that there is no card inserted in the
SD-card-slot, we may still have the card being registered - and then
we need to unregister it.
That said, we need to call mmc_power_up() in order to try to
communicate with the card again. At least that is what the
mmc_rescan() work assumes when it runs the bus_ops->detect() callback
at some point later in time.
>
> Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
> ---
> drivers/mmc/core/sd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 1c8148cdda50..35e036672cfb 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -1750,6 +1750,9 @@ static int _mmc_sd_resume(struct mmc_host *host)
> if (!mmc_card_suspended(host->card))
> goto out;
>
> + if (host->ops->get_cd && !host->ops->get_cd(host))
> + goto out;
> +
> mmc_power_up(host, host->card->ocr);
> err = mmc_sd_init_card(host, host->card->ocr, host->card);
> mmc_card_clr_suspended(host->card);
> --
> 2.25.1
>
Kind regards
Uffe
next prev parent reply other threads:[~2024-03-28 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 2:45 [PATCH] mmc: core: resume not check card exist before powerup Ricky Wu
2024-03-28 12:38 ` Ulf Hansson [this message]
2024-03-29 9:03 ` Ricky WU
2024-04-19 6:53 ` Ricky WU
2024-04-25 16:59 ` Ulf Hansson
2024-04-29 6:56 ` Ricky WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFo3dkzDDEU7Lk14zH0td0AP=z2RJQibj8SP6JeUuz=iFA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=ricardo@marliere.net \
--cc=ricky_wu@realtek.com \
--cc=wenchao.chen@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.