From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F71CC48BDF for ; Thu, 10 Jun 2021 18:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82348613F5 for ; Thu, 10 Jun 2021 18:51:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhFJSxO (ORCPT ); Thu, 10 Jun 2021 14:53:14 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52944 "EHLO mail-wm1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbhFJSxK (ORCPT ); Thu, 10 Jun 2021 14:53:10 -0400 Received: by mail-wm1-f45.google.com with SMTP id f17so6761495wmf.2 for ; Thu, 10 Jun 2021 11:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J21h3J8NVq3CdoGsD791C/g3nKNn/C1NFZAumTjol6w=; b=Y/Dc+vtX0dMNI2J1k+8fWMwRKoND/FZhtD9xDRSycyTrbFDvJND+xMM58qM2pvkp5E Ee8MMWjbDdYTiRqGQPmkkmZQ4vewdM9GwTqDdCLZzXXMbKs05zHSpU0YhCKpP9lBCdaQ mhFcSqBH2OvI2N3zDAXAvmhkQKBSd2wHzsgzLa3eM+cNzVF+9uzEwSLOHmwo6JR+Tlds Y9ZlXr9X8ebKE1aC/mdyd6OU54ydQvHaVLq4whjaO+Ee/TZHy1GaSTIsYFq4Mz8ejS6m Uh94HXhKle7/1cMx2/Eecuc28gxbh76KImlTsmSrRFrDBifW1M4S/ZoGFEhe5Mj1joVO MpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J21h3J8NVq3CdoGsD791C/g3nKNn/C1NFZAumTjol6w=; b=KnlEm4aVjOt/ZbheHw/x7xqbhKrvnFeHiBZKVk75VVPdbthN1fpX2xEXLr+nUd3Idz r2uDMfp1a+8k2euX4MxnUsMWY27WCz67sv2YCopesyjiOfPtlEKswBVRMz56VUI8Fo/H nswZLYfOiHSM/u16FxBr/Xwu1+muh8U/4ieijKgOZJvoPYACpf0IR1OtVq89aDyNj8yU GI6jUIXzHOnFbspJiZpd+GDFoPl/PQkRyYwBnC9D+QL1v5xrtRd/AU59xHv7z5qSihaW 9RpyR4vxi2EXVUfGKvKBLUMnaLIBYNQ2ifQIJdAOqCf/96EgzwcbDN/21KBscPWNPUnl tXtw== X-Gm-Message-State: AOAM530TjHFj/4U54ahuvrxkxleydnqXJCQajSnhJIIsdgQCTOwusbcj UOuq/qYbz/IdpARZrZpMUtzD4T+Kpk8A4HUdtruRUg== X-Google-Smtp-Source: ABdhPJwN6VUAoyeKBEXSZ7+YssMTmMPGp62MKEVGpKypso05r3nUnm3gJlrUmQgll/Tcrrzwth4Wa0qM7YTc+6x92lI= X-Received: by 2002:a1c:b603:: with SMTP id g3mr16392963wmf.58.1623351012835; Thu, 10 Jun 2021 11:50:12 -0700 (PDT) MIME-Version: 1.0 References: <20210610060643.595673-1-irogers@google.com> <20210610103927.44462e35@oasis.local.home> In-Reply-To: <20210610103927.44462e35@oasis.local.home> From: Ian Rogers Date: Thu, 10 Jun 2021 11:50:00 -0700 Message-ID: Subject: Re: [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose To: Steven Rostedt Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users , LKML , Linux-trace Users , Tzvetomir Stoyanov , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 7:39 AM Steven Rostedt wrote: > > On Wed, 9 Jun 2021 23:06:43 -0700 > Ian Rogers wrote: > > > libtraceevent has added more levels of debug printout and with changes > > like: > > https://lore.kernel.org/linux-trace-devel/20210507095022.1079364-3-tz.stoyanov@gmail.com > > previously generated output like "registering plugin" is no longer > > displayed. This change makes it so that if perf's verbose debug output > > is enabled then the debug and info libtraceevent messages can be > > displayed. > > As this API isn't present in the deprecated tools version of > > libtracevent I'm uploading this as an RFC. > > Thanks Ian, > > We need to start porting perf to using the upstream libtraceevent > library. I think the best way to do that is what we did with trace-cmd. > That is to have the make files check if the minimum version of > libtraceevent is installed, and if so, use that instead of the local > version. If it is not installed, produce a message encouraging the > developer to install the upstream libtraceevent and warn that it will > be using a deprecated older versino, then build the deprecated local > version. After some time, we could simply remove it and make it a > dependency, but I want to do that when all the main distros being used > have it. > > Currently its in the latest Debian, Ubuntu, and Fedora. I also believe > its in SUSE but have not checked. It's in Fedora 34, but it doesn't > appear to be in Fedora 33. As that's not too old, I don't think we > should make it a dependency as of yet. > > -- Steve Thanks! Is there a way to do something like: #if LIBTRACE_EVENT_API > 123 ... #endif so that we can make sure perf is taking advantage of the improvements in the libtraceevent API? Ian