* [Buildroot] [PATCH] package/python-pygments: support host package
@ 2023-09-30 19:06 Takumi Takahashi
2023-09-30 19:41 ` Thomas Petazzoni via buildroot
2023-10-01 3:42 ` [Buildroot] [PATCH v2] " Takumi Takahashi
0 siblings, 2 replies; 6+ messages in thread
From: Takumi Takahashi @ 2023-09-30 19:06 UTC (permalink / raw
To: buildroot
Cc: Asaf Kahlon, James Hilliard, Thomas Petazzoni, Mauro Condarelli,
Takumi Takahashi
---
package/python-pygments/python-pygments.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
index f151f0061b..e6d5ba25f5 100644
--- a/package/python-pygments/python-pygments.mk
+++ b/package/python-pygments/python-pygments.mk
@@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
PYTHON_PYGMENTS_SETUP_TYPE = setuptools
$(eval $(python-package))
+$(eval $(host-python-package))
--
2.42.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/python-pygments: support host package
2023-09-30 19:06 [Buildroot] [PATCH] package/python-pygments: support host package Takumi Takahashi
@ 2023-09-30 19:41 ` Thomas Petazzoni via buildroot
2023-10-01 3:11 ` Takumi Takahashi
2023-10-01 3:42 ` [Buildroot] [PATCH v2] " Takumi Takahashi
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-09-30 19:41 UTC (permalink / raw
To: Takumi Takahashi; +Cc: James Hilliard, Mauro Condarelli, Asaf Kahlon, buildroot
Hello Takumi,
On Sun, 1 Oct 2023 04:06:10 +0900
Takumi Takahashi <takumiiinn@gmail.com> wrote:
> ---
> package/python-pygments/python-pygments.mk | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your patch.
However, could you clarify on why you need a host variant of this
package, and how it gets used?
Also, we require all patches to have a Signed-off-by line from their
author. Without this, we cannot apply patches that are contributed.
Could you send a new version that (1) has an explanation of why you
need a host package and what uses it and (2) has your Signed-off-by
line?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/python-pygments: support host package
2023-09-30 19:41 ` Thomas Petazzoni via buildroot
@ 2023-10-01 3:11 ` Takumi Takahashi
0 siblings, 0 replies; 6+ messages in thread
From: Takumi Takahashi @ 2023-10-01 3:11 UTC (permalink / raw
To: Thomas Petazzoni; +Cc: James Hilliard, Mauro Condarelli, Asaf Kahlon, buildroot
Hello Thomas.
Thank you for your review.
> However, could you clarify on why you need a host variant of this
> package, and how it gets used?
>
> Also, we require all patches to have a Signed-off-by line from their
> author. Without this, we cannot apply patches that are contributed.
> Could you send a new version that (1) has an explanation of why you
> need a host package and what uses it and (2) has your Signed-off-by
> line?
(1)
The reason this patch is needed is because gtk-doc requires pygments.
The final goal is to submit a patch for lightdm, but since gtk-doc is
required to build lightdm, pygments will also be required.
Should I include the above reason in the commit log?
I would appreciate any additional advice.
(2)
Sorry, I forgot to include `Signed-off-by`.
Next version will include `Signed-off-by`.
Thank you.
Takumi
2023年10月1日(日) 4:41 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:
>
> Hello Takumi,
>
> On Sun, 1 Oct 2023 04:06:10 +0900
> Takumi Takahashi <takumiiinn@gmail.com> wrote:
>
> > ---
> > package/python-pygments/python-pygments.mk | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks for your patch.
>
> However, could you clarify on why you need a host variant of this
> package, and how it gets used?
>
> Also, we require all patches to have a Signed-off-by line from their
> author. Without this, we cannot apply patches that are contributed.
> Could you send a new version that (1) has an explanation of why you
> need a host package and what uses it and (2) has your Signed-off-by
> line?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/python-pygments: support host package
@ 2023-10-01 3:29 Takumi Takahashi
2023-10-01 3:37 ` Takumi Takahashi
0 siblings, 1 reply; 6+ messages in thread
From: Takumi Takahashi @ 2023-10-01 3:29 UTC (permalink / raw
To: buildroot
Cc: Asaf Kahlon, James Hilliard, Thomas Petazzoni, Mauro Condarelli,
Takumi Takahashi
The reason this patch is needed is because gtk-doc requires pygments.
The final goal is to submit a patch for lightdm, but since gtk-doc is
required to build lightdm, pygments will also be required.
Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
---
package/python-pygments/python-pygments.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
index f151f0061b..e6d5ba25f5 100644
--- a/package/python-pygments/python-pygments.mk
+++ b/package/python-pygments/python-pygments.mk
@@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
PYTHON_PYGMENTS_SETUP_TYPE = setuptools
$(eval $(python-package))
+$(eval $(host-python-package))
--
2.42.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/python-pygments: support host package
2023-10-01 3:29 [Buildroot] [PATCH] " Takumi Takahashi
@ 2023-10-01 3:37 ` Takumi Takahashi
0 siblings, 0 replies; 6+ messages in thread
From: Takumi Takahashi @ 2023-10-01 3:37 UTC (permalink / raw
To: buildroot; +Cc: James Hilliard, Mauro Condarelli, Asaf Kahlon, Thomas Petazzoni
Sorry, I'm not familiar with Git operations and forgot to add the patch version.
Give the new patch version and submit again.
2023年10月1日(日) 12:29 Takumi Takahashi <takumiiinn@gmail.com>:
>
> The reason this patch is needed is because gtk-doc requires pygments.
> The final goal is to submit a patch for lightdm, but since gtk-doc is
> required to build lightdm, pygments will also be required.
>
> Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
> ---
> package/python-pygments/python-pygments.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
> index f151f0061b..e6d5ba25f5 100644
> --- a/package/python-pygments/python-pygments.mk
> +++ b/package/python-pygments/python-pygments.mk
> @@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
> PYTHON_PYGMENTS_SETUP_TYPE = setuptools
>
> $(eval $(python-package))
> +$(eval $(host-python-package))
> --
> 2.42.0
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/python-pygments: support host package
2023-09-30 19:06 [Buildroot] [PATCH] package/python-pygments: support host package Takumi Takahashi
2023-09-30 19:41 ` Thomas Petazzoni via buildroot
@ 2023-10-01 3:42 ` Takumi Takahashi
1 sibling, 0 replies; 6+ messages in thread
From: Takumi Takahashi @ 2023-10-01 3:42 UTC (permalink / raw
To: buildroot
Cc: Asaf Kahlon, James Hilliard, Thomas Petazzoni, Mauro Condarelli,
Takumi Takahashi
The reason this patch is needed is because gtk-doc requires pygments.
The final goal is to submit a patch for lightdm, but since gtk-doc is
required to build lightdm, pygments will also be required.
Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
---
package/python-pygments/python-pygments.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
index f151f0061b..e6d5ba25f5 100644
--- a/package/python-pygments/python-pygments.mk
+++ b/package/python-pygments/python-pygments.mk
@@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
PYTHON_PYGMENTS_SETUP_TYPE = setuptools
$(eval $(python-package))
+$(eval $(host-python-package))
--
2.42.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-01 3:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-30 19:06 [Buildroot] [PATCH] package/python-pygments: support host package Takumi Takahashi
2023-09-30 19:41 ` Thomas Petazzoni via buildroot
2023-10-01 3:11 ` Takumi Takahashi
2023-10-01 3:42 ` [Buildroot] [PATCH v2] " Takumi Takahashi
-- strict thread matches above, loose matches on Subject: below --
2023-10-01 3:29 [Buildroot] [PATCH] " Takumi Takahashi
2023-10-01 3:37 ` Takumi Takahashi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.