* [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF in SPL stage
2021-01-13 2:59 [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage Peng Fan
@ 2021-01-13 2:41 ` Fabio Estevam
2021-01-13 2:43 ` [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF " Peng Fan
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2021-01-13 2:41 UTC (permalink / raw
To: u-boot
Hi Peng,
On Tue, Jan 12, 2021 at 11:29 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
These options do not apply to SPL. The CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF do.
I agree with the change, but I think you need:
- Remove SPL from the Subject and commit log.
- Add a phrase saying that it is safe to run with caches enabled on
these platforms.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
2021-01-13 2:41 ` [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF " Fabio Estevam
@ 2021-01-13 2:43 ` Peng Fan
0 siblings, 0 replies; 3+ messages in thread
From: Peng Fan @ 2021-01-13 2:43 UTC (permalink / raw
To: u-boot
> Subject: Re: [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in
> SPL stage
>
> Hi Peng,
>
> On Tue, Jan 12, 2021 at 11:29 PM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
>
> These options do not apply to SPL. The CONFIG_SPL_SYS_ICACHE_OFF and
> CONFIG_SPL_SYS_DCACHE_OFF do.
>
> I agree with the change, but I think you need:
>
> - Remove SPL from the Subject and commit log.
> - Add a phrase saying that it is safe to run with caches enabled on these
> platforms.
Sure. Thanks.
-Peng.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
@ 2021-01-13 2:59 Peng Fan
2021-01-13 2:41 ` [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF " Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2021-01-13 2:59 UTC (permalink / raw
To: u-boot
From: Peng Fan <peng.fan@nxp.com>
Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
This is to replace
https://patchwork.ozlabs.org/project/uboot/patch/20210103101144.4375-12-peng.fan at oss.nxp.com/
include/configs/imx8mn_evk.h | 2 --
include/configs/imx8mp_evk.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/include/configs/imx8mn_evk.h b/include/configs/imx8mn_evk.h
index 92f435f578..369aa538bf 100644
--- a/include/configs/imx8mn_evk.h
+++ b/include/configs/imx8mn_evk.h
@@ -25,8 +25,6 @@
#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K /* 8 KB */
#define CONFIG_SYS_SPL_MALLOC_START 0x42200000
#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
/* For RAW image gives a error info not panic */
#define CONFIG_SPL_ABORT_ON_RAW_IMAGE
diff --git a/include/configs/imx8mp_evk.h b/include/configs/imx8mp_evk.h
index 7abaf5ff84..f89950f74e 100644
--- a/include/configs/imx8mp_evk.h
+++ b/include/configs/imx8mp_evk.h
@@ -26,8 +26,6 @@
#define CONFIG_SPL_BSS_MAX_SIZE 0x400 /* 1 KB */
#define CONFIG_SYS_SPL_MALLOC_START 0x42200000
#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
#define CONFIG_SPL_ABORT_ON_RAW_IMAGE
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-13 2:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 2:59 [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage Peng Fan
2021-01-13 2:41 ` [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF " Fabio Estevam
2021-01-13 2:43 ` [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF " Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.