From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support
Date: Tue, 5 Jan 2021 14:06:15 +0100 [thread overview]
Message-ID: <CAMuHMdXOQTXfZE1YOWiVdmtwO0ohtS4gkZsxh-+=euJCq=ZCdQ@mail.gmail.com> (raw)
In-Reply-To: <20201227130407.10991-2-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On Sun, Dec 27, 2020 at 2:06 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Document the compatible value for the RAVB block in the Renesas R-Car
> V3U (R8A779A0) SoC. This variant has no stream buffer, so we only need
> to add the new compatible.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> @@ -40,6 +40,7 @@ properties:
> - renesas,etheravb-r8a77980 # R-Car V3H
> - renesas,etheravb-r8a77990 # R-Car E3
> - renesas,etheravb-r8a77995 # R-Car D3
> + - renesas,etheravb-r8a779a0 # R-Car V3U
> - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2
>
> reg: true
EtherAVB on R-Car V3U does have the Tx clock internal Delay Mode
bit in the APSR register, so its compatible value should be added to
the list of SoCs where tx-internal-delay-ps is required.
With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
The various Counter Registers starting at offset 0x700 are limited to
16-bit values, like on R-Car Gen2, while they support 32-bit values on
other R-Car Gen3 variants. The driver uses only the Transmit Retry Over
Counter Register (TROCR), for statistics, so we can just ignore that
difference.
V3U also has a new block of registers related to UDP/IP support (offset
0x800 and up). I guess we can just ignore them too, for now.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-01-05 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 13:04 [PATCH 0/5] v3u: add support for RAVB Wolfram Sang
2020-12-27 13:04 ` [PATCH 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support Wolfram Sang
2021-01-05 13:06 ` Geert Uytterhoeven [this message]
2021-01-08 3:36 ` Rob Herring
2020-12-27 13:04 ` [PATCH 2/5] clk: renesas: r8a779a0: add clocks for RAVB Wolfram Sang
2021-01-05 15:21 ` Geert Uytterhoeven
2020-12-27 13:04 ` [PATCH 3/5] arm64: dts: renesas: r8a779a0: Add Ethernet-AVB support Wolfram Sang
2021-01-05 15:31 ` Geert Uytterhoeven
2020-12-27 13:04 ` [PATCH 4/5] arm64: dts: renesas: falcon: " Wolfram Sang
2021-01-05 16:20 ` Geert Uytterhoeven
2021-01-05 16:27 ` Wolfram Sang
2021-01-12 11:45 ` Geert Uytterhoeven
2020-12-27 13:04 ` [PATCH 5/5] arm64: dts: r8a779a0: WIP disable reset-gpios for AVB Wolfram Sang
2020-12-28 13:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXOQTXfZE1YOWiVdmtwO0ohtS4gkZsxh-+=euJCq=ZCdQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.