From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework
Date: Thu, 31 Jan 2019 20:21:29 +0530 [thread overview]
Message-ID: <CAMty3ZCMDGscEntU=4HSLowrRJayFPoOgZuD-4niF5r4Kaqjzg@mail.gmail.com> (raw)
In-Reply-To: <CAAh8qsxLAeC-dpi-rVkLg+nq3u5nSrUf56KPXYzJK1zY09jyhA@mail.gmail.com>
On Thu, Jan 31, 2019 at 8:18 PM Simon Goldschmidt
<simon.k.r.goldschmidt@gmail.com> wrote:
>
> On Thu, Jan 31, 2019 at 3:43 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Jan 31, 2019 at 08:10:53PM +0530, Jagan Teki wrote:
> > > On Tue, Jan 29, 2019 at 11:19 AM Vignesh R <vigneshr@ti.com> wrote:
> > > >
> > > > Here is the v3 of SPI NOR migration(github branch at [1]). I have
> > > > retained Tested-by from v2 as this is just re split of patches and
> > > > minor fixups.
> > > >
> > > > Travis ci reports all green.
> > > >
> > > > Change log:
> > > > Since v2:
> > > > Split sync up patches into smaller versions so that its easier for review.
> > > > Address comments by Jagan and Simon Goldschmidt on v2.
> > > > Make SPI_FLASH_TINY(read only SF stack) as default for SPL build to
> > > > offset against size increase due to new code.
> > > >
> > > > Since v1:
> > > > Remove #ifindef __UBOOT__
> > > > Add back BAR support, but dont enable as default for all platform (see
> > > > 10/11 for more details)
> > > > Enable SPI_FLASH_TINY on boards where there is SPL size constraint as
> > > > seen on travis ci builds.
> > > > Drop sf_mtd changes for now as it seems to cause issues.
> > > > v1: https://patchwork.ozlabs.org/cover/1012146/
> > > >
> > > > Since RFC v2:
> > > > Fix issues reported by Simon Goldschmidt wrt 4 use of byte addressing opcode
> > > > Fix issues in compiling SFDP code
> > > > Re organize file names and Makefile to simply spi-nor-tiny inclusion
> > > > Remove SPI_FLASH_BAR and SF_DUAL_FLASH as these are no longer used
> > > > RFC v2: https://patchwork.ozlabs.org/cover/1007589/
> > > >
> > > > Since RFC v1:
> > > > Add lightweight SPI flash stack for boards with SPL size constraints
> > > > Provide non DM version of spi-mem
> > > > Fix build issues on different platforms as reported by travis-ci on v1
> > > >
> > > > RFC v1: https://patchwork.ozlabs.org/cover/1004689/
> > > >
> > > > Background:
> > > >
> > > > U-Boot SPI NOR support (sf layer) is quite outdated as it does not
> > > > support 4 byte addressing opcodes, SFDP table parsing and different types of
> > > > quad mode enable sequences. Many newer flashes no longer support BANK
> > > > registers used by sf layer to a access >16MB space.
> > > > Also, many SPI controllers have special MMIO interfaces which provide
> > > > accelerated read/write access but require knowledge of flash parameters
> > > > to make use of it. Recent spi-mem layer provides a way to support such
> > > > flashes but sf layer isn't using that.
> > > > This patch series syncs SPI NOR framework from Linux v4.19. It also adds
> > > > spi-mem support on top.
> > > > So, we gain 4byte addressing support and SFDP support. This makes
> > > > migrating to U-Boot MTD framework easier.
> > > >
> > > > Tested with few Spansion, micron and macronix flashes with TI's dra7xx,
> > > > k2g, am43xx EVMs. I dont have access to flashes from other vendors. So,
> > > > I would greatly appreciate testing on other platforms. Complete series
> > > > with dependencies here[1]
> > > >
> > > > For clean build on some platforms, depends on CONFIG_SPI_FLASH migration
> > > > to defconfigs [2]
> > > >
> > > > [1] https://github.com/r-vignesh/u-boot.git branch: spi-nor-mig-patch-v3
> > > > [2] https://patchwork.ozlabs.org/patch/1007485/
> > > >
> > > > Vignesh R (20):
> > > > configs: Move CONFIG_SPI_FLASH into defconfigs
> > > > bitops: Fix GENMASK definition for Sandbox
> > > > spi: spi-mem: Allow use of spi_mem_exec_op for all SPI modes
> > > > spi: spi-mem: Extend spi_mem_adjust_op_size() to honor max xfer size
> > > > spi: spi-mem: Claim SPI bus before spi mem access
> > > > spi: Add non DM version of SPI_MEM
> > > > sh: bitops: add hweight*() macros
> > > > mtd: spi: Port SPI NOR framework from Linux
> > > > mtd: spi: spi-nor-core: Add SPI MEM support
> > > > mtd: spi: spi-nor-core: Add 4 Byte addressing support
> > > > mtd: spi: spi-nor-core: Add SFDP support
> > > > mtd: spi: spi-nor-core: Add back U-Boot specific features
> > > > mtd: spi: sf_probe: Add "jedec,spi-nor" compatible string
> > > > mtd: spi: Switch to new SPI NOR framework
> > > > mtd: spi: Remove unused files
> > > > mtd: spi: Add lightweight SPI flash stack for SPL
> > > > spl: Kconfig: Enable SPI_FLASH_TINY by default for SPL
> > > > configs: Remove SF_DUAL_FLASH
> > > > configs: Don't use SPI_FLASH_BAR as default
> > > > MAINTAINERS: Add an entry for SPI NOR
> > >
> > > Except 16/20 and 19/20, all look fine to me.
> > >
> > > Reviewed-by: Jagan Teki <jagan@openedev.com>
> > > Tested-by: Jagan Teki <jagan@amarulasolutions.com> #zynq-microzed
> >
> > And based on the Xilinx folks reply to 19/20, is 16/20 something we can
> > deal with as a follow-up? Thanks!
>
> Going without 16/20 will increase the footprint in SPL. Given the limitation
> of size checks discussed recently, I don't think that would be a good idea.
Please read the my comments again, I won't oppose the change.
next prev parent reply other threads:[~2019-01-31 14:51 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 5:49 [U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 01/20] configs: Move CONFIG_SPI_FLASH into defconfigs Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 02/20] bitops: Fix GENMASK definition for Sandbox Vignesh R
2019-01-31 0:41 ` Simon Glass
2019-01-31 13:34 ` Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 03/20] spi: spi-mem: Allow use of spi_mem_exec_op for all SPI modes Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 04/20] spi: spi-mem: Extend spi_mem_adjust_op_size() to honor max xfer size Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 05/20] spi: spi-mem: Claim SPI bus before spi mem access Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 06/20] spi: Add non DM version of SPI_MEM Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 07/20] sh: bitops: add hweight*() macros Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 08/20] mtd: spi: Port SPI NOR framework from Linux Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 09/20] mtd: spi: spi-nor-core: Add SPI MEM support Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 10/20] mtd: spi: spi-nor-core: Add 4 Byte addressing support Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 11/20] mtd: spi: spi-nor-core: Add SFDP support Vignesh R
2019-01-29 5:49 ` [U-Boot] [PATCH v3 12/20] mtd: spi: spi-nor-core: Add back U-Boot specific features Vignesh R
2019-01-29 5:50 ` [U-Boot] [PATCH v3 13/20] mtd: spi: sf_probe: Add "jedec, spi-nor" compatible string Vignesh R
2019-01-29 5:50 ` [U-Boot] [PATCH v3 14/20] mtd: spi: Switch to new SPI NOR framework Vignesh R
2019-01-31 12:23 ` Jagan Teki
2019-01-31 12:39 ` Vignesh R
2019-01-31 12:39 ` Jagan Teki
2019-01-31 12:55 ` Vignesh R
2019-01-31 12:57 ` Jagan Teki
2019-01-29 5:50 ` [U-Boot] [PATCH v3 15/20] mtd: spi: Remove unused files Vignesh R
2019-01-29 5:50 ` [U-Boot] [PATCH v3 16/20] mtd: spi: Add lightweight SPI flash stack for SPL Vignesh R
2019-01-31 12:06 ` Jagan Teki
2019-01-31 17:51 ` Vignesh R
2019-02-01 15:48 ` Jagan Teki
2019-02-01 17:04 ` Vignesh R
2019-02-02 13:12 ` Jagan Teki
2019-01-29 5:50 ` [U-Boot] [PATCH v3 17/20] spl: Kconfig: Enable SPI_FLASH_TINY by default " Vignesh R
2019-01-29 5:50 ` [U-Boot] [PATCH v3 18/20] configs: Remove SF_DUAL_FLASH Vignesh R
2019-01-29 5:50 ` [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default Vignesh R
2019-01-31 13:18 ` Jagan Teki
2019-01-31 13:33 ` Vignesh R
2019-01-31 13:36 ` Jagan Teki
2019-01-31 13:47 ` Vignesh R
2019-01-31 13:50 ` Jagan Teki
2019-01-31 17:35 ` Vignesh R
2019-02-01 15:54 ` Jagan Teki
2019-02-01 17:08 ` Vignesh R
2019-02-02 13:10 ` Jagan Teki
2019-01-29 5:50 ` [U-Boot] [PATCH v3 20/20] MAINTAINERS: Add an entry for SPI NOR Vignesh R
2019-01-29 8:15 ` [U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework Simon Goldschmidt
2019-01-29 11:56 ` Vignesh R
2019-01-29 11:58 ` Simon Goldschmidt
2019-01-29 12:25 ` Tom Rini
2019-01-31 14:40 ` Jagan Teki
2019-01-31 14:42 ` Tom Rini
2019-01-31 14:45 ` Jagan Teki
2019-02-01 8:27 ` Vignesh R
2019-02-04 19:03 ` Jagan Teki
2019-01-31 14:48 ` Simon Goldschmidt
2019-01-31 14:51 ` Jagan Teki [this message]
2019-01-31 14:54 ` Tom Rini
2019-01-31 14:58 ` Simon Goldschmidt
2019-01-31 15:02 ` Tom Rini
2019-01-31 15:08 ` Simon Goldschmidt
2019-01-31 15:00 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMty3ZCMDGscEntU=4HSLowrRJayFPoOgZuD-4niF5r4Kaqjzg@mail.gmail.com' \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.