From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84FCC433DB for ; Fri, 22 Jan 2021 01:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAF18223C8 for ; Fri, 22 Jan 2021 01:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbhAVBpu (ORCPT ); Thu, 21 Jan 2021 20:45:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbhAVBp2 (ORCPT ); Thu, 21 Jan 2021 20:45:28 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4706AC0613D6 for ; Thu, 21 Jan 2021 17:44:48 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id n7so2625169pgg.2 for ; Thu, 21 Jan 2021 17:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c4szIhxH58SMfeVsu2cGON3xQLWlR2gAfHY2l9My0L8=; b=a6E6wHRDhh6LN0zT+gjJXJcFUZBVsc6638mvWFQzyVsuS51s+OwWbiU55E7HNwYz7Z JZE1Lz7xQvSXDcbQThCBjxqzCI6EUN2tSTTpbx9onXiuHvcHEO7zddqYeVCwAR4S3fXS gK0rhQhXal4sXWroklw4rUX4xDDaY87IIGfg5AfxKG3O8fZaIgctnnprP7f0auVRBvF0 XW7XPJe6aTWrBcNzB9nsDtl5MCDogw8G9PetX6unc28syclklmSYgA6wznRpP5HUmtq0 wzCFEvaI/a6GchYzEIfRCHsdG/ZnUpb1rG5gbXTEEasKCPIv2v9MVZV2uSKrY7UI8krQ N7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c4szIhxH58SMfeVsu2cGON3xQLWlR2gAfHY2l9My0L8=; b=t3IHr/ecrJMn9SPVB3PT61o1U5Mkke8+PwFeGFuFEQa3AmLggEi+raELcfIRr1ElYI QVxe8X9lJ7xRgKsEacY7BiqE4KvuJmDO0z7hNdPtW75o779xqfipGx2i01tVltG97Yob avUrAwMuV6WTmtxXveRFIIoSBA1pEKSCG/Lft3t6oZFOy5xlcnh5WaidFrv8gImlrh/k akbiQmRRnwob8EatgHQQdp1j0zYmNPNoi0qaBrpG9WVu9LFhjFX+c0eMJaVuBouUxH9G z53/Ri8sD9fhLm2G+dQY+3OlNNlS51VPHKMMVV+LmaZZJlDd9Ma5yY8wGpc5/2AUEOM9 gyFQ== X-Gm-Message-State: AOAM532ZZLVq4+mKxxgfNSZ6KBhJyeAfq9S/EyOAZnkFfZ+5CQdE6Wyc /RCIpIyzfVVyyEIrD2btkyTRwMbBtFaBe8fu1njXjA== X-Google-Smtp-Source: ABdhPJyn75We1U9pL6cl3QASmqae4ZTH30VZWF4AgzRj3Sc9zpsG2zekUkyvDfhFuoaJMfu5IHsKM6IUG7ewSpNML+I= X-Received: by 2002:a62:838d:0:b029:1ba:9b85:2eac with SMTP id h135-20020a62838d0000b02901ba9b852eacmr2304176pfe.36.1611279887579; Thu, 21 Jan 2021 17:44:47 -0800 (PST) MIME-Version: 1.0 References: <20210116094357.3620352-1-morbo@google.com> <20210121082451.2240540-1-morbo@google.com> In-Reply-To: From: Nick Desaulniers Date: Thu, 21 Jan 2021 17:44:36 -0800 Message-ID: Subject: Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure To: Sedat Dilek Cc: Bill Wendling , Jonathan Corbet , Masahiro Yamada , Linux Doc Mailing List , LKML , Linux Kbuild mailing list , Clang-Built-Linux ML , Andrew Morton , Nathan Chancellor , Sami Tolvanen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 2:35 AM Sedat Dilek wrote: > > Thanks for v6. > > Small Changelog nits: > * Can you reverse-order the changelog - latest v6 first. > * v4: s/Makfile changes and se/Ma*k*efile changes and *u*se > > Can you add a hint to this "Clang-PGO" patch requiring Clang >= 12? > > Can you please add a comment for people using Clang >= 12 (ToT) and > have kernel-modules enabled, they will need the patch from CBL issue > #1250? > Otherwise they cannot boot and follow the next steps in the workflow. > > Can you put a comment about value "1" to reset the profiling counter? > That there is no "0" value stopping it. > > Can you add an example for the workload test? > Here I do a x86-64 defconfig build. > See attached script. > > Usually, I download this patch from LORE. > > link="https://lore.kernel.org/r/20210111081821.3041587-1-morbo@google.com" > b4 -d am $link > > This downloads v6. > > What if I want a previous version (compare)? > Again, I will love to see a "clang-pgo" branch and maybe tags for the > several versions in your personal GitHub. > Come on, Bill :-). That's quite a long list, Sedat! Do you think some of these can be follow ups, once the core lands? I'd much prefer to land the meat of this and follow up quickly, than tire out poor Bill! :P -- Thanks, ~Nick Desaulniers