From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C656C4345F for ; Fri, 19 Apr 2024 16:43:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21C76B0088; Fri, 19 Apr 2024 12:43:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D17D6B0092; Fri, 19 Apr 2024 12:43:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898FE6B0093; Fri, 19 Apr 2024 12:43:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6B78A6B0088 for ; Fri, 19 Apr 2024 12:43:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1DDAA25D7 for ; Fri, 19 Apr 2024 16:43:08 +0000 (UTC) X-FDA: 82026851256.02.9F1F541 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf03.hostedemail.com (Postfix) with ESMTP id 2D1C520022 for ; Fri, 19 Apr 2024 16:43:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LHOUYPx6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713544987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dtE/0r9aKWX1tYUSYTffs1EcYK5K2eKAPlL1XcyB0S0=; b=7ZuaF1n8ikcGi8JS6j3yTjKPSuOgstpXN9PUqvbPhfK6h82uCRPQ8rbExsBZkC+pN7fbi6 0gTSmQkTpKOQUoPzOX4pZBSGUatiL7f+ItoSeOsABdzMkQ/Cr2FXOK6ZvDdVhjOV7WkWlq 5s4SaKsYkdTd1ySakDMQYf0La9mUHgs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LHOUYPx6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713544987; a=rsa-sha256; cv=none; b=r70MiofK73rNW7hcNfrEN4foGpS5ALXanOmaXMv5EElf+D2cmRc20jB6eGv1ilsGKKsrNJ p01vfnQET2CpNPfTe3GxQR7zaYApEGY46DOLGuZSJZVx/pvbRHwzm2Ed9xDFf2WECVDOhM GtR+OH4SemRotVYWkY8HOyldSQ3i5dM= Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7e652fd228fso512568241.1 for ; Fri, 19 Apr 2024 09:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713544986; x=1714149786; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dtE/0r9aKWX1tYUSYTffs1EcYK5K2eKAPlL1XcyB0S0=; b=LHOUYPx698TqxXfFGFtdGg5YJpyVHVhJgt2kphoKgxhksDKHxm26IPgnONzE7Qkc9U JBR9BBlzTdEbN2kPLmEf2KZH0at2rv3gQgxLCmyat8riCDzCeFs4BBbyNzrpW7RuY7cw xi43dSf/Xr5S3pcjCj3pWulDj5RqT6NJVKd33aPW80r6y6Vpt9edqpYE1FGHA/2PG8bY DMIWsCIV/MaNwA+7V+Z1Uh5Aa8i52N+xpLBScuFew1G6681Cgno+OKU2h7vI5xsymznL 6rD29U39BullBqBn9cxGtmNQeyQfhbbmVwzgBq3CgYfkN/QyqvTQN5V/8DIzoKad6U1K bQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713544986; x=1714149786; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dtE/0r9aKWX1tYUSYTffs1EcYK5K2eKAPlL1XcyB0S0=; b=Z0VFV1TBdY9Z34Oj7ettSbmZ+moGrcwdfjgEIL2xCieZgsDWgbMpvjITQk1csgwK7A 29T3EfqUtItvgMsir9nGBQiatUqo1LGyXDrJMq1bxTmS0uIMgbjQEJCAyBs6DQzwp7RU tuTwzKiWd5ZbBx31nq+DTtT/X4nxgyyRB1FzMfB8X3i7UAaE09SHVKtJdg32Cw2PoK9R R17kbTDb2cjSoteBPPaWx5kglAEcLBwNtpjVVByrZORPvAn5WiTYttCNqKW5OWzWi9EK aXWkpiooUa2YpUbf9CATpw4wThTtgD0ItmFCcXMeNwfCwMrWPlTweeE7hpaX5cYfUw5T 9exg== X-Forwarded-Encrypted: i=1; AJvYcCVV0Xpi0Mqv7TOjDkV0X29SKSFe98wJoCNzpc26bXbn37os9t0keWzg1LMUaeawSOWY1ODioVtwYWAU7iF4DccKCyk= X-Gm-Message-State: AOJu0Yw0iwymSyp1iOzG0v9VRpc/fKhfwssw8IWc3Ttsc1SMp3Yfmrzl IoZss1FTvgn4Cb6Ph4jMYfql1irOV2PQZuXeak1yBd63XnBXuiPcMpQdG094+UECWK1oqocF6mW qtNAqInY1KN+6l0nxOjBoCmJdrpg= X-Google-Smtp-Source: AGHT+IF0+YHtgfgnR35Av/Ix9olJe5O/Kxm0PRINiGwCyk5Cu7U+oM1okZJ3LcXSHF8deT1raRZs6VHavlZLvbrcVTE= X-Received: by 2002:a05:6122:1696:b0:4d4:2fc1:b252 with SMTP id 22-20020a056122169600b004d42fc1b252mr3035441vkl.6.1713544985991; Fri, 19 Apr 2024 09:43:05 -0700 (PDT) MIME-Version: 1.0 References: <20240419034350.127838-1-jeffxu@chromium.org> <20240419034350.127838-2-jeffxu@chromium.org> In-Reply-To: <20240419034350.127838-2-jeffxu@chromium.org> From: Pedro Falcato Date: Fri, 19 Apr 2024 17:42:54 +0100 Message-ID: Subject: Re: [PATCH 1/1] selftest mm/mseal: fix compile warning To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, jeffxu@google.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2D1C520022 X-Rspam-User: X-Stat-Signature: jc3tbgb665zp9c4cux17ax9ow1aika1n X-HE-Tag: 1713544987-213837 X-HE-Meta: U2FsdGVkX18YtuGORvYebQ7gJhcr8q0B2YhnpOjDeFAPrctvfZH6CJA6pwg4LPa253Wx/b3o/EAOMLWIknf6Wbt4OUUe5OyE3TntaqXQSSGRaeaL0YxqruUfjGwQdJ90Tx2y4Dt135+jOsQB7WYVis15P07AABmuCDPpCUh6VwGJu988b/MQ5lZgxFa3Jv0ZjwP6MjpReAK620XdLGONeewDaVLSOCkbv74gfGvoKwjvSV1hB0jzGP5BcwQaZjRA+lHKO0ntJuC+i5I8oRaDyD6AMffy8b08kaxIqGr9DI5lq9Bc7uNM72ecQSpZ87ncU7bNX8XBUaPzN83rAtMGg3yj34mMd73kUS0zzJiESbM9d0g6sc6eg2SbWVKYdXpsS8t6plwGUmO+HoaEaeJQcmqn8Mh1g31CNzvz9o3G2FcRtlKYBkYRWWPsrlqwPCYC6FR0t3YJJlqY+PvhMrpla5/HG6WsraqTuopckwPSCSyH3PG9qpumIOVVpL63UXgOfCUvXY55st/QREjpPPd6XUEr0rw64yfMUcnRxD1VeRH6lrWNLQQKfBU2QyFUeClV4i822JxTJTRXrWS29VGlWZTjrhEsu5qw3l0rymGn5SorTp3YppGu9zhOSRX8nLWPaLW02i4zmeCOXj87rKZxYIfYCQ64UPSMljqQj+9Irf/WV1S++bDEuSktEadyry3z8RvDbf5LG7DccHqQstNn+DV0WtREyB9jQUFCrJSKVzk7+XVLWMCSPaMzp4wiDvUEQ3pLEUaSnGrMQVqK5MkVpR9oRGLGMRQG+NGqovJIVZG/SKHyQCiGfRGBxnYakzSwYlW21ERI7j03Eh75MFDDrI+gM3hJ5mcg/TrvKAQbgIRebi0WT6ZvKxr5b3+KZG3+rbOfNEEFA1nos3gSWdlypB6Z/d8HNcMN9AmXd37fV8FQ0XvgWDbA3yskIr8bhSBr9i/V4SYCeDbDt0X++NI 6r9NiEwA waVbVlu0WQcEUHIm/Mr87zrc9jEjN+tRtNzP/6mCLNraHOKaTUf7YZZ8797wRjW5adfW0BWBRHSo5LD1T96H57bYypPvki9bXbj2GHVu4Vy1OGXVTfR2XVk0+ijx0fzmNS1shvVxhh2R6FrCXc1NMBVeThrXWlW3HxpDkBhZLza7EMiQHKGhwHyBwMG3tDirT0ToM73Lh4SOkuyG2z0ab66cGOIrTbzHC7D0jvno9h0A6Ksbhk0kmHaHzWP7WvV0oSDd/7eVxj/2paKzQYm37GgUj0e+EUuIWM3jRVqYru85Vlxn0/0apEIViIWSctSMzPg/vJdDPAXfONSVC+gk+F0yt6KleAL1HNoNsgxIcWOpHJwYgWdGgpTTR6cReksvsc+ICunDX4oeMIK0dnq9Ye1U134ADgjUGWQQ+TlH2uBw+jiKgmYGHyEgqX++uAldDEXucEVwhg0dHTR4Ang+lwY7SCRi45UMDbdshs7umukvnsLIp0JzgktPIoVM8wuL45UIaYD8+tOLOeSc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 4:44=E2=80=AFAM wrote: > > From: Jeff Xu > > fix compile warning reported by test robot > > Signed-off-by: Jeff Xu > Reported-by: kernel test robot > Closes: https://lore.kernel.org/r/202404190226.OfJOewV8-lkp@intel.com/ > --- > tools/testing/selftests/mm/mseal_test.c | 3 +-- > tools/testing/selftests/mm/seal_elf.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/self= tests/mm/mseal_test.c > index 4a326334726d..35cdae93e580 100644 > --- a/tools/testing/selftests/mm/mseal_test.c > +++ b/tools/testing/selftests/mm/mseal_test.c > @@ -79,7 +79,7 @@ static unsigned long get_vma_size(void *addr, int *prot= ) > return 0; > > while (fgets(line, sizeof(line), maps)) { > - if (sscanf(line, "%lx-%lx %4s", &addr_start, &addr_end, &= protstr) =3D=3D 3) { > + if (sscanf(line, "%lx-%lx %4s", &addr_start, &addr_end, (= char *) &protstr) =3D=3D 3) { This fix is wrong. You can simply do: + if (sscanf(line, "%lx-%lx %4s", &addr_start, &addr_end, protstr) =3D=3D 3) { and it'll just work (arrays decay to pointers when required). > if (addr_start =3D=3D (uintptr_t) addr) { > size =3D addr_end - addr_start; > if (protstr[0] =3D=3D 'r') > @@ -208,7 +208,6 @@ static u64 set_pkey_bits(u64 reg, int pkey, u64 flags= ) > > static void set_pkey(int pkey, unsigned long pkey_value) > { > - unsigned long mask =3D (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE)= ; > u64 new_pkey_reg; > > new_pkey_reg =3D set_pkey_bits(__read_pkey_reg(), pkey, pkey_valu= e); > diff --git a/tools/testing/selftests/mm/seal_elf.c b/tools/testing/selfte= sts/mm/seal_elf.c > index 7143dc4f1b10..b7e72f9804f8 100644 > --- a/tools/testing/selftests/mm/seal_elf.c > +++ b/tools/testing/selftests/mm/seal_elf.c > @@ -105,7 +105,6 @@ static void test_seal_elf(void) > int ret; > FILE *maps; > char line[512]; > - int size =3D 0; > uintptr_t addr_start, addr_end; > char prot[5]; > char filename[256]; > @@ -136,7 +135,7 @@ static void test_seal_elf(void) > */ > while (fgets(line, sizeof(line), maps)) { > if (sscanf(line, "%lx-%lx %4s %*x %*x:%*x %*u %255[^\n]", > - &addr_start, &addr_end, &prot, &filename) =3D=3D = 4) { > + &addr_start, &addr_end, (char *)&prot, (char *)&f= ilename) =3D=3D 4) { aaand same here. --=20 Pedro