From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAFCC47094 for ; Thu, 10 Jun 2021 15:13:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA91C61359 for ; Thu, 10 Jun 2021 15:13:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA91C61359 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A132D89D2F; Thu, 10 Jun 2021 15:13:30 +0000 (UTC) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32DE189D2F for ; Thu, 10 Jun 2021 15:13:30 +0000 (UTC) Received: by mail-oi1-x235.google.com with SMTP id w127so2446457oig.12 for ; Thu, 10 Jun 2021 08:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=63W3/iVz7u/ETiCu5+gG98ItxxoSVyRpvyqM4WeGAV4=; b=Fi12xoGAm63rNC4/P6yVLsDWXA8YK+ZHy10s92j67n5h23gqWXybCTP8ap6ZWGZdIB sH5P6fFDtyEpqNYq5H14QyLtq6fSa/tFwIdcWG1550DH/MgENDqbTBSzb3/Q75E+af9i C8gnRp9K3s+GcZ9D9JQQx9uYuaAMN6Yemd8bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=63W3/iVz7u/ETiCu5+gG98ItxxoSVyRpvyqM4WeGAV4=; b=oKI/5e8RSAxT0dXokq+aWGjr6zirYu86MDbBz3nxZrcY52rrBF38mrx8egrRHXvhSw hC8YMMJAjLrJerxRi36/Io0DrHVQt146NIPDEESdJ7E65DT2xPmqAPGzeH9i71+CeMLO CofpKVYFkUtKettdPw/jQineTrRj676Tgmg3gOO4EiUpftUYnHzCUvPdqQMjdLdurV/F SUvLU3LR30zhEHrCwt9YXNZs4kvBNU8f8H8dnZehYVNX7byHcB36ynxaaLH7Zo9m1tL0 aYpDG+cH9xnoBPpMVUW1+akK4Jr6ajIJJ5GqD5Ple/p7rI7muKJrTCEeTSspf3zjB2ZF I/bA== X-Gm-Message-State: AOAM532VcagG5x/xiIcUubDTx0azAcJLXE9smxE0cv1FJ0wDDsEV7yvB uMc7W91P+PPVCT45krUxqe+r3Je1jfd+LeUsrPZV4w== X-Google-Smtp-Source: ABdhPJxUmWqV5rf117N66awWktbA/kw1wr/ayHwxShdDndzIBhrUjAXZpGcS2MUdeSRJym/tLKJVheSc+IMPD6qL2fs= X-Received: by 2002:aca:530f:: with SMTP id h15mr3867905oib.128.1623338009450; Thu, 10 Jun 2021 08:13:29 -0700 (PDT) MIME-Version: 1.0 References: <20210609212959.471209-1-jason@jlekstrand.net> <20210609212959.471209-6-jason@jlekstrand.net> In-Reply-To: From: Daniel Vetter Date: Thu, 10 Jun 2021 17:13:18 +0200 Message-ID: To: Jason Ekstrand Subject: Re: [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , =?UTF-8?Q?Christian_K=C3=B6nig?= , Maling list - DRI developers , Matthew Auld Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVGh1LCBKdW4gMTAsIDIwMjEgYXQgMzo1OSBQTSBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxl a3N0cmFuZC5uZXQ+IHdyb3RlOgo+Cj4gT24gVGh1LCBKdW4gMTAsIDIwMjEgYXQgMTo1MSBBTSBD aHJpc3RpYW4gS8O2bmlnCj4gPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gd3JvdGU6Cj4gPgo+ ID4gQW0gMDkuMDYuMjEgdW0gMjM6Mjkgc2NocmllYiBKYXNvbiBFa3N0cmFuZDoKPiA+ID4gVGhp cyBoZWxwZXIgZXhpc3RlZCB0byBoYW5kbGUgdGhlIHdlaXJkIGNvcm5lci1jYXNlcyBjYXVzZWQg YnkgdXNpbmcKPiA+ID4gU0xBQl9UWVBFU0FGRV9CWV9SQ1UgZm9yIGJhY2tpbmcgZG1hX2ZlbmNl LiAgTm93IHRoYXQgbm8gb25lIGlzIHVzaW5nCj4gPiA+IHRoYXQgYW55bW9yZSAoaTkxNSB3YXMg dGhlIG9ubHkgcmVhbCB1c2VyKSwgZG1hX2ZlbmNlX2dldF9yY3UgaXMKPiA+ID4gc3VmZmljaWVu dC4gIFRoZSBvbmUgc2xpZ2h0bHkgYW5ub3lpbmcgdGhpbmcgd2UgaGF2ZSB0byBkZWFsIHdpdGgg aGVyZQo+ID4gPiBpcyB0aGF0IGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUgZGlkIGFuIHJjdV9kZXJl ZmVyZW5jZSBhcyB3ZWxsIGFzIGEKPiA+ID4gU0xBQl9UWVBFU0FGRV9CWV9SQ1Utc2FmZSBkbWFf ZmVuY2VfZ2V0X3JjdS4gIFRoaXMgbWVhbnMgZWFjaCBjYWxsIHNpdGUKPiA+ID4gZW5kcyB1cCBi ZWluZyAzIGxpbmVzIGluc3RlYWQgb2YgMS4KPiA+Cj4gPiBUaGF0J3MgYW4gb3V0cmlnaHQgTkFL Lgo+ID4KPiA+IFRoZSBsb29wIGluIGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUgaXMgbmVjZXNzYXJ5 IGJlY2F1c2UgdGhlIHVuZGVybHlpbmcKPiA+IGZlbmNlIG9iamVjdCBjYW4gYmUgcmVwbGFjZWQg d2hpbGUgdGFraW5nIHRoZSByZWZlcmVuY2UuCj4KPiBSaWdodC4gIEkgaGFkIG1pc3NlZCBhIGJp dCBvZiB0aGF0IHdoZW4gSSBmaXJzdCByZWFkIHRocm91Z2ggaXQuICBJCj4gc2VlIHRoZSBuZWVk IGZvciB0aGUgbG9vcCBub3cuICBCdXQgdGhlcmUgYXJlIHNvbWUgb3RoZXIgdHJpY2t5IGJpdHMK PiBpbiB0aGVyZSBiZXNpZGVzIGp1c3QgdGhlIGxvb3AuCgpJIHRob3VnaHQgdGhhdCdzIHdoYXQg dGhlIGtyZWZfZ2V0X3VubGVzc196ZXJvIHdhcyBmb3IgaW4KZG1hX2ZlbmNlX2dldF9yY3U/IE90 aGVyd2lzZSBJIGd1ZXNzIEknbSBub3Qgc2VlaW5nIHdoeSBzdGlsbCBoYXZlCmRtYV9mZW5jZV9n ZXRfcmN1IGFyb3VuZCwgc2luY2UgdGhhdCBzaG91bGQgZWl0aGVyIGJlIGEga3JlZl9nZXQgb3IK aXQncyBqdXN0IHVuc2FmZSB0byBjYWxsIGl0IC4uLgoKPiA+IFRoaXMgaXMgY29tcGxldGVseSB1 bnJlbGF0ZWQgdG8gU0xBQl9UWVBFU0FGRV9CWV9SQ1UuIFNlZSB0aGUKPiA+IGRtYV9mZW5jZV9j aGFpbiB1c2FnZSBmb3IgcmVmZXJlbmNlLgo+ID4KPiA+IFdoYXQgeW91IGNhbiByZW1vdmUgaXMg dGhlIHNlcXVlbmNlIG51bWJlciBoYW5kbGluZyBpbiBkbWEtYnVmLiBUaGF0Cj4gPiBzaG91bGQg bWFrZSBhZGRpbmcgZmVuY2VzIHF1aXRlIGEgYml0IHF1aWNrZXIuCj4KPiBJJ2xsIGxvb2sgYXQg dGhhdCBhbmQgdHJ5IHRvIHVuZGVyc3RhbmQgd2hhdCdzIGdvaW5nIG9uIHRoZXJlLgoKSG0gSSB0 aG91Z2h0IHRoZSBzZXFsb2NrIHdhcyB0byBtYWtlIHN1cmUgd2UgaGF2ZSBhIGNvbnNpc3RlbnQg c2V0IG9mCmZlbmNlcyBhY3Jvc3MgZXhjbHVzaXZlIGFuZCBhbGwgc2hhcmVkIHNsb3QuIE5vdCB0 byBwcm90ZWN0IGFnYWluc3QKdGhlIGZlbmNlIGRpc2FwcGVhcmluZyBkdWUgdG8gdHlwZXNhZmVf YnlfcmN1LgotRGFuaWVsCgo+IC0tSmFzb24KPgo+ID4gUmVnYXJkcywKPiA+IENocmlzdGlhbi4K PiA+Cj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEphc29uIEVrc3RyYW5kIDxqYXNvbkBqbGVr c3RyYW5kLm5ldD4KPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu Y2g+Cj4gPiA+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ Cj4gPiA+IENjOiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRlbC5jb20+Cj4gPiA+IENj OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLWNoYWluLmMgICAgICAg ICB8ICA4ICsrLS0KPiA+ID4gICBkcml2ZXJzL2RtYS1idWYvZG1hLXJlc3YuYyAgICAgICAgICAg ICAgICB8ICA0ICstCj4gPiA+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Zl bmNlLmMgfCAgNCArLQo+ID4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfYWN0aXZlLmgg ICAgICAgIHwgIDQgKy0KPiA+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5jICAg ICAgICAgICB8ICA0ICstCj4gPiA+ICAgaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaCAgICAgICAg ICAgICAgICAgfCAgNCArLQo+ID4gPiAgIGluY2x1ZGUvbGludXgvZG1hLWZlbmNlLmggICAgICAg ICAgICAgICAgIHwgNTAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4gICBpbmNsdWRlL2xp bnV4L2RtYS1yZXN2LmggICAgICAgICAgICAgICAgICB8ICA0ICstCj4gPiA+ICAgOCBmaWxlcyBj aGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2UtY2hhaW4uYyBiL2RyaXZlcnMvZG1h LWJ1Zi9kbWEtZmVuY2UtY2hhaW4uYwo+ID4gPiBpbmRleCA3ZDEyOWU2OGFjNzAxLi40NmRmYzdk OTRkOGVkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLWNoYWlu LmMKPiA+ID4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS1jaGFpbi5jCj4gPiA+IEBA IC0xNSwxNSArMTUsMTcgQEAgc3RhdGljIGJvb2wgZG1hX2ZlbmNlX2NoYWluX2VuYWJsZV9zaWdu YWxpbmcoc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UpOwo+ID4gPiAgICAqIGRtYV9mZW5jZV9jaGFp bl9nZXRfcHJldiAtIHVzZSBSQ1UgdG8gZ2V0IGEgcmVmZXJlbmNlIHRvIHRoZSBwcmV2aW91cyBm ZW5jZQo+ID4gPiAgICAqIEBjaGFpbjogY2hhaW4gbm9kZSB0byBnZXQgdGhlIHByZXZpb3VzIG5v ZGUgZnJvbQo+ID4gPiAgICAqCj4gPiA+IC0gKiBVc2UgZG1hX2ZlbmNlX2dldF9yY3Vfc2FmZSB0 byBnZXQgYSByZWZlcmVuY2UgdG8gdGhlIHByZXZpb3VzIGZlbmNlIG9mIHRoZQo+ID4gPiAtICog Y2hhaW4gbm9kZS4KPiA+ID4gKyAqIFVzZSByY3VfZGVyZWZlcmVuY2UgYW5kIGRtYV9mZW5jZV9n ZXRfcmN1IHRvIGdldCBhIHJlZmVyZW5jZSB0byB0aGUKPiA+ID4gKyAqIHByZXZpb3VzIGZlbmNl IG9mIHRoZSBjaGFpbiBub2RlLgo+ID4gPiAgICAqLwo+ID4gPiAgIHN0YXRpYyBzdHJ1Y3QgZG1h X2ZlbmNlICpkbWFfZmVuY2VfY2hhaW5fZ2V0X3ByZXYoc3RydWN0IGRtYV9mZW5jZV9jaGFpbiAq Y2hhaW4pCj4gPiA+ICAgewo+ID4gPiAgICAgICBzdHJ1Y3QgZG1hX2ZlbmNlICpwcmV2Owo+ID4g Pgo+ID4gPiAgICAgICByY3VfcmVhZF9sb2NrKCk7Cj4gPiA+IC0gICAgIHByZXYgPSBkbWFfZmVu Y2VfZ2V0X3JjdV9zYWZlKCZjaGFpbi0+cHJldik7Cj4gPiA+ICsgICAgIHByZXYgPSByY3VfZGVy ZWZlcmVuY2UoY2hhaW4tPnByZXYpOwo+ID4gPiArICAgICBpZiAocHJldikKPiA+ID4gKyAgICAg ICAgICAgICBwcmV2ID0gZG1hX2ZlbmNlX2dldF9yY3UocHJldik7Cj4gPiA+ICAgICAgIHJjdV9y ZWFkX3VubG9jaygpOwo+ID4gPiAgICAgICByZXR1cm4gcHJldjsKPiA+ID4gICB9Cj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYvZG1hLXJlc3YuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9k bWEtcmVzdi5jCj4gPiA+IGluZGV4IGYyNmM3MTc0N2Q0M2EuLmNmZTBkYjNjY2EyOTIgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtcmVzdi5jCj4gPiA+ICsrKyBiL2RyaXZl cnMvZG1hLWJ1Zi9kbWEtcmVzdi5jCj4gPiA+IEBAIC0zNzYsNyArMzc2LDkgQEAgaW50IGRtYV9y ZXN2X2NvcHlfZmVuY2VzKHN0cnVjdCBkbWFfcmVzdiAqZHN0LCBzdHJ1Y3QgZG1hX3Jlc3YgKnNy YykKPiA+ID4gICAgICAgICAgICAgICBkc3RfbGlzdCA9IE5VTEw7Cj4gPiA+ICAgICAgIH0KPiA+ ID4KPiA+ID4gLSAgICAgbmV3ID0gZG1hX2ZlbmNlX2dldF9yY3Vfc2FmZSgmc3JjLT5mZW5jZV9l eGNsKTsKPiA+ID4gKyAgICAgbmV3ID0gcmN1X2RlcmVmZXJlbmNlKHNyYy0+ZmVuY2VfZXhjbCk7 Cj4gPiA+ICsgICAgIGlmIChuZXcpCj4gPiA+ICsgICAgICAgICAgICAgbmV3ID0gZG1hX2ZlbmNl X2dldF9yY3UobmV3KTsKPiA+ID4gICAgICAgcmN1X3JlYWRfdW5sb2NrKCk7Cj4gPiA+Cj4gPiA+ ICAgICAgIHNyY19saXN0ID0gZG1hX3Jlc3Zfc2hhcmVkX2xpc3QoZHN0KTsKPiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9mZW5jZS5jIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ZlbmNlLmMKPiA+ID4gaW5kZXggNzJkOWI5MmIx NzU0Ny4uMGFlYjYxMTdmMzg5MyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2ZlbmNlLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2ZlbmNlLmMKPiA+ID4gQEAgLTE2MSw3ICsxNjEsOSBAQCBpbnQgYW1kZ3B1 X2ZlbmNlX2VtaXQoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLCBzdHJ1Y3QgZG1hX2ZlbmNlICoq ZiwKPiA+ID4gICAgICAgICAgICAgICBzdHJ1Y3QgZG1hX2ZlbmNlICpvbGQ7Cj4gPiA+Cj4gPiA+ ICAgICAgICAgICAgICAgcmN1X3JlYWRfbG9jaygpOwo+ID4gPiAtICAgICAgICAgICAgIG9sZCA9 IGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUocHRyKTsKPiA+ID4gKyAgICAgICAgICAgICBvbGQgPSBy Y3VfZGVyZWZlcmVuY2UoKnB0cik7Cj4gPiA+ICsgICAgICAgICAgICAgaWYgKG9sZCkKPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgIG9sZCA9IGRtYV9mZW5jZV9nZXRfcmN1KG9sZCk7Cj4gPiA+ ICAgICAgICAgICAgICAgcmN1X3JlYWRfdW5sb2NrKCk7Cj4gPiA+Cj4gPiA+ICAgICAgICAgICAg ICAgaWYgKG9sZCkgewo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9hY3RpdmUuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfYWN0aXZlLmgKPiA+ID4gaW5k ZXggZDBmZWRhNjhiODc0Zi4uYmQ4OWNmYzgwNmNhNSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9hY3RpdmUuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2FjdGl2ZS5oCj4gPiA+IEBAIC0xMDMsNyArMTAzLDkgQEAgaTkxNV9hY3RpdmVf ZmVuY2VfZ2V0KHN0cnVjdCBpOTE1X2FjdGl2ZV9mZW5jZSAqYWN0aXZlKQo+ID4gPiAgICAgICBz dHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZTsKPiA+ID4KPiA+ID4gICAgICAgcmN1X3JlYWRfbG9jaygp Owo+ID4gPiAtICAgICBmZW5jZSA9IGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUoJmFjdGl2ZS0+ZmVu Y2UpOwo+ID4gPiArICAgICBmZW5jZSA9IHJjdV9kZXJlZmVyZW5jZShhY3RpdmUtPmZlbmNlKTsK PiA+ID4gKyAgICAgaWYgKGZlbmNlKQo+ID4gPiArICAgICAgICAgICAgIGZlbmNlID0gZG1hX2Zl bmNlX2dldF9yY3UoZmVuY2UpOwo+ID4gPiAgICAgICByY3VfcmVhZF91bmxvY2soKTsKPiA+ID4K PiA+ID4gICAgICAgcmV0dXJuIGZlbmNlOwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV92bWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMKPiA+ ID4gaW5kZXggMGYyMjdmMjhiMjgwMi4uZWQwMzg4ZDk5MTk3ZSAxMDA2NDQKPiA+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3ZtYS5jCj4gPiA+IEBAIC0zNTEsNyArMzUxLDkgQEAgaW50IGk5MTVfdm1h X3dhaXRfZm9yX2JpbmQoc3RydWN0IGk5MTVfdm1hICp2bWEpCj4gPiA+ICAgICAgICAgICAgICAg c3RydWN0IGRtYV9mZW5jZSAqZmVuY2U7Cj4gPiA+Cj4gPiA+ICAgICAgICAgICAgICAgcmN1X3Jl YWRfbG9jaygpOwo+ID4gPiAtICAgICAgICAgICAgIGZlbmNlID0gZG1hX2ZlbmNlX2dldF9yY3Vf c2FmZSgmdm1hLT5hY3RpdmUuZXhjbC5mZW5jZSk7Cj4gPiA+ICsgICAgICAgICAgICAgZmVuY2Ug PSByY3VfZGVyZWZlcmVuY2Uodm1hLT5hY3RpdmUuZXhjbC5mZW5jZSk7Cj4gPiA+ICsgICAgICAg ICAgICAgaWYgKGZlbmNlKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgZmVuY2UgPSBkbWFf ZmVuY2VfZ2V0X3JjdShmZW5jZSk7Cj4gPiA+ICAgICAgICAgICAgICAgcmN1X3JlYWRfdW5sb2Nr KCk7Cj4gPiA+ICAgICAgICAgICAgICAgaWYgKGZlbmNlKSB7Cj4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICBlcnIgPSBkbWFfZmVuY2Vfd2FpdChmZW5jZSwgTUFYX1NDSEVEVUxFX1RJTUVPVVQp Owo+ID4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaCBiL2luY2x1ZGUv ZHJtL2RybV9zeW5jb2JqLmgKPiA+ID4gaW5kZXggNmNmNzI0M2ExZGM1ZS4uNmM0NWQ1Mjk4OGJj YyAxMDA2NDQKPiA+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaAo+ID4gPiArKysg Yi9pbmNsdWRlL2RybS9kcm1fc3luY29iai5oCj4gPiA+IEBAIC0xMDUsNyArMTA1LDkgQEAgZHJt X3N5bmNvYmpfZmVuY2VfZ2V0KHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaikKPiA+ID4gICAg ICAgc3RydWN0IGRtYV9mZW5jZSAqZmVuY2U7Cj4gPiA+Cj4gPiA+ICAgICAgIHJjdV9yZWFkX2xv Y2soKTsKPiA+ID4gLSAgICAgZmVuY2UgPSBkbWFfZmVuY2VfZ2V0X3JjdV9zYWZlKCZzeW5jb2Jq LT5mZW5jZSk7Cj4gPiA+ICsgICAgIGZlbmNlID0gcmN1X2RlcmVmZXJlbmNlKHN5bmNvYmotPmZl bmNlKTsKPiA+ID4gKyAgICAgaWYgKGZlbmNlKQo+ID4gPiArICAgICAgICAgICAgIGZlbmNlID0g ZG1hX2ZlbmNlX2dldF9yY3Uoc3luY29iai0+ZmVuY2UpOwo+ID4gPiAgICAgICByY3VfcmVhZF91 bmxvY2soKTsKPiA+ID4KPiA+ID4gICAgICAgcmV0dXJuIGZlbmNlOwo+ID4gPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9saW51eC9kbWEtZmVuY2UuaCBiL2luY2x1ZGUvbGludXgvZG1hLWZlbmNlLmgK PiA+ID4gaW5kZXggNmZmYjRiMmM2MzcxNS4uZjRhMmFiMmIxYWU0NiAxMDA2NDQKPiA+ID4gLS0t IGEvaW5jbHVkZS9saW51eC9kbWEtZmVuY2UuaAo+ID4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2Rt YS1mZW5jZS5oCj4gPiA+IEBAIC0zMDcsNTYgKzMwNyw2IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0 IGRtYV9mZW5jZSAqZG1hX2ZlbmNlX2dldF9yY3Uoc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UpCj4g PiA+ICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gPiA+ICAgfQo+ID4gPgo+ID4gPiAtLyoq Cj4gPiA+IC0gKiBkbWFfZmVuY2VfZ2V0X3JjdV9zYWZlICAtIGFjcXVpcmUgYSByZWZlcmVuY2Ug dG8gYW4gUkNVIHRyYWNrZWQgZmVuY2UKPiA+ID4gLSAqIEBmZW5jZXA6IHBvaW50ZXIgdG8gZmVu Y2UgdG8gaW5jcmVhc2UgcmVmY291bnQgb2YKPiA+ID4gLSAqCj4gPiA+IC0gKiBGdW5jdGlvbiBy ZXR1cm5zIE5VTEwgaWYgbm8gcmVmY291bnQgY291bGQgYmUgb2J0YWluZWQsIG9yIHRoZSBmZW5j ZS4KPiA+ID4gLSAqIFRoaXMgZnVuY3Rpb24gaGFuZGxlcyBhY3F1aXJpbmcgYSByZWZlcmVuY2Ug dG8gYSBmZW5jZSB0aGF0IG1heSBiZQo+ID4gPiAtICogcmVhbGxvY2F0ZWQgd2l0aGluIHRoZSBS Q1UgZ3JhY2UgcGVyaW9kIChzdWNoIGFzIHdpdGggU0xBQl9UWVBFU0FGRV9CWV9SQ1UpLAo+ID4g PiAtICogc28gbG9uZyBhcyB0aGUgY2FsbGVyIGlzIHVzaW5nIFJDVSBvbiB0aGUgcG9pbnRlciB0 byB0aGUgZmVuY2UuCj4gPiA+IC0gKgo+ID4gPiAtICogQW4gYWx0ZXJuYXRpdmUgbWVjaGFuaXNt IGlzIHRvIGVtcGxveSBhIHNlcWxvY2sgdG8gcHJvdGVjdCBhIGJ1bmNoIG9mCj4gPiA+IC0gKiBm ZW5jZXMsIHN1Y2ggYXMgdXNlZCBieSBzdHJ1Y3QgZG1hX3Jlc3YuIFdoZW4gdXNpbmcgYSBzZXFs b2NrLAo+ID4gPiAtICogdGhlIHNlcWxvY2sgbXVzdCBiZSB0YWtlbiBiZWZvcmUgYW5kIGNoZWNr ZWQgYWZ0ZXIgYSByZWZlcmVuY2UgdG8gdGhlCj4gPiA+IC0gKiBmZW5jZSBpcyBhY3F1aXJlZCAo YXMgc2hvd24gaGVyZSkuCj4gPiA+IC0gKgo+ID4gPiAtICogVGhlIGNhbGxlciBpcyByZXF1aXJl ZCB0byBob2xkIHRoZSBSQ1UgcmVhZCBsb2NrLgo+ID4gPiAtICovCj4gPiA+IC1zdGF0aWMgaW5s aW5lIHN0cnVjdCBkbWFfZmVuY2UgKgo+ID4gPiAtZG1hX2ZlbmNlX2dldF9yY3Vfc2FmZShzdHJ1 Y3QgZG1hX2ZlbmNlIF9fcmN1ICoqZmVuY2VwKQo+ID4gPiAtewo+ID4gPiAtICAgICBkbyB7Cj4g PiA+IC0gICAgICAgICAgICAgc3RydWN0IGRtYV9mZW5jZSAqZmVuY2U7Cj4gPiA+IC0KPiA+ID4g LSAgICAgICAgICAgICBmZW5jZSA9IHJjdV9kZXJlZmVyZW5jZSgqZmVuY2VwKTsKPiA+ID4gLSAg ICAgICAgICAgICBpZiAoIWZlbmNlKQo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7Cj4gPiA+IC0KPiA+ID4gLSAgICAgICAgICAgICBpZiAoIWRtYV9mZW5jZV9nZXRfcmN1 KGZlbmNlKSkKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4gPiAtCj4g PiA+IC0gICAgICAgICAgICAgLyogVGhlIGF0b21pY19pbmNfbm90X3plcm8oKSBpbnNpZGUgZG1h X2ZlbmNlX2dldF9yY3UoKQo+ID4gPiAtICAgICAgICAgICAgICAqIHByb3ZpZGVzIGEgZnVsbCBt ZW1vcnkgYmFycmllciB1cG9uIHN1Y2Nlc3MgKHN1Y2ggYXMgbm93KS4KPiA+ID4gLSAgICAgICAg ICAgICAgKiBUaGlzIGlzIHBhaXJlZCB3aXRoIHRoZSB3cml0ZSBiYXJyaWVyIGZyb20gYXNzaWdu aW5nCj4gPiA+IC0gICAgICAgICAgICAgICogdG8gdGhlIF9fcmN1IHByb3RlY3RlZCBmZW5jZSBw b2ludGVyIHNvIHRoYXQgaWYgdGhhdAo+ID4gPiAtICAgICAgICAgICAgICAqIHBvaW50ZXIgc3Rp bGwgbWF0Y2hlcyB0aGUgY3VycmVudCBmZW5jZSwgd2Uga25vdyB3ZQo+ID4gPiAtICAgICAgICAg ICAgICAqIGhhdmUgc3VjY2Vzc2Z1bGx5IGFjcXVpcmUgYSByZWZlcmVuY2UgdG8gaXQuIElmIGl0 IG5vCj4gPiA+IC0gICAgICAgICAgICAgICogbG9uZ2VyIG1hdGNoZXMsIHdlIGFyZSBob2xkaW5n IGEgcmVmZXJlbmNlIHRvIHNvbWUgb3RoZXIKPiA+ID4gLSAgICAgICAgICAgICAgKiByZWFsbG9j YXRlZCBwb2ludGVyLiBUaGlzIGlzIHBvc3NpYmxlIGlmIHRoZSBhbGxvY2F0b3IKPiA+ID4gLSAg ICAgICAgICAgICAgKiBpcyB1c2luZyBhIGZyZWVsaXN0IGxpa2UgU0xBQl9UWVBFU0FGRV9CWV9S Q1Ugd2hlcmUgdGhlCj4gPiA+IC0gICAgICAgICAgICAgICogZmVuY2UgcmVtYWlucyB2YWxpZCBm b3IgdGhlIFJDVSBncmFjZSBwZXJpb2QsIGJ1dCBpdAo+ID4gPiAtICAgICAgICAgICAgICAqIG1h eSBiZSByZWFsbG9jYXRlZC4gV2hlbiB1c2luZyBzdWNoIGFsbG9jYXRvcnMsIHdlIGFyZQo+ID4g PiAtICAgICAgICAgICAgICAqIHJlc3BvbnNpYmxlIGZvciBlbnN1cmluZyB0aGUgcmVmZXJlbmNl IHdlIGdldCBpcyB0bwo+ID4gPiAtICAgICAgICAgICAgICAqIHRoZSByaWdodCBmZW5jZSwgYXMg YmVsb3cuCj4gPiA+IC0gICAgICAgICAgICAgICovCj4gPiA+IC0gICAgICAgICAgICAgaWYgKGZl bmNlID09IHJjdV9hY2Nlc3NfcG9pbnRlcigqZmVuY2VwKSkKPiA+ID4gLSAgICAgICAgICAgICAg ICAgICAgIHJldHVybiByY3VfcG9pbnRlcl9oYW5kb2ZmKGZlbmNlKTsKPiA+ID4gLQo+ID4gPiAt ICAgICAgICAgICAgIGRtYV9mZW5jZV9wdXQoZmVuY2UpOwo+ID4gPiAtICAgICB9IHdoaWxlICgx KTsKPiA+ID4gLX0KPiA+ID4gLQo+ID4gPiAgICNpZmRlZiBDT05GSUdfTE9DS0RFUAo+ID4gPiAg IGJvb2wgZG1hX2ZlbmNlX2JlZ2luX3NpZ25hbGxpbmcodm9pZCk7Cj4gPiA+ICAgdm9pZCBkbWFf ZmVuY2VfZW5kX3NpZ25hbGxpbmcoYm9vbCBjb29raWUpOwo+ID4gPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9saW51eC9kbWEtcmVzdi5oIGIvaW5jbHVkZS9saW51eC9kbWEtcmVzdi5oCj4gPiA+IGlu ZGV4IDU2MmI4ODVjZjljM2QuLmEzOGMwMjFmMzc5YWYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2luY2x1 ZGUvbGludXgvZG1hLXJlc3YuaAo+ID4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2RtYS1yZXN2LmgK PiA+ID4gQEAgLTI0OCw3ICsyNDgsOSBAQCBkbWFfcmVzdl9nZXRfZXhjbF91bmxvY2tlZChzdHJ1 Y3QgZG1hX3Jlc3YgKm9iaikKPiA+ID4gICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiA+ID4K PiA+ID4gICAgICAgcmN1X3JlYWRfbG9jaygpOwo+ID4gPiAtICAgICBmZW5jZSA9IGRtYV9mZW5j ZV9nZXRfcmN1X3NhZmUoJm9iai0+ZmVuY2VfZXhjbCk7Cj4gPiA+ICsgICAgIGZlbmNlID0gcmN1 X2RlcmVmZXJlbmNlKG9iai0+ZmVuY2VfZXhjbCk7Cj4gPiA+ICsgICAgIGlmIChmZW5jZSkKPiA+ ID4gKyAgICAgICAgICAgICBmZW5jZSA9IGRtYV9mZW5jZV9nZXRfcmN1KGZlbmNlKTsKPiA+ID4g ICAgICAgcmN1X3JlYWRfdW5sb2NrKCk7Cj4gPiA+Cj4gPiA+ICAgICAgIHJldHVybiBmZW5jZTsK PiA+CgoKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F68CC48BD1 for ; Thu, 10 Jun 2021 15:13:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E29A613C8 for ; Thu, 10 Jun 2021 15:13:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E29A613C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2409289D63; Thu, 10 Jun 2021 15:13:31 +0000 (UTC) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B0389D4D for ; Thu, 10 Jun 2021 15:13:30 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id t140so2504729oih.0 for ; Thu, 10 Jun 2021 08:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=63W3/iVz7u/ETiCu5+gG98ItxxoSVyRpvyqM4WeGAV4=; b=Fi12xoGAm63rNC4/P6yVLsDWXA8YK+ZHy10s92j67n5h23gqWXybCTP8ap6ZWGZdIB sH5P6fFDtyEpqNYq5H14QyLtq6fSa/tFwIdcWG1550DH/MgENDqbTBSzb3/Q75E+af9i C8gnRp9K3s+GcZ9D9JQQx9uYuaAMN6Yemd8bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=63W3/iVz7u/ETiCu5+gG98ItxxoSVyRpvyqM4WeGAV4=; b=CaOrYHpGg86mB8KlezuUSCsC1OaYWXMeENNzJ5fx0ElKzXDkfTWlR2a118hLBT3qlq UYnKT+GmlefRM/AcBvcncvPh3tp3XNaIOCK6/9iTeu9Di4xMq/vp5RUChcb+iNHjnGdM Q+R8I2/9H/McBPtpKv3gudUCGCRQblOQ+yFmk9/IsZ4E/ByzC1CBzSrtr5getD8fQglh lJ61wLI16jlKd6Yzjq9C3PN8Rc1TMDq/1yDAxtPm3apdop5NWzvHrqiJaUbOizN1eANx XjwjqSR78N6iCv7Lis0mp+YC3kYRgrujhPc5hhZWYs72Bh+1gFNJrqwgfJpTuNuT+Wad iEhw== X-Gm-Message-State: AOAM533kiwFxwPq/W7csdDVRJzuG18p4QhoSDsi5RS8KtU8kPx7xmqX/ UJcm2EJT4lsP1gbyVrRhHL140G2gQ49eaUmWHJDfzQ== X-Google-Smtp-Source: ABdhPJxUmWqV5rf117N66awWktbA/kw1wr/ayHwxShdDndzIBhrUjAXZpGcS2MUdeSRJym/tLKJVheSc+IMPD6qL2fs= X-Received: by 2002:aca:530f:: with SMTP id h15mr3867905oib.128.1623338009450; Thu, 10 Jun 2021 08:13:29 -0700 (PDT) MIME-Version: 1.0 References: <20210609212959.471209-1-jason@jlekstrand.net> <20210609212959.471209-6-jason@jlekstrand.net> In-Reply-To: From: Daniel Vetter Date: Thu, 10 Jun 2021 17:13:18 +0200 Message-ID: Subject: Re: [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe To: Jason Ekstrand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , =?UTF-8?Q?Christian_K=C3=B6nig?= , Maling list - DRI developers , Matthew Auld Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 10, 2021 at 3:59 PM Jason Ekstrand wrote= : > > On Thu, Jun 10, 2021 at 1:51 AM Christian K=C3=B6nig > wrote: > > > > Am 09.06.21 um 23:29 schrieb Jason Ekstrand: > > > This helper existed to handle the weird corner-cases caused by using > > > SLAB_TYPESAFE_BY_RCU for backing dma_fence. Now that no one is using > > > that anymore (i915 was the only real user), dma_fence_get_rcu is > > > sufficient. The one slightly annoying thing we have to deal with her= e > > > is that dma_fence_get_rcu_safe did an rcu_dereference as well as a > > > SLAB_TYPESAFE_BY_RCU-safe dma_fence_get_rcu. This means each call si= te > > > ends up being 3 lines instead of 1. > > > > That's an outright NAK. > > > > The loop in dma_fence_get_rcu_safe is necessary because the underlying > > fence object can be replaced while taking the reference. > > Right. I had missed a bit of that when I first read through it. I > see the need for the loop now. But there are some other tricky bits > in there besides just the loop. I thought that's what the kref_get_unless_zero was for in dma_fence_get_rcu? Otherwise I guess I'm not seeing why still have dma_fence_get_rcu around, since that should either be a kref_get or it's just unsafe to call it ... > > This is completely unrelated to SLAB_TYPESAFE_BY_RCU. See the > > dma_fence_chain usage for reference. > > > > What you can remove is the sequence number handling in dma-buf. That > > should make adding fences quite a bit quicker. > > I'll look at that and try to understand what's going on there. Hm I thought the seqlock was to make sure we have a consistent set of fences across exclusive and all shared slot. Not to protect against the fence disappearing due to typesafe_by_rcu. -Daniel > --Jason > > > Regards, > > Christian. > > > > > > > > Signed-off-by: Jason Ekstrand > > > Cc: Daniel Vetter > > > Cc: Christian K=C3=B6nig > > > Cc: Matthew Auld > > > Cc: Maarten Lankhorst > > > --- > > > drivers/dma-buf/dma-fence-chain.c | 8 ++-- > > > drivers/dma-buf/dma-resv.c | 4 +- > > > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- > > > drivers/gpu/drm/i915/i915_active.h | 4 +- > > > drivers/gpu/drm/i915/i915_vma.c | 4 +- > > > include/drm/drm_syncobj.h | 4 +- > > > include/linux/dma-fence.h | 50 --------------------= --- > > > include/linux/dma-resv.h | 4 +- > > > 8 files changed, 23 insertions(+), 59 deletions(-) > > > > > > diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-= fence-chain.c > > > index 7d129e68ac701..46dfc7d94d8ed 100644 > > > --- a/drivers/dma-buf/dma-fence-chain.c > > > +++ b/drivers/dma-buf/dma-fence-chain.c > > > @@ -15,15 +15,17 @@ static bool dma_fence_chain_enable_signaling(stru= ct dma_fence *fence); > > > * dma_fence_chain_get_prev - use RCU to get a reference to the pre= vious fence > > > * @chain: chain node to get the previous node from > > > * > > > - * Use dma_fence_get_rcu_safe to get a reference to the previous fen= ce of the > > > - * chain node. > > > + * Use rcu_dereference and dma_fence_get_rcu to get a reference to t= he > > > + * previous fence of the chain node. > > > */ > > > static struct dma_fence *dma_fence_chain_get_prev(struct dma_fence_= chain *chain) > > > { > > > struct dma_fence *prev; > > > > > > rcu_read_lock(); > > > - prev =3D dma_fence_get_rcu_safe(&chain->prev); > > > + prev =3D rcu_dereference(chain->prev); > > > + if (prev) > > > + prev =3D dma_fence_get_rcu(prev); > > > rcu_read_unlock(); > > > return prev; > > > } > > > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c > > > index f26c71747d43a..cfe0db3cca292 100644 > > > --- a/drivers/dma-buf/dma-resv.c > > > +++ b/drivers/dma-buf/dma-resv.c > > > @@ -376,7 +376,9 @@ int dma_resv_copy_fences(struct dma_resv *dst, st= ruct dma_resv *src) > > > dst_list =3D NULL; > > > } > > > > > > - new =3D dma_fence_get_rcu_safe(&src->fence_excl); > > > + new =3D rcu_dereference(src->fence_excl); > > > + if (new) > > > + new =3D dma_fence_get_rcu(new); > > > rcu_read_unlock(); > > > > > > src_list =3D dma_resv_shared_list(dst); > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/= drm/amd/amdgpu/amdgpu_fence.c > > > index 72d9b92b17547..0aeb6117f3893 100644 > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > > > @@ -161,7 +161,9 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, s= truct dma_fence **f, > > > struct dma_fence *old; > > > > > > rcu_read_lock(); > > > - old =3D dma_fence_get_rcu_safe(ptr); > > > + old =3D rcu_dereference(*ptr); > > > + if (old) > > > + old =3D dma_fence_get_rcu(old); > > > rcu_read_unlock(); > > > > > > if (old) { > > > diff --git a/drivers/gpu/drm/i915/i915_active.h b/drivers/gpu/drm/i91= 5/i915_active.h > > > index d0feda68b874f..bd89cfc806ca5 100644 > > > --- a/drivers/gpu/drm/i915/i915_active.h > > > +++ b/drivers/gpu/drm/i915/i915_active.h > > > @@ -103,7 +103,9 @@ i915_active_fence_get(struct i915_active_fence *a= ctive) > > > struct dma_fence *fence; > > > > > > rcu_read_lock(); > > > - fence =3D dma_fence_get_rcu_safe(&active->fence); > > > + fence =3D rcu_dereference(active->fence); > > > + if (fence) > > > + fence =3D dma_fence_get_rcu(fence); > > > rcu_read_unlock(); > > > > > > return fence; > > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i= 915_vma.c > > > index 0f227f28b2802..ed0388d99197e 100644 > > > --- a/drivers/gpu/drm/i915/i915_vma.c > > > +++ b/drivers/gpu/drm/i915/i915_vma.c > > > @@ -351,7 +351,9 @@ int i915_vma_wait_for_bind(struct i915_vma *vma) > > > struct dma_fence *fence; > > > > > > rcu_read_lock(); > > > - fence =3D dma_fence_get_rcu_safe(&vma->active.excl.fenc= e); > > > + fence =3D rcu_dereference(vma->active.excl.fence); > > > + if (fence) > > > + fence =3D dma_fence_get_rcu(fence); > > > rcu_read_unlock(); > > > if (fence) { > > > err =3D dma_fence_wait(fence, MAX_SCHEDULE_TIME= OUT); > > > diff --git a/include/drm/drm_syncobj.h b/include/drm/drm_syncobj.h > > > index 6cf7243a1dc5e..6c45d52988bcc 100644 > > > --- a/include/drm/drm_syncobj.h > > > +++ b/include/drm/drm_syncobj.h > > > @@ -105,7 +105,9 @@ drm_syncobj_fence_get(struct drm_syncobj *syncobj= ) > > > struct dma_fence *fence; > > > > > > rcu_read_lock(); > > > - fence =3D dma_fence_get_rcu_safe(&syncobj->fence); > > > + fence =3D rcu_dereference(syncobj->fence); > > > + if (fence) > > > + fence =3D dma_fence_get_rcu(syncobj->fence); > > > rcu_read_unlock(); > > > > > > return fence; > > > diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h > > > index 6ffb4b2c63715..f4a2ab2b1ae46 100644 > > > --- a/include/linux/dma-fence.h > > > +++ b/include/linux/dma-fence.h > > > @@ -307,56 +307,6 @@ static inline struct dma_fence *dma_fence_get_rc= u(struct dma_fence *fence) > > > return NULL; > > > } > > > > > > -/** > > > - * dma_fence_get_rcu_safe - acquire a reference to an RCU tracked f= ence > > > - * @fencep: pointer to fence to increase refcount of > > > - * > > > - * Function returns NULL if no refcount could be obtained, or the fe= nce. > > > - * This function handles acquiring a reference to a fence that may b= e > > > - * reallocated within the RCU grace period (such as with SLAB_TYPESA= FE_BY_RCU), > > > - * so long as the caller is using RCU on the pointer to the fence. > > > - * > > > - * An alternative mechanism is to employ a seqlock to protect a bunc= h of > > > - * fences, such as used by struct dma_resv. When using a seqlock, > > > - * the seqlock must be taken before and checked after a reference to= the > > > - * fence is acquired (as shown here). > > > - * > > > - * The caller is required to hold the RCU read lock. > > > - */ > > > -static inline struct dma_fence * > > > -dma_fence_get_rcu_safe(struct dma_fence __rcu **fencep) > > > -{ > > > - do { > > > - struct dma_fence *fence; > > > - > > > - fence =3D rcu_dereference(*fencep); > > > - if (!fence) > > > - return NULL; > > > - > > > - if (!dma_fence_get_rcu(fence)) > > > - continue; > > > - > > > - /* The atomic_inc_not_zero() inside dma_fence_get_rcu() > > > - * provides a full memory barrier upon success (such as= now). > > > - * This is paired with the write barrier from assigning > > > - * to the __rcu protected fence pointer so that if that > > > - * pointer still matches the current fence, we know we > > > - * have successfully acquire a reference to it. If it n= o > > > - * longer matches, we are holding a reference to some o= ther > > > - * reallocated pointer. This is possible if the allocat= or > > > - * is using a freelist like SLAB_TYPESAFE_BY_RCU where = the > > > - * fence remains valid for the RCU grace period, but it > > > - * may be reallocated. When using such allocators, we a= re > > > - * responsible for ensuring the reference we get is to > > > - * the right fence, as below. > > > - */ > > > - if (fence =3D=3D rcu_access_pointer(*fencep)) > > > - return rcu_pointer_handoff(fence); > > > - > > > - dma_fence_put(fence); > > > - } while (1); > > > -} > > > - > > > #ifdef CONFIG_LOCKDEP > > > bool dma_fence_begin_signalling(void); > > > void dma_fence_end_signalling(bool cookie); > > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > > > index 562b885cf9c3d..a38c021f379af 100644 > > > --- a/include/linux/dma-resv.h > > > +++ b/include/linux/dma-resv.h > > > @@ -248,7 +248,9 @@ dma_resv_get_excl_unlocked(struct dma_resv *obj) > > > return NULL; > > > > > > rcu_read_lock(); > > > - fence =3D dma_fence_get_rcu_safe(&obj->fence_excl); > > > + fence =3D rcu_dereference(obj->fence_excl); > > > + if (fence) > > > + fence =3D dma_fence_get_rcu(fence); > > > rcu_read_unlock(); > > > > > > return fence; > > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch