From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 363C0C47080 for ; Tue, 1 Jun 2021 07:28:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A40EC60FEB for ; Tue, 1 Jun 2021 07:28:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A40EC60FEB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51C3A6E243; Tue, 1 Jun 2021 07:28:34 +0000 (UTC) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 174066E2B4 for ; Tue, 1 Jun 2021 07:28:33 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id j75so14586870oih.10 for ; Tue, 01 Jun 2021 00:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7YWxZ4LYPadaEaLleuE6m94kneRRJG7Efk68kZp5Wpg=; b=JOavtG1PeB2XpJQM7EqfiqZBnFczKs7ZMLjCzGuXWiP4G73KYOxA5pnuBuBHxMRzk2 eMkGgPvdwbwCK2oywXXElt87UMKnXRclo9pQRykfSUpqTzU5AjfnZ2xb0sZ5ieeisnWm MaNLy+Jjqd67rbHTh2yHMMvWDXBN/AAsLoaF4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7YWxZ4LYPadaEaLleuE6m94kneRRJG7Efk68kZp5Wpg=; b=Q7RrQO40E0ysDHjp28qys0J13bXpeBGdAlkZ6hW27hzPLXJCJYb8WNYczH1fa+xtqv geJYXXUaNu3r29hdmDtTB3gx4Juff7EUPnQve10Orx1+okDHIyeoClgjc/3NeLsdR7FN jfIfDBGZzo55ifRoFEn+lhipi/iAxaa3kqudHs+BrLvY7WO1ZfHjJB2LQaDDQy25OrHR 2eOuRNyb+KJCoLgpB4zPfnN/E67eqCdFYezumdR4QY5wcVm36sl8TKWvGF1KfHPis8sz BrO/nZbvig4ToodrU7Nw6J7iC3B2sQWnFvYrPJ5CsBt5PXHTCu5g8Fj3UwiFUGGhVPIu zBXQ== X-Gm-Message-State: AOAM530uWhhqZzeSi8rBREA1amDTWTLlTRNd3JDAyhEtcnlW2dlGxb/6 oCb965GA5HEV7GZ1W06a01jriMjGaZBnwFtSB9qJUg== X-Google-Smtp-Source: ABdhPJxnqsP3l7lVMLKZMPPIb17LjqzUQ/8nUsAihHsoC77yCwzqB1NVHuNnS1wDlUEVeIkUMyUMZd+YQhkN8HUjqtM= X-Received: by 2002:a05:6808:1142:: with SMTP id u2mr2072784oiu.101.1622532512233; Tue, 01 Jun 2021 00:28:32 -0700 (PDT) MIME-Version: 1.0 References: <20210511083139.54002-1-zbigniew.kempczynski@intel.com> In-Reply-To: From: Daniel Vetter Date: Tue, 1 Jun 2021 09:28:21 +0200 Message-ID: To: Dave Airlie Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Intel Graphics Development , dri-devel , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCBKdW4gMSwgMjAyMSBhdCA5OjE5IEFNIERhdmUgQWlybGllIDxhaXJsaWVkQGdtYWls LmNvbT4gd3JvdGU6Cj4gT24gVGh1LCAyNyBNYXkgMjAyMSBhdCAyMDowNCwgRGFuaWVsIFZldHRl ciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+IE9uIFdlZCwgTWF5IDI2LCAyMDIxIGF0IDEw OjM1OjQ5QU0gKzEwMDAsIERhdmUgQWlybGllIHdyb3RlOgo+ID4gPiBPbiBXZWQsIDEyIE1heSAy MDIxIGF0IDAzOjA1LCBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4g PiA+IE9uIFR1ZSwgTWF5IDExLCAyMDIxIGF0IDEwOjMxOjM5QU0gKzAyMDAsIFpiaWduaWV3IEtl bXBjennFhHNraSB3cm90ZToKPiA+ID4gPiA+IFdlIGhhdmUgZXN0YWJsaXNoZWQgcHJldmlvdXNs eSB3ZSBzdG9wIHVzaW5nIHJlbG9jYXRpb25zIHN0YXJ0aW5nCj4gPiA+ID4gPiBmcm9tIGdlbjEy IHBsYXRmb3JtcyB3aXRoIFRpZ2VybGFrZSBhcyBhbiBleGNlcHRpb24uIFVuZm9ydHVuYXRlbHkK PiA+ID4gPiA+IHdlIG5lZWQgZXh0ZW5kIHRyYW5zaXRpb24gcGVyaW9kIGFuZCBzdXBwb3J0IHJl bG9jYXRpb25zIGZvciB0d28KPiA+ID4gPiA+IG90aGVyIGlnZnggcGxhdGZvcm1zIC0gUm9ja2V0 bGFrZSBhbmQgQWxkZXJsYWtlLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFpi aWduaWV3IEtlbXBjennFhHNraSA8emJpZ25pZXcua2VtcGN6eW5za2lAaW50ZWwuY29tPgo+ID4g PiA+ID4gQ2M6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gPiA+ID4gPiBDYzog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiA+ID4gPiBDYzogSmFz b24gRWtzdHJhbmQgPGphc29uQGpsZWtzdHJhbmQubmV0Pgo+ID4gPiA+Cj4gPiA+ID4gU28gdGhl IGFubm95aW5nIHRoaW5nIGhlcmUgaXMgdGhhdCBub3cgbWVkaWEtZHJpdmVyIGlzIGZpeGVkOgo+ ID4gPiA+Cj4gPiA+ID4gaHR0cHM6Ly9naXRodWIuY29tL2ludGVsL21lZGlhLWRyaXZlci9jb21t aXQvMTQ0MDIwYzM3NzcwMDgzOTc0YmVkZjU5OTAyYjcwYjhmNDQ0Yzc5OQo+ID4gPiA+Cj4gPiA+ ID4gV2hpY2ggbWVhbnMgaWd0IGlzIHJlYWxseSB0aGUgb25seSB0aGluZyBsZWZ0Lgo+ID4gPiA+ Cj4gPiA+ID4gRGF2ZSwgaXMgdGhpcyBzdGlsbCBvayBmb3IgYW4gYWNrZWQgZXhjZXB0aW9uLCBv ciBpcyB0aGlzIG5vdyBsZWFuaW5nCj4gPiA+ID4gdG93YXJkcyAianVzdCBmaXggaWd0Ij8KPiA+ ID4KPiA+ID4gT2ggdGhhdCBpc24ndCBncmVhdCBpcyBpdCwgSSBoYWQgdGhvdWdodCBpdCB3YXMg dGhlIG1lZGlhLWRyaXZlciwKPiA+ID4ga2VlcGluZyBhIGJpZyB1QVBJIGxpa2UgdGhpcyBvcGVu IGp1c3QgZm9yIHRoZSB0ZXN0IGNvZGUgc2VlbXMgYSBiaXQKPiA+ID4gc2lsbHkuIEkgZ2V0IHRo ZSB0ZXN0cyBhcmUgdGVzdGluZyBtb3JlIHRoYW4ganVzdCByZWxvY3MsIGJ1dCBpdCdzIGEKPiA+ ID4gcHJldHR5IGJpZyBpbnRlcmZhY2UgdG8gbGVhdmUgbHlpbmcgYXJvdW5kIGlmIHdlIGNhbiBh dm9pZCBpdC4KPiA+Cj4gPiBTbyBzaW5jZSB3ZSBuZWVkIHRvIGRvIHRoZSB3b3JrIGFueXdheSBm b3IgREcxKyB3aGF0IGFib3V0IHNvbWUgaW50ZXJpbQo+ID4gaGFjaz8gQ3VycmVudGx5IEFETCBz dGlsbCBoYXMgdGhlIHJlcXVpcmVfZm9yY2VfcHJvYmUgZmxhZyBzZXQuIFdlIGNvdWxkCj4gPiBy ZS1lbmFibGUgcmVsb2NhdGlvbnMganVzdCBmb3IgQURMLCBvbmx5IHdoaWxlIHRoaXMgZmxhZyBp cyBzZXQuIFRoaXMKPiA+IGdpdmVzIHVzIGEgYnVuY2ggb2Ygd2lnZ2xlIHJvb20sIHVuYmxvY2tz IGV2ZXJ5dGhpbmcgZWxzZSAoQ0kgaXMgYSBiaXQgb24KPiA+IGZpcmUgcmlnaHQgbm93IGR1ZSB0 byB0aGlzIGFuZCBwcmFjdGlhbGx5IHVudXNlYWJsZSBvbiBBREwgZ2VtIGFyZWF5KSBhbmQKPiA+ IHdlJ2xsIHN0aWxsIG1ha2Ugc3VyZSB0aGF0IHdoZW4gQURMIGlzIGFsbCBkb25lIHdlIHdvbnQg ZXhwb3NlIHJlbG9jYXRpb25zCj4gPiBqdXN0IGZvciBpZ3QuCj4gPgo+ID4gVGhvdWdodHM/Cj4K PiBJIGNhbiBoYW5kbGUgdGhhdCBhcyBhIGNvbXByb21pc2UsIHRob3VnaCBJJ2Qgbm90IHdhbnQg dG8gYmxvY2sgQURMCj4gZ2V0dGluZyBvdXQgb2YgYWxwaGEgb3ZlciBzb21lIElHVCB0aGF0IG5l ZWRzIHBvcnRpbmcuCgpVaCBnaXZlbiB0aGF0IEVITC9KU0wgYXJlIHN0aWxsIGluIHJlcXVpcmVf Zm9yY2VfcHJvYmUgPSB0cnVlIG1vZGUKYmVjYXVzZSBvZiBhIHJhbmRvbSBpZ3QgKGFuZCBzaGlw cGluZyBzaW5jZSBhIHdoaWxlKSAuLi4gSSBndWVzcyB3b3JzdApjYXNlIGlmIGl0J3Mgbm90IHNv cnRlZCBpbiBhIGZldyBtb250aHMgbGF0ZXN0IHdlIGNhbiB1bmRvIHRoYXQgYWdhaW4uCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4B0C47092 for ; Tue, 1 Jun 2021 07:28:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9162D6139A for ; Tue, 1 Jun 2021 07:28:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9162D6139A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C17E76E841; Tue, 1 Jun 2021 07:28:34 +0000 (UTC) Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1470F6E243 for ; Tue, 1 Jun 2021 07:28:33 +0000 (UTC) Received: by mail-oi1-x22b.google.com with SMTP id v22so14619019oic.2 for ; Tue, 01 Jun 2021 00:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7YWxZ4LYPadaEaLleuE6m94kneRRJG7Efk68kZp5Wpg=; b=JOavtG1PeB2XpJQM7EqfiqZBnFczKs7ZMLjCzGuXWiP4G73KYOxA5pnuBuBHxMRzk2 eMkGgPvdwbwCK2oywXXElt87UMKnXRclo9pQRykfSUpqTzU5AjfnZ2xb0sZ5ieeisnWm MaNLy+Jjqd67rbHTh2yHMMvWDXBN/AAsLoaF4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7YWxZ4LYPadaEaLleuE6m94kneRRJG7Efk68kZp5Wpg=; b=YJs7J+v+DCysg3Ypju77M4NO3TY1RV84EFXMBFe9eUd9Fr3nlIQEoJTpUf9esFvb4Z gB4xfp5nvx4JHFcmhWSq+T2tFbzGrrt5jurNNCDh3OkDJ0K9i4kWVgVfWTIp6AgOKTtC rGX7Tmfi9qgXkzl0En5h3Yn45ey7PLVH5ZKzwkxFCciU+bXWbFhOvLyXT9iEKc3b/z25 3EWJJ4FtLdXgaVlHTG5Jel9kwJIY8NkpamMuzPiNSWOFpyoacxuS+PlBDnQTLICFNbyq XEV4PSceP5dHRnNGmLdFiLFMVskolIiVnXrca0m4M7mB8Ke/l7EFPuPAi6W4RJ4ePMQx 0B3w== X-Gm-Message-State: AOAM530Z4RrNMZ46aWCmFs+4KEGeliWPUXJdrEIn5LSni0B8oPKciFUX ZeizpakEhUGhGmgQrKhwYD7VnbbYnJQ/MwpERhCCeQ== X-Google-Smtp-Source: ABdhPJxnqsP3l7lVMLKZMPPIb17LjqzUQ/8nUsAihHsoC77yCwzqB1NVHuNnS1wDlUEVeIkUMyUMZd+YQhkN8HUjqtM= X-Received: by 2002:a05:6808:1142:: with SMTP id u2mr2072784oiu.101.1622532512233; Tue, 01 Jun 2021 00:28:32 -0700 (PDT) MIME-Version: 1.0 References: <20210511083139.54002-1-zbigniew.kempczynski@intel.com> In-Reply-To: From: Daniel Vetter Date: Tue, 1 Jun 2021 09:28:21 +0200 Message-ID: Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms To: Dave Airlie Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , =?UTF-8?Q?Zbigniew_Kempczy=C5=84ski?= , Intel Graphics Development , dri-devel , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 1, 2021 at 9:19 AM Dave Airlie wrote: > On Thu, 27 May 2021 at 20:04, Daniel Vetter wrote: > > On Wed, May 26, 2021 at 10:35:49AM +1000, Dave Airlie wrote: > > > On Wed, 12 May 2021 at 03:05, Daniel Vetter wrote: > > > > On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczy=C5=84ski= wrote: > > > > > We have established previously we stop using relocations starting > > > > > from gen12 platforms with Tigerlake as an exception. Unfortunatel= y > > > > > we need extend transition period and support relocations for two > > > > > other igfx platforms - Rocketlake and Alderlake. > > > > > > > > > > Signed-off-by: Zbigniew Kempczy=C5=84ski > > > > > Cc: Dave Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: Jason Ekstrand > > > > > > > > So the annoying thing here is that now media-driver is fixed: > > > > > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf= 59902b70b8f444c799 > > > > > > > > Which means igt is really the only thing left. > > > > > > > > Dave, is this still ok for an acked exception, or is this now leani= ng > > > > towards "just fix igt"? > > > > > > Oh that isn't great is it, I had thought it was the media-driver, > > > keeping a big uAPI like this open just for the test code seems a bit > > > silly. I get the tests are testing more than just relocs, but it's a > > > pretty big interface to leave lying around if we can avoid it. > > > > So since we need to do the work anyway for DG1+ what about some interim > > hack? Currently ADL still has the require_force_probe flag set. We coul= d > > re-enable relocations just for ADL, only while this flag is set. This > > gives us a bunch of wiggle room, unblocks everything else (CI is a bit = on > > fire right now due to this and practially unuseable on ADL gem areay) a= nd > > we'll still make sure that when ADL is all done we wont expose relocati= ons > > just for igt. > > > > Thoughts? > > I can handle that as a compromise, though I'd not want to block ADL > getting out of alpha over some IGT that needs porting. Uh given that EHL/JSL are still in require_force_probe =3D true mode because of a random igt (and shipping since a while) ... I guess worst case if it's not sorted in a few months latest we can undo that again. -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch