From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6500FC2B9F4 for ; Tue, 22 Jun 2021 19:29:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E4F36128E for ; Tue, 22 Jun 2021 19:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbhFVTb2 (ORCPT ); Tue, 22 Jun 2021 15:31:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:52690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbhFVTb1 (ORCPT ); Tue, 22 Jun 2021 15:31:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB31961353 for ; Tue, 22 Jun 2021 19:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624390151; bh=OkCFHf6y3PDoewX0r/FcG3EK3e4OSyfGXYGp4VKggyk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uAlMLrhRGL74EOppuq20LfVjJA9s1BcaWynedauIqg+fPgtsx6ydb8orBPZTrUU0t v7XAQnEh58bDhqPUHhQqo8p9Oje3poNQcnO+N9MTd4QZPLp2ADIA1Rp6TM7nw7i+NF 13W9OYP+qH/Y/2HShIgKIPDvr7yF7paMQ/Dqvcny0mTU0s0s0SdIPpZhSVYb7E80A5 nOOo+lDYyKfsT+kI5zwO5tPSUcCdzytrFat/ibjZaHKIZ8FxCD345D2MBJU39bmxr6 9XCj92RExHu7yteRaSh2F35ItinDpeh9xvh0aGrWiPa3iWNDW/2TNEVFi6lvbhxwao npg4icoHGP3bw== Received: by mail-wr1-f54.google.com with SMTP id j2so14411575wrs.12 for ; Tue, 22 Jun 2021 12:29:11 -0700 (PDT) X-Gm-Message-State: AOAM530Yn0Fx3tbEZOaTQK4k1Alrve6FuuXdjWh2H5a1O4w9kexZfCmk XP+DzFsM0zFbi7FmNgdeBynI1XQHYDtgSL6t2ks= X-Google-Smtp-Source: ABdhPJyz1uD8VkBt/jj7W7KEcTNtEDXjXj9bjFWf/UJB9DT4rLZp68IWdOWtqoeZVbp+JCwLILM1OebQhL4jJbfMz/w= X-Received: by 2002:a5d:5650:: with SMTP id j16mr6819503wrw.99.1624390150286; Tue, 22 Jun 2021 12:29:10 -0700 (PDT) MIME-Version: 1.0 References: <60B24AC2.9050505@gmail.com> <60B36A9A.4010806@gmail.com> <60B3CAF8.90902@gmail.com> <60B41D00.8050801@gmail.com> <60B514A0.1020701@gmail.com> <60B560A8.8000800@gmail.com> <49f40dd8-da68-f579-b359-7a7e229565e1@gmail.com> <60B611C6.2000801@gmail.com> <60B65BBB.2040507@gmail.com> <877dipgyrb.ffs@nanos.tec.linutronix.de> <60D1DAC1.9060200@gmail.com> <60D22F1D.1000205@gmail.com> In-Reply-To: <60D22F1D.1000205@gmail.com> From: Arnd Bergmann Date: Tue, 22 Jun 2021 21:26:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Realtek 8139 problem on 486. To: Nikolai Zhubr Cc: "Maciej W. Rozycki" , Thomas Gleixner , Heiner Kallweit , netdev , "the arch/x86 maintainers" , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 22, 2021 at 8:32 PM Nikolai Zhubr wrote: > 22.06.2021 16:22, Arnd Bergmann: > irq 8: 02, edge > irq 9: 02, level > irq 10: 02, edge > irq 11: 02, edge > irq 12: 02, edge > irq 13: 02, edge > irq 14: 02, edge > irq 15: 02, edge > > Now connection also works fine with unmodified 8139too driver. > The percentage of low-level errors stays very small: > > RX packets:13953 errors:1 dropped:2 overruns:1 frame:0 > TX packets:37346 errors:0 dropped:0 overruns:13 carrier:0 Ok, nice! > This fix looks really nice. Maybe it is right thing to do. I'll leave that up to Thomas and Maciej to decide, they should have the best idea of why the x86 pci-irq code looks the way it does today and what the possible risk with my patch is. As I said before, I still think we should also merge the 8139 driver patch, probably without that loop. It's not great, but I'm much more confident I understand what that does and that the patched version is better than the current code. Arnd