From: Arnd Bergmann <arnd@kernel.org>
To: Nikolai Zhubr <zhubr.2@gmail.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: Realtek 8139 problem on 486.
Date: Wed, 2 Jun 2021 17:28:56 +0200 [thread overview]
Message-ID: <CAK8P3a0h4jaTdg9CmjQKNK+YniThmp4JyNbSdNJMEBj4czHGdg@mail.gmail.com> (raw)
In-Reply-To: <60B7A05D.3070704@gmail.com>
On Wed, Jun 2, 2021 at 5:14 PM Nikolai Zhubr <zhubr.2@gmail.com> wrote:
>
> Hi all,
>
> 01.06.2021 20:44, Maciej W. Rozycki:
> [...]
> > You might be able to add a quirk based on your chipset's vendor/device ID
> > though, which would call `elcr_set_level_irq' for interrupt lines claimed
> > by PCI devices. You'd have to match on the southbridge's ID I imagine, if
> > any (ISTR at least one Intel chipset did not have a southbridge visible on
> > PCI), as it's where the 8259A cores along with any ELCR reside.
>
> I'm looking at this comment in arch/x86/kernel/acpi/boot.c:
>
> /*
> * Make sure all (legacy) PCI IRQs are set as level-triggered.
> */
>
> Doesn't it target exactly the case in question? If so, why it does not
> actually work?
>
> By legacy they likely mean non-ACPI IRQs, so for 486 it's just all of
> them.
I think this means non-MSI interrupts
> So I'd suppose, if the kernel readily knows a particular IRQ is
> assigned to PCI bus (I'm almost sure it does) shouldn't it already take
> care of proper triggering mode automatically? Because then there would
> be no need to add workarounds to individual drivers.
Without ACPI, this code is never called, instead of acpi_pci_irq_enable(),
you use pirq_enable_irq()/pcibios_lookup_irq(). There are already
some hardware specific quirks in there, it's possible this could be
changed to address your case as well, but it already looks a bit fragile.
Arnd
next prev parent reply other threads:[~2021-06-02 15:30 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 14:08 Realtek 8139 problem on 486 Nikolai Zhubr
2021-05-29 18:42 ` Heiner Kallweit
2021-05-29 21:44 ` tedheadster
2021-05-30 0:49 ` Nikolai Zhubr
2021-05-30 10:36 ` Nikolai Zhubr
2021-05-30 17:27 ` Nikolai Zhubr
2021-05-30 20:54 ` Arnd Bergmann
2021-05-30 23:17 ` Nikolai Zhubr
2021-05-31 16:53 ` Nikolai Zhubr
2021-05-31 18:39 ` Arnd Bergmann
2021-05-31 22:18 ` Nikolai Zhubr
2021-05-31 22:30 ` Heiner Kallweit
2021-06-01 7:20 ` Arnd Bergmann
2021-06-01 10:53 ` Nikolai Zhubr
2021-06-01 11:42 ` Heiner Kallweit
2021-06-01 16:09 ` Nikolai Zhubr
2021-06-01 21:48 ` Heiner Kallweit
2021-06-01 23:37 ` Nikolai Zhubr
2021-06-02 9:12 ` Arnd Bergmann
2021-06-07 23:07 ` Nikolai Zhubr
2021-06-08 7:44 ` Arnd Bergmann
2021-06-08 20:32 ` Nikolai Zhubr
2021-06-08 20:45 ` Arnd Bergmann
2021-06-08 22:07 ` Nikolai Zhubr
2021-06-09 7:09 ` Arnd Bergmann
2021-06-12 17:40 ` Nikolai Zhubr
2021-06-12 22:41 ` Arnd Bergmann
2021-06-13 14:10 ` Nikolai Zhubr
2021-06-13 21:52 ` Arnd Bergmann
2021-06-03 18:32 ` Maciej W. Rozycki
2021-06-04 7:36 ` Arnd Bergmann
2021-06-20 0:34 ` Thomas Gleixner
2021-06-20 10:19 ` Arnd Bergmann
2021-06-21 4:10 ` Maciej W. Rozycki
2021-06-21 11:22 ` Arnd Bergmann
2021-06-21 14:42 ` Maciej W. Rozycki
2021-06-21 15:20 ` Arnd Bergmann
2021-06-22 11:12 ` David Laight
2021-06-22 12:42 ` Nikolai Zhubr
2021-06-22 13:22 ` Arnd Bergmann
2021-06-22 18:42 ` Nikolai Zhubr
2021-06-22 19:26 ` Arnd Bergmann
2021-06-23 1:04 ` Maciej W. Rozycki
2021-06-24 17:56 ` Nikolai Zhubr
2021-06-24 18:25 ` Maciej W. Rozycki
2021-07-14 23:32 ` Maciej W. Rozycki
2021-07-15 7:32 ` Nikolai Zhubr
2021-07-16 23:48 ` Maciej W. Rozycki
2021-06-23 16:31 ` Nikolai Zhubr
2021-06-23 23:39 ` Maciej W. Rozycki
2021-06-24 8:28 ` Arnd Bergmann
2021-07-02 19:02 ` Nikolai Zhubr
2021-07-03 9:10 ` Arnd Bergmann
2021-07-08 19:21 ` Nikolai Zhubr
2021-07-09 7:31 ` Arnd Bergmann
2021-07-09 12:43 ` David Laight
2021-06-01 17:44 ` Maciej W. Rozycki
2021-06-02 15:14 ` Nikolai Zhubr
2021-06-02 15:28 ` Arnd Bergmann [this message]
2021-05-31 19:05 ` Heiner Kallweit
2021-05-31 18:29 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0h4jaTdg9CmjQKNK+YniThmp4JyNbSdNJMEBj4czHGdg@mail.gmail.com \
--to=arnd@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
--cc=zhubr.2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.