From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Thu, 28 Sep 2017 15:11:05 +0900 Subject: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err() In-Reply-To: <1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com> References: <1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com> <1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, 2017-09-16 14:10 GMT+09:00 Masahiro Yamada : > U-Boot widely uses error() as a bit noisier variant of printf(). > > This macro causes name conflict with the following line in > include/linux/compiler-gcc.h: > > # define __compiletime_error(message) __attribute__((error(message))) > > This prevents us from using __compiletime_error(), and makes it > difficult to fully sync BUILD_BUG macros with Linux. (Notice > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().) > > Let's convert error() into now treewide-available pr_err(). > > Done with the help of Coccinelle, excluing tools/ directory. > > The semantic patch I used is as follows: > > // > @@@@ > -error > +pr_err > (...) > // > Apparently, this is outdated already. Do you want me to update this? or will you run coccinelle by yourself? -- Best Regards Masahiro Yamada