From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Thu, 5 Oct 2017 12:20:36 +0900 Subject: [U-Boot] [PATCH v2 0/8] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc. In-Reply-To: <20171005030636.GE13661@bill-the-cat> References: <1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com> <20171005030636.GE13661@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, 2017-10-05 12:06 GMT+09:00 Tom Rini : > On Wed, Oct 04, 2017 at 02:15:19PM +0900, Masahiro Yamada wrote: >> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada : >> > >> > I tested this series with buildman. >> > >> > >> > >> > Masahiro Yamada (8): >> > stdio.h: move printf() stuff from to >> > printk: collect printk stuff into with loglevel >> > support >> > treewide: replace with error() with pr_err() >> > common.h: remove error() >> > vsprintf.h: include >> > bug.h: sync BUILD_BUG stuff with Linux 4.13 >> > bug.h: move runtime BUG/WARN macros into >> > dm: define dev_*() log functions in DM header >> >> I am still worried if this series is dismissed. >> >> I am being blocked from importing NAND code from Linux >> due to missing/incompatible Linux-derived macros. > > I am looking at this, but a default LOGLEVEL of 5 is just too high and > I'm seeing what's reasonable now. > No. I set the default to 6, not 5. The reason why I chose 6 was to suppress a bunch of pr_info() from drivers/mtd/nand/, which is a copy of Linux. If you change it to a bigger number, some annoying logs would be displayed after NAND: tag. If you change it to a smaller number, pr_notice() would be suppressed. The Linux doc says: 5 (KERN_NOTICE) normal but significant condition So, I think this is worth printing by default. If you do not like it, you can change it, but please make sure to adjust git-log. -- Best Regards Masahiro Yamada