* [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting
@ 2024-02-10 15:20 Thorsten Blum
2024-02-10 18:02 ` Randy Dunlap
2024-02-14 21:51 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-02-10 15:20 UTC (permalink / raw
To: Jonathan Corbet
Cc: Masahiro Yamada, Nathan Chancellor, Nicolas Schier, linux-kbuild,
linux-doc, linux-kernel, Thorsten Blum
- Remove unnecessary spaces
- Fix grammar s/to solution/solution/
- Remove newline to be consistent with other headings
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
Documentation/kbuild/Kconfig.recursion-issue-01 | 6 +++---
Documentation/kbuild/kconfig.rst | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/kbuild/Kconfig.recursion-issue-01 b/Documentation/kbuild/Kconfig.recursion-issue-01
index e8877db0461f..ac49836d8ecf 100644
--- a/Documentation/kbuild/Kconfig.recursion-issue-01
+++ b/Documentation/kbuild/Kconfig.recursion-issue-01
@@ -16,13 +16,13 @@
# that are possible for CORE. So for example if CORE_BELL_A_ADVANCED is 'y',
# CORE must be 'y' too.
#
-# * What influences CORE_BELL_A_ADVANCED ?
+# * What influences CORE_BELL_A_ADVANCED?
#
# As the name implies CORE_BELL_A_ADVANCED is an advanced feature of
# CORE_BELL_A so naturally it depends on CORE_BELL_A. So if CORE_BELL_A is 'y'
# we know CORE_BELL_A_ADVANCED can be 'y' too.
#
-# * What influences CORE_BELL_A ?
+# * What influences CORE_BELL_A?
#
# CORE_BELL_A depends on CORE, so CORE influences CORE_BELL_A.
#
@@ -34,7 +34,7 @@
# the "recursive dependency detected" error.
#
# Reading the Documentation/kbuild/Kconfig.recursion-issue-01 file it may be
-# obvious that an easy to solution to this problem should just be the removal
+# obvious that an easy solution to this problem should just be the removal
# of the "select CORE" from CORE_BELL_A_ADVANCED as that is implicit already
# since CORE_BELL_A depends on CORE. Recursive dependency issues are not always
# so trivial to resolve, we provide another example below of practical
diff --git a/Documentation/kbuild/kconfig.rst b/Documentation/kbuild/kconfig.rst
index c946eb44bd13..766f9cb518df 100644
--- a/Documentation/kbuild/kconfig.rst
+++ b/Documentation/kbuild/kconfig.rst
@@ -45,7 +45,6 @@ file name to override the default name of ".config".
KCONFIG_DEFCONFIG_LIST
----------------------
-
This environment variable specifies a list of config files which can be used
as a base configuration in case the .config does not exist yet. Entries in
the list are separated with whitespaces to each other, and the first one
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting
2024-02-10 15:20 [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting Thorsten Blum
@ 2024-02-10 18:02 ` Randy Dunlap
2024-02-14 21:51 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-02-10 18:02 UTC (permalink / raw
To: Thorsten Blum, Jonathan Corbet
Cc: Masahiro Yamada, Nathan Chancellor, Nicolas Schier, linux-kbuild,
linux-doc, linux-kernel
On 2/10/24 07:20, Thorsten Blum wrote:
> - Remove unnecessary spaces
> - Fix grammar s/to solution/solution/
> - Remove newline to be consistent with other headings
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Documentation/kbuild/Kconfig.recursion-issue-01 | 6 +++---
> Documentation/kbuild/kconfig.rst | 1 -
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting
2024-02-10 15:20 [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting Thorsten Blum
2024-02-10 18:02 ` Randy Dunlap
@ 2024-02-14 21:51 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2024-02-14 21:51 UTC (permalink / raw
To: Thorsten Blum
Cc: Jonathan Corbet, Nathan Chancellor, Nicolas Schier, linux-kbuild,
linux-doc, linux-kernel
On Sun, Feb 11, 2024 at 12:26 AM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> - Remove unnecessary spaces
> - Fix grammar s/to solution/solution/
> - Remove newline to be consistent with other headings
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> Documentation/kbuild/Kconfig.recursion-issue-01 | 6 +++---
> Documentation/kbuild/kconfig.rst | 1 -
I dropped the change for Documentation/kbuild/kconfig.rst
because it was already reformatted by a previous patch.
https://lore.kernel.org/linux-kbuild/20240112125830.3753464-1-vegard.nossum@oracle.com/
Applied.
Thanks.
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/kbuild/Kconfig.recursion-issue-01 b/Documentation/kbuild/Kconfig.recursion-issue-01
> index e8877db0461f..ac49836d8ecf 100644
> --- a/Documentation/kbuild/Kconfig.recursion-issue-01
> +++ b/Documentation/kbuild/Kconfig.recursion-issue-01
> @@ -16,13 +16,13 @@
> # that are possible for CORE. So for example if CORE_BELL_A_ADVANCED is 'y',
> # CORE must be 'y' too.
> #
> -# * What influences CORE_BELL_A_ADVANCED ?
> +# * What influences CORE_BELL_A_ADVANCED?
> #
> # As the name implies CORE_BELL_A_ADVANCED is an advanced feature of
> # CORE_BELL_A so naturally it depends on CORE_BELL_A. So if CORE_BELL_A is 'y'
> # we know CORE_BELL_A_ADVANCED can be 'y' too.
> #
> -# * What influences CORE_BELL_A ?
> +# * What influences CORE_BELL_A?
> #
> # CORE_BELL_A depends on CORE, so CORE influences CORE_BELL_A.
> #
> @@ -34,7 +34,7 @@
> # the "recursive dependency detected" error.
> #
> # Reading the Documentation/kbuild/Kconfig.recursion-issue-01 file it may be
> -# obvious that an easy to solution to this problem should just be the removal
> +# obvious that an easy solution to this problem should just be the removal
> # of the "select CORE" from CORE_BELL_A_ADVANCED as that is implicit already
> # since CORE_BELL_A depends on CORE. Recursive dependency issues are not always
> # so trivial to resolve, we provide another example below of practical
> diff --git a/Documentation/kbuild/kconfig.rst b/Documentation/kbuild/kconfig.rst
> index c946eb44bd13..766f9cb518df 100644
> --- a/Documentation/kbuild/kconfig.rst
> +++ b/Documentation/kbuild/kconfig.rst
> @@ -45,7 +45,6 @@ file name to override the default name of ".config".
>
> KCONFIG_DEFCONFIG_LIST
> ----------------------
> -
> This environment variable specifies a list of config files which can be used
> as a base configuration in case the .config does not exist yet. Entries in
> the list are separated with whitespaces to each other, and the first one
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-14 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-10 15:20 [PATCH] docs: kbuild: Kconfig: Fix grammar and formatting Thorsten Blum
2024-02-10 18:02 ` Randy Dunlap
2024-02-14 21:51 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.