* [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors
@ 2016-01-15 19:21 Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
` (9 more replies)
0 siblings, 10 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Hi,
This patchset fixes some build warnings and errors that were introduced by
v4.4-rt2. To build these patches they should be applied on top of patch [1], [2]
and [3].
Cheers,
Anders
[1] https://lkml.org/lkml/2015/12/28/221
[2] https://lkml.org/lkml/2015/12/28/222
[3] http://www.spinics.net/lists/kernel/msg2162906.html
Anders Roxell (9):
drivers/clocksource: timer-atmel-pit: fix irq name
drivers/clocksource: timer-atmel-pit: fix forward declaration
drivers/clocksource: timer-atmel-pit: fix unused var 'ret'
drivers/clocksource: timer-atmel-st: undeclared var 'ret'
drivers/clocksource: timer-atmel-st: fix unused var 'ret'
drivers/clocksource: timer-atmel-st: undeclared var 'irq'
kernel/time: hrtimer: fix forward declaration
drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
driver/gpio: gpio-omap: fix incompatible pointer type
drivers/clocksource/timer-atmel-pit.c | 4 ++--
drivers/clocksource/timer-atmel-st.c | 4 ++--
drivers/cpuidle/coupled.c | 1 -
drivers/gpio/gpio-omap.c | 2 +-
kernel/time/hrtimer.c | 4 ++--
5 files changed, 7 insertions(+), 8 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration Anders Roxell
` (8 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Use the same irq (data->irq) that we used while registering the timer
handle, and not atmel_pit_irq.
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
error without this fix:
../drivers/clocksource/timer-atmel-pit.c: In function
'pit_clkevt_shutdown':
../drivers/clocksource/timer-atmel-pit.c:99:11: error: 'atmel_pit_irq'
undeclared (first use in this function)
free_irq(atmel_pit_irq, data);
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-pit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 80d74c4..2e313e6 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -96,7 +96,7 @@ static int pit_clkevt_shutdown(struct clock_event_device *dev)
/* disable irq, leaving the clocksource active */
pit_write(data->base, AT91_PIT_MR, (data->cycle - 1) | AT91_PIT_PITEN);
- free_irq(atmel_pit_irq, data);
+ free_irq(data->irq, data);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret' Anders Roxell
` (7 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Forward declare function at91sam926x_pit_interrupt before use.
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
error without this fix:
../drivers/clocksource/timer-atmel-pit.c: In function
'pit_clkevt_set_periodic':
../drivers/clocksource/timer-atmel-pit.c:111:31: error:
'at91sam926x_pit_interrupt' undeclared (first use in this function)
ret = request_irq(data->irq, at91sam926x_pit_interrupt,
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-pit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 2e313e6..f87e660 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -100,6 +100,7 @@ static int pit_clkevt_shutdown(struct clock_event_device *dev)
return 0;
}
+static irqreturn_t at91sam926x_pit_interrupt(int irq, void *dev_id);
/*
* Clockevent device: interrupts every 1/HZ (== pit_cycles * MCK/16)
*/
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret'
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
2016-01-15 19:21 ` [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared " Anders Roxell
` (6 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/clocksource/timer-atmel-pit.c: In function
'at91sam926x_pit_common_init':
../drivers/clocksource/timer-atmel-pit.c:193:6: warning: unused variable
'ret' [-Wunused-variable]
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-pit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index f87e660..a7abdb6 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -190,7 +190,6 @@ static void __init at91sam926x_pit_common_init(struct pit_data *data)
{
unsigned long pit_rate;
unsigned bits;
- int ret;
/*
* Use our actual MCK to figure out how many MCK/16 ticks per
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared var 'ret'
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (2 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret' Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused " Anders Roxell
` (5 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used the at91_dt_defconfig and this caused a compilation error without
this fix:
../drivers/clocksource/timer-atmel-st.c: In function
'clkevt32k_set_periodic':
../drivers/clocksource/timer-atmel-st.c:157:2: error: 'ret' undeclared
(first use in this function)
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ea37afc..b6f4aa6 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -150,7 +150,7 @@ static int clkevt32k_set_oneshot(struct clock_event_device *dev)
static int clkevt32k_set_periodic(struct clock_event_device *dev)
{
- int irq;
+ int irq, ret;
clkdev32k_disable_and_flush_irq();
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused var 'ret'
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (3 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared " Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
[not found] ` <CAGt3f4kZAL65+yeNh1qrAbap4SJNwQrSa=5QF0LN9Mh8ew5HSQ@mail.gmail.com>
2016-01-15 19:21 ` [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq' Anders Roxell
` (4 subsequent siblings)
9 siblings, 1 reply; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used the at91_dt_defconfig and this caused a compilation warning without
this fix:
../drivers/clocksource/timer-atmel-st.c:153:6: warning: unused variable
'irq' [-Wunused-variable]
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index b6f4aa6..ea4d8e5 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -150,7 +150,7 @@ static int clkevt32k_set_oneshot(struct clock_event_device *dev)
static int clkevt32k_set_periodic(struct clock_event_device *dev)
{
- int irq, ret;
+ int ret;
clkdev32k_disable_and_flush_irq();
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq'
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (4 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused " Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 7/9] kernel/time: hrtimer: fix forward declaration Anders Roxell
` (3 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used the at91_dt_defconfig and this caused a compilation error without
this fix:
../drivers/clocksource/timer-atmel-st.c: In function
'atmel_st_timer_init':
../drivers/clocksource/timer-atmel-st.c:232:2: error: 'irq' undeclared
(first use in this function)
make[3]: *** [drivers/clocksource/timer-atmel-st.o] Error 1
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/clocksource/timer-atmel-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ea4d8e5..b26735f 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -217,7 +217,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
{
struct clk *sclk;
unsigned int sclk_rate, val;
- int ret;
+ int irq, ret;
regmap_st = syscon_node_to_regmap(node);
if (IS_ERR(regmap_st))
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 7/9] kernel/time: hrtimer: fix forward declaration
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (5 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq' Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
` (2 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Forward declare function hrtimer_wakeup before use.
Used allmodconfig+CONFIG_OF=n and this caused a compilation error
without this fix:
../kernel/time/hrtimer.c: In function '__hrtimer_run_queues':
../kernel/time/hrtimer.c:1464:27: error: 'hrtimer_wakeup' undeclared
(first use in this function)
timer->function == hrtimer_wakeup ?
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
kernel/time/hrtimer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index fdd2b85..138d6f9 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -1436,6 +1436,8 @@ static inline int hrtimer_rt_defer(struct hrtimer *timer) { return 0; }
#endif
+static enum hrtimer_restart hrtimer_wakeup(struct hrtimer *timer);
+
static void __hrtimer_run_queues(struct hrtimer_cpu_base *cpu_base, ktime_t now)
{
struct hrtimer_clock_base *base = cpu_base->clock_base;
@@ -1490,8 +1492,6 @@ static void __hrtimer_run_queues(struct hrtimer_cpu_base *cpu_base, ktime_t now)
raise_softirq_irqoff(HRTIMER_SOFTIRQ);
}
-static enum hrtimer_restart hrtimer_wakeup(struct hrtimer *timer);
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (6 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 7/9] kernel/time: hrtimer: fix forward declaration Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-18 17:02 ` Sebastian Andrzej Siewior
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
2016-01-18 17:54 ` [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Sebastian Andrzej Siewior
9 siblings, 1 reply; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
defined but not used [-Wunused-variable]
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/cpuidle/coupled.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index 344058f..d5657d5 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -119,7 +119,6 @@ struct cpuidle_coupled {
#define CPUIDLE_COUPLED_NOT_IDLE (-1)
-static DEFINE_MUTEX(cpuidle_coupled_lock);
static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (7 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
@ 2016-01-15 19:21 ` Anders Roxell
2016-01-18 14:29 ` Grygorii Strashko
2016-01-18 17:54 ` [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Sebastian Andrzej Siewior
9 siblings, 1 reply; 19+ messages in thread
From: Anders Roxell @ 2016-01-15 19:21 UTC (permalink / raw
To: bigeasy; +Cc: linux-rt-users, khilman, Anders Roxell
Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/gpio/gpio-omap.c: In function 'omap_gpio_runtime_resume':
../drivers/gpio/gpio-omap.c:1398:4: warning: passing argument 1 of
'rt_spin_unlock' from incompatible pointer type [enabled by default]
In file included from ../include/linux/spinlock.h:290:0,
from ../include/linux/seqlock.h:35,
from ../include/linux/time.h:5,
from ../include/linux/stat.h:18,
from ../include/linux/module.h:10,
from ../drivers/gpio/gpio-omap.c:16:
../include/linux/spinlock_rt.h:24:56: note: expected
'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 004888b..f3028e7 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1395,7 +1395,7 @@ static int omap_gpio_runtime_resume(struct device *dev)
if (c != bank->context_loss_count) {
omap_gpio_restore_context(bank);
} else {
- spin_unlock_irqrestore(&bank->lock, flags);
+ raw_spin_unlock_irqrestore(&bank->lock, flags);
return 0;
}
}
--
2.1.4
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
@ 2016-01-18 14:29 ` Grygorii Strashko
2016-01-20 21:29 ` Anders Roxell
0 siblings, 1 reply; 19+ messages in thread
From: Grygorii Strashko @ 2016-01-18 14:29 UTC (permalink / raw
To: Anders Roxell, bigeasy; +Cc: linux-rt-users, khilman
On 01/15/2016 09:21 PM, Anders Roxell wrote:
> Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
> warning without this fix:
> ../drivers/gpio/gpio-omap.c: In function 'omap_gpio_runtime_resume':
> ../drivers/gpio/gpio-omap.c:1398:4: warning: passing argument 1 of
> 'rt_spin_unlock' from incompatible pointer type [enabled by default]
> In file included from ../include/linux/spinlock.h:290:0,
> from ../include/linux/seqlock.h:35,
> from ../include/linux/time.h:5,
> from ../include/linux/stat.h:18,
> from ../include/linux/module.h:10,
> from ../drivers/gpio/gpio-omap.c:16:
> ../include/linux/spinlock_rt.h:24:56: note: expected
> 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 004888b..f3028e7 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1395,7 +1395,7 @@ static int omap_gpio_runtime_resume(struct device *dev)
> if (c != bank->context_loss_count) {
> omap_gpio_restore_context(bank);
> } else {
> - spin_unlock_irqrestore(&bank->lock, flags);
> + raw_spin_unlock_irqrestore(&bank->lock, flags);
> return 0;
> }
> }
>
This patch is not required since I've asked Sebastian to revert patch
caused this warning.
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
@ 2016-01-18 17:02 ` Sebastian Andrzej Siewior
2016-01-20 21:28 ` Anders Roxell
0 siblings, 1 reply; 19+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-01-18 17:02 UTC (permalink / raw
To: Anders Roxell
Cc: linux-rt-users, khilman, ccross, Rafael J. Wysocki,
daniel.lezcano, linux-pm
* Anders Roxell | 2016-01-15 20:21:12 [+0100]:
>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>warning without this fix:
>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
>defined but not used [-Wunused-variable]
>
>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Could you please forward this patch upstream? The driver was introduced
in 4126c0197bc8 ("cpuidle: add support for states that affect multiple
cpus") with the cpuidle_coupled_lock variable unused. This is not -RT
specific.
>---
> drivers/cpuidle/coupled.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>index 344058f..d5657d5 100644
>--- a/drivers/cpuidle/coupled.c
>+++ b/drivers/cpuidle/coupled.c
>@@ -119,7 +119,6 @@ struct cpuidle_coupled {
>
> #define CPUIDLE_COUPLED_NOT_IDLE (-1)
>
>-static DEFINE_MUTEX(cpuidle_coupled_lock);
> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
>
> /*
Sebastian
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
` (8 preceding siblings ...)
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
@ 2016-01-18 17:54 ` Sebastian Andrzej Siewior
9 siblings, 0 replies; 19+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-01-18 17:54 UTC (permalink / raw
To: Anders Roxell; +Cc: linux-rt-users, khilman
* Anders Roxell | 2016-01-15 20:21:04 [+0100]:
>Hi,
Hi,
>This patchset fixes some build warnings and errors that were introduced by
>v4.4-rt2. To build these patches they should be applied on top of patch [1], [2]
>and [3].
Thanks.
The AT91 pieces and hrtimer should have been fixed by now. An omap patch
has been dropped which makes #9 obsolete.
I picked up #8 and the patch you reference [3] and hope they pop-up
upstream soon :)
>Cheers,
>Anders
>[3] http://www.spinics.net/lists/kernel/msg2162906.html
Sebastian
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused var 'ret'
[not found] ` <CAGt3f4kZAL65+yeNh1qrAbap4SJNwQrSa=5QF0LN9Mh8ew5HSQ@mail.gmail.com>
@ 2016-01-18 18:34 ` Brian Silverman
2016-01-20 21:33 ` Anders Roxell
0 siblings, 1 reply; 19+ messages in thread
From: Brian Silverman @ 2016-01-18 18:34 UTC (permalink / raw
To: Anders Roxell, linux-rt-users, khilman; +Cc: bigeasy
The subject line for this one has the wrong variable name in it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
2016-01-18 17:02 ` Sebastian Andrzej Siewior
@ 2016-01-20 21:28 ` Anders Roxell
0 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-20 21:28 UTC (permalink / raw
To: Sebastian Andrzej Siewior
Cc: linux-rt-users, Kevin Hilman, ccross, Rafael J. Wysocki,
daniel.lezcano, linux-pm
On 18 January 2016 at 18:02, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> * Anders Roxell | 2016-01-15 20:21:12 [+0100]:
>
>>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>>warning without this fix:
>>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
>>defined but not used [-Wunused-variable]
>>
>>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Could you please forward this patch upstream? The driver was introduced
> in 4126c0197bc8 ("cpuidle: add support for states that affect multiple
> cpus") with the cpuidle_coupled_lock variable unused. This is not -RT
> specific.
Yes, I'll do that.
Cheers,
Anders
>
>>---
>> drivers/cpuidle/coupled.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>>index 344058f..d5657d5 100644
>>--- a/drivers/cpuidle/coupled.c
>>+++ b/drivers/cpuidle/coupled.c
>>@@ -119,7 +119,6 @@ struct cpuidle_coupled {
>>
>> #define CPUIDLE_COUPLED_NOT_IDLE (-1)
>>
>>-static DEFINE_MUTEX(cpuidle_coupled_lock);
>> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
>>
>> /*
>
> Sebastian
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type
2016-01-18 14:29 ` Grygorii Strashko
@ 2016-01-20 21:29 ` Anders Roxell
0 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2016-01-20 21:29 UTC (permalink / raw
To: Grygorii Strashko; +Cc: Sebastian Andrzej Siewior, linux-rt-users, Kevin Hilman
On 18 January 2016 at 15:29, Grygorii Strashko <grygorii.strashko@ti.com> wrote:
> On 01/15/2016 09:21 PM, Anders Roxell wrote:
>> Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>> warning without this fix:
>> ../drivers/gpio/gpio-omap.c: In function 'omap_gpio_runtime_resume':
>> ../drivers/gpio/gpio-omap.c:1398:4: warning: passing argument 1 of
>> 'rt_spin_unlock' from incompatible pointer type [enabled by default]
>> In file included from ../include/linux/spinlock.h:290:0,
>> from ../include/linux/seqlock.h:35,
>> from ../include/linux/time.h:5,
>> from ../include/linux/stat.h:18,
>> from ../include/linux/module.h:10,
>> from ../drivers/gpio/gpio-omap.c:16:
>> ../include/linux/spinlock_rt.h:24:56: note: expected
>> 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
>>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> ---
>> drivers/gpio/gpio-omap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
>> index 004888b..f3028e7 100644
>> --- a/drivers/gpio/gpio-omap.c
>> +++ b/drivers/gpio/gpio-omap.c
>> @@ -1395,7 +1395,7 @@ static int omap_gpio_runtime_resume(struct device *dev)
>> if (c != bank->context_loss_count) {
>> omap_gpio_restore_context(bank);
>> } else {
>> - spin_unlock_irqrestore(&bank->lock, flags);
>> + raw_spin_unlock_irqrestore(&bank->lock, flags);
>> return 0;
>> }
>> }
>>
>
> This patch is not required since I've asked Sebastian to revert patch
> caused this warning.
Yes your right, I've missed that.
Cheers,
Anders
>
> --
> regards,
> -grygorii
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused var 'ret'
2016-01-18 18:34 ` Brian Silverman
@ 2016-01-20 21:33 ` Anders Roxell
2016-01-20 21:34 ` Anders Roxell
0 siblings, 1 reply; 19+ messages in thread
From: Anders Roxell @ 2016-01-20 21:33 UTC (permalink / raw
To: Brian Silverman; +Cc: linux-rt-users, Kevin Hilman, Sebastian Andrzej Siewior
On 18 January 2016 at 19:34, Brian Silverman <bsilver16384@gmail.com> wrote:
> The subject line for this one has the wrong variable name in it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused var 'ret'
2016-01-20 21:33 ` Anders Roxell
@ 2016-01-20 21:34 ` Anders Roxell
2016-01-21 8:14 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 19+ messages in thread
From: Anders Roxell @ 2016-01-20 21:34 UTC (permalink / raw
To: Brian Silverman; +Cc: linux-rt-users, Kevin Hilman, Sebastian Andrzej Siewior
On 20 January 2016 at 22:33, Anders Roxell <anders.roxell@linaro.org> wrote:
> On 18 January 2016 at 19:34, Brian Silverman <bsilver16384@gmail.com> wrote:
>> The subject line for this one has the wrong variable name in it.
Thanks, I'll send a v2.
Cheers,
Anders
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused var 'ret'
2016-01-20 21:34 ` Anders Roxell
@ 2016-01-21 8:14 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 19+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-01-21 8:14 UTC (permalink / raw
To: Anders Roxell, Brian Silverman; +Cc: linux-rt-users, Kevin Hilman
On 01/20/2016 10:34 PM, Anders Roxell wrote:
> On 20 January 2016 at 22:33, Anders Roxell <anders.roxell@linaro.org> wrote:
>> On 18 January 2016 at 19:34, Brian Silverman <bsilver16384@gmail.com> wrote:
>>> The subject line for this one has the wrong variable name in it.
>
> Thanks, I'll send a v2.
No, please don't. It is all fixed by now.
>
> Cheers,
> Anders
>
Sebastian
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2016-01-21 8:14 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
2016-01-15 19:21 ` [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret' Anders Roxell
2016-01-15 19:21 ` [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared " Anders Roxell
2016-01-15 19:21 ` [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused " Anders Roxell
[not found] ` <CAGt3f4kZAL65+yeNh1qrAbap4SJNwQrSa=5QF0LN9Mh8ew5HSQ@mail.gmail.com>
2016-01-18 18:34 ` Brian Silverman
2016-01-20 21:33 ` Anders Roxell
2016-01-20 21:34 ` Anders Roxell
2016-01-21 8:14 ` Sebastian Andrzej Siewior
2016-01-15 19:21 ` [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq' Anders Roxell
2016-01-15 19:21 ` [PATCH 7/9] kernel/time: hrtimer: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
2016-01-18 17:02 ` Sebastian Andrzej Siewior
2016-01-20 21:28 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
2016-01-18 14:29 ` Grygorii Strashko
2016-01-20 21:29 ` Anders Roxell
2016-01-18 17:54 ` [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Sebastian Andrzej Siewior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.