From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF2BC54E64 for ; Mon, 25 Mar 2024 11:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FFD56B0085; Mon, 25 Mar 2024 07:21:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AFA56B0087; Mon, 25 Mar 2024 07:21:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C5EC6B0088; Mon, 25 Mar 2024 07:21:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 207236B0085 for ; Mon, 25 Mar 2024 07:21:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A5E7A803A8 for ; Mon, 25 Mar 2024 11:21:19 +0000 (UTC) X-FDA: 81935320278.09.7E3FE70 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf10.hostedemail.com (Postfix) with ESMTP id 882A2C0006 for ; Mon, 25 Mar 2024 11:21:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=IoMjbvdf; spf=pass (imf10.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.218.45 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711365678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0c+XedPdeNuNXfU5mtLEzBWBIzV1dWjxq7xb3M/FhvM=; b=HKknTntffdU8OuNTOTyzGOhG7BWraDBRyg/jmk+R+ktBFzI+vP0GlDa1Rbhvei0LbCvIcg JM00If2pI4QqZRd8nyNRl8DfBX3iHXizhvPUwipYkZi1+F74H1zQphQc0cOkQhjVSmbrSq 3Bdg8wqoQrkaK3Wtw0Xuj111kGEzkXM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711365678; a=rsa-sha256; cv=none; b=RE+M96UOwDn6tiMLik3EAWL+mNrv/chL5IE2XHH3tbMMCl93rbzMBcwysGSRCghc9utsz8 PzdlSe0qdS7KckiocWSRq2YWewhTZbX+OnbPS5oD5AMoybjBQvzWgbwnRee7BZww2NRNmj VTrgxMC9jJXVB9g8K70NYDVqzFeKV/k= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=IoMjbvdf; spf=pass (imf10.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.218.45 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a4644bde1d4so561631966b.3 for ; Mon, 25 Mar 2024 04:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1711365676; x=1711970476; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0c+XedPdeNuNXfU5mtLEzBWBIzV1dWjxq7xb3M/FhvM=; b=IoMjbvdfaSDW8p8nhFU1lB56wksYhQg9og9vAL3Y4s1GItdZiceUbNv2qYtQTEy7Zd 9+vwT2fAKjfOQQYYqa2EgjBrADBveQvGfewKCctty12kfBvRt45eEJ4Fg6PROFTfPsv4 52vdrT2/qxP5nxZgejEv/AlFgzJqeXkDww3aw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711365676; x=1711970476; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0c+XedPdeNuNXfU5mtLEzBWBIzV1dWjxq7xb3M/FhvM=; b=cQ8glqjAqpGCAadP+nHt9hYjrD4oDjWmPfrF9H9pX0DSb8hcoRgjEIRUqy5ILGjk5y EiClm9Jyr8iWT05Zo6NG9pnqe/OmyerVyzfB4obcssQXqJ/zxiYAqktFfaJfHWPevnjx 7dX3Dmj7IjdSqJZoN06bMPM9Ef8pFSuTzQ2T8YI+itJo7rqgbSZnGSGwwb0ulTwJHCqF WUAZGuqa6Jt5zVFRyrAuShy1vxcNi/5+aBHyFcQcQfwilWzdWcbSPseDQivL5AsY5Lp3 kp0AeDYgBM8nxnN7ggix0dE05RjCvVQ4u7PT5ApU0HumqJzmzbWYTDsqrqV0rMf/ia6v aUCQ== X-Forwarded-Encrypted: i=1; AJvYcCXBx2oO7BrLKpIxFV61vygWmeFNWSxomoPeHt2N+9eNMhQ10HgjvxZb8q7QWFnR2+dTbxJAOUDXaBxvo0w2UgRhVFs= X-Gm-Message-State: AOJu0Yz9Jt13Yl2CavFPVaqd/LxqmDk4xdxiBUPPvuEArFr0K9MdlQ0P K4H49U5KhyoO0Ljzfzu/DhimtlWPPRdSl8wbYpV/nFzZBs5H0XU9QNI+oQQ3jIFPKAIOwz1I8w8 1RCZ4O5R/266fsvVg/7DHPKzLbF0QYiEv55+BGw== X-Google-Smtp-Source: AGHT+IEHgtn80L49Skt3CEF+hTXCA3FdVG+hC9lS8i92+yyLZZ9XMCkOBIMmlhGWRtndIytDvEiwFaWaIbgkiRj6zl8= X-Received: by 2002:a17:906:b109:b0:a46:d978:bf02 with SMTP id u9-20020a170906b10900b00a46d978bf02mr3970124ejy.34.1711365675733; Mon, 25 Mar 2024 04:21:15 -0700 (PDT) MIME-Version: 1.0 References: <620f68b0-4fe0-4e3e-856a-dedb4bcdf3a7@redhat.com> <463612f2-5590-4fb3-8273-0d64c3fd3684@redhat.com> In-Reply-To: From: Miklos Szeredi Date: Mon, 25 Mar 2024 12:21:04 +0100 Message-ID: Subject: Re: BUG: unable to handle kernel paging request in fuse_copy_do To: David Hildenbrand Cc: xingwei lee , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samsun1006219@gmail.com, syzkaller-bugs@googlegroups.com, linux-mm , Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 882A2C0006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4atwbka9jccx97nm7f4bkwykt5or9en4 X-HE-Tag: 1711365677-317742 X-HE-Meta: U2FsdGVkX19CqzCqTlnlYHfwYh8K7lFAdjI4fblfF6eXEi0G2hm0Jz8ufrOLI8G89H9gnG0mj2tvyEm0weZWdo7LXU19ZyqsGx8IwdVnamZsMuf3kU+x4m7Xn4eBByaEhACpLYh36WLSVKmrvapxWWXEPl0A/fxrua6O9/G5dkYFXD8cjxsN6fXBkreXC70eHQV76eOaD1m2OdImyp0lt/+LhLOLxP2a/QNC3TntOvjYf4/UIBXfHJ5i9qcDTjf1Wt92nUWz0NvQhaEtwsd+8i3zHIz4bCOhpmtCc3skl0cpsST8O9aBJtFnevTjXAk29G7qfiAoqq8K7mrO82QIjizD823LP7g2ZrtrQOHz8pqZ588xxBHMLuRBmBxHZJrXexNGooRqrfpYv+5T6Y4/kNAvZESZvodoaEsXcQh72w6GoaUoYqKIYCHEClP1Ol43/ozSoK1H8XzMiuOrVyPol2kP9/kalgDWOax6q9cULPNuMFn3ynTaqQgREcXakUKrlJZNMrW0MIAFznlPvM0tdo12jGQMYkzTRYV7o7JbkjTKo6QHZNAJan9Ty2OAKaXqn/7zWgSqv1FULD9rp1QFn0Twfk2PN9fFPHm+1Dqq3ujbJpx/6lhZLQ4eTrEc2HLAY2CssKHkO1Q82+GlWaEWDDmdT19jSGDXe7TVbpemJFpoDK4ET+bXwAK4UQXzkI/xTGhvoHwROnOPwh6NiDLMWpbnR40pMV8fGg7g32XwwQCO0YRy90kO3OgHK2vG2kscddAuaD7RUPZKyBq9YyDVJVI+4xkWu16SxBG7QtGgqT6qHW88KD5JSfkIg5evCPf/wk19i7xzrabmN88RmtTUJbREytVtdEm5fJgU0WaUiopKG3SA99Xm1ajjqmi8zpL8/fJrX2wgzAjrFJhvePTv8lVlPRrGNpjkCtkr5FvQrWK1azkIBAHRpAhZyhQiZ6c+xI7jlLN9B5yKnXJGHDG QbwtKT44 L3HDmSrUcGONFCj4F/1JUk7hkpcERQMg5qxc3Slme5HFcivT29d7GoyfWK2JoLcTvUGev1fK3MQWw1rFsGuWDOmRu1tgJqHKb1cC/6hENpACf1k+pLmu5M1vyDsO+6CF9AAcc1CO464yLPdJAwDOrVWl0WIzAJ3o0ANi3jwWtXZy5d7HIfjfDAyYiNhTUAbPjXtKd8P/oejZ6FOK58dsP6sifNkonrCxZM1lqTUIStuIJdtfyXS2eqe2vwmOVvLI5KQWft8iHAmlcqn6FeHwxVE9Qy8JT53uVwhYVTmurIEUSDBoRWJFOUgQ+BBjrgssrzZSJNToTMuFmyGnM/Z5KIyWZihtSnOI92W9OzuM6UFcEcaUZIk/fqgUZVqiQVmLurtJ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000823, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 22 Mar 2024 at 22:56, David Hildenbrand wrote: > From 85558a46d9f249f26bd77dd3b18d14f248464845 Mon Sep 17 00:00:00 2001 > From: David Hildenbrand > Date: Fri, 22 Mar 2024 22:45:36 +0100 > Subject: [PATCH] mm/secretmem: fix GUP-fast succeeding on secretmem folios > > folio_is_secretmem() states that secretmem folios cannot be LRU folios: > so we may only exit early if we find an LRU folio. Yet, we exit early if > we find a folio that is not a secretmem folio. > > Consequently, folio_is_secretmem() fails to detect secretmem folios and, > therefore, we can succeed in grabbing a secretmem folio during GUP-fast, > crashing the kernel when we later try reading/writing to the folio, because > the folio has been unmapped from the directmap. > > Reported-by: xingwei lee > Reported-by: yue sun > Debugged-by: Miklos Szeredi > Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas") > Cc: > Signed-off-by: David Hildenbrand Verified that it's no longer crashing with the reproducers. Tested-by: Miklos Szeredi