From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1620EC48BE5 for ; Fri, 11 Jun 2021 13:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB937613E3 for ; Fri, 11 Jun 2021 13:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231687AbhFKNR2 (ORCPT ); Fri, 11 Jun 2021 09:17:28 -0400 Received: from mail-vk1-f181.google.com ([209.85.221.181]:39932 "EHLO mail-vk1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbhFKNR0 (ORCPT ); Fri, 11 Jun 2021 09:17:26 -0400 Received: by mail-vk1-f181.google.com with SMTP id k189so2502641vkb.6 for ; Fri, 11 Jun 2021 06:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W4p7Da6Bo96meqCCmYg1il+szOZMpXmVP32ev1MWjqw=; b=Ot4WYiEYRIGG3AWEh0UfJ0VBCs67SEfKPGht+bHJknT5g7pwYlgHwxQOciIHRzx08m hIt7/+kXeW2MYUANeixNF4W5KD5kfebehNQo/rfBst3oCwi3WSyG6RpK1tOaGaf/tEsw ZAWXWpBc4AkEFVwaWWEK6gFWoOOSKw571BVes= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W4p7Da6Bo96meqCCmYg1il+szOZMpXmVP32ev1MWjqw=; b=C/lwwvlgbstj8Ti/YEBD0jmLu25ApBn4sQ3OjGz8nK8/nxCZRK3Ycdtg06VPilbZPn /uzKROt9TvrpevtHu4VyE56IMVolAiiYYp/RT7koIbdchq/u1EQ8FGdNn/39KPJnaugL cOYvv7LgSkqcOEOiH0tSFUkGmzzcnI2pRCvd3AxpY2Xax90N5Fjvw4FVngoWvrEJme89 wqeNC9wk30K6W/qsIv3GxYJ2O4Addyc3SPC4MqS5D4KUFm0k4TCViEMAEhh9td6svZHu bam2X52PHPXThseARHK+SwiQzqCbNWHcxlWVdtnCINHh2BeRcMmqgnYaJVrTZurN84Er 7HXg== X-Gm-Message-State: AOAM53263RngDtzSVueWtLqI1NJd27pV5PqTTPHXbqM28F24bOZoSn7r HYj3aQjyN3PdoFYifQstSt5b+mynF0NJ7IUMhcQ+3g== X-Google-Smtp-Source: ABdhPJykpGz+EVt6yKODI9QwMAUVsXqDJL2V4qGkSQk27RFpMDRg7Bxel51dVr3TK8CqlFwAjV275wHFlPReYTBQ0Cg= X-Received: by 2002:ac5:c9b5:: with SMTP id f21mr8183303vkm.23.1623417268493; Fri, 11 Jun 2021 06:14:28 -0700 (PDT) MIME-Version: 1.0 References: <162322846765.361452.17051755721944717990.stgit@web.messagingengine.com> <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com> In-Reply-To: <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com> From: Miklos Szeredi Date: Fri, 11 Jun 2021 15:14:17 +0200 Message-ID: Subject: Re: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock To: Ian Kent Cc: Greg Kroah-Hartman , Tejun Heo , Eric Sandeen , Fox Chen , Brice Goglin , Al Viro , Rick Lindsley , David Howells , Marcelo Tosatti , "Eric W. Biederman" , Carlos Maiolino , linux-fsdevel , Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jun 2021 at 10:52, Ian Kent wrote: > > The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on > any kernfs node so there's no reason to hold the kernfs node lock when > calling it. > > Signed-off-by: Ian Kent Reviewed-by: Miklos Szeredi