From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Clayton Casciato <majortomtosourcecontrol@gmail.com>
Cc: "Zhang, Rui" <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] acpi: acpi_video: Fixed comment style code issues
Date: Mon, 14 Jun 2021 16:50:05 +0200 [thread overview]
Message-ID: <CAJZ5v0izub_zSJih1_5rznQPzgpHJ7-LhcWGarg7iyh+U2g-9A@mail.gmail.com> (raw)
In-Reply-To: <20210612184008.666840-1-majortomtosourcecontrol@gmail.com>
On Sat, Jun 12, 2021 at 8:42 PM Clayton Casciato
<majortomtosourcecontrol@gmail.com> wrote:
>
> Fixed coding style issues.
The comments are broken the way they are to avoid going over 80
characters. What's wrong with them?
> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> ---
> drivers/acpi/acpi_video.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 0c884020f74b..61e52ab5aab6 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -134,8 +134,7 @@ struct acpi_video_device_attrib {
> u32 display_type:4; /* Describe the specific type in use */
> u32 vendor_specific:4; /* Chipset Vendor Specific */
> u32 bios_can_detect:1; /* BIOS can detect the device */
> - u32 depend_on_vga:1; /* Non-VGA output device whose power is related to
> - the VGA device. */
> + u32 depend_on_vga:1; /* Non-VGA output device whose power is related to the VGA device */
> u32 pipe_id:3; /* For VGA multiple-head devices. */
> u32 reserved:10; /* Must be 0 */
>
> @@ -1581,13 +1580,11 @@ static void acpi_video_bus_notify(struct acpi_device *device, u32 event)
> input = video->input;
>
> switch (event) {
> - case ACPI_VIDEO_NOTIFY_SWITCH: /* User requested a switch,
> - * most likely via hotkey. */
> + case ACPI_VIDEO_NOTIFY_SWITCH: /* User requested a switch, most likely via hotkey. */
> keycode = KEY_SWITCHVIDEOMODE;
> break;
>
> - case ACPI_VIDEO_NOTIFY_PROBE: /* User plugged in or removed a video
> - * connector. */
> + case ACPI_VIDEO_NOTIFY_PROBE: /* User plugged in or removed a video connector. */
> acpi_video_device_enumerate(video);
> acpi_video_device_rebind(video);
> keycode = KEY_SWITCHVIDEOMODE;
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-14 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 18:40 [PATCH] acpi: acpi_video: Fixed comment style code issues Clayton Casciato
2021-06-14 14:50 ` Rafael J. Wysocki [this message]
2021-06-15 5:43 ` Clayton Casciato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0izub_zSJih1_5rznQPzgpHJ7-LhcWGarg7iyh+U2g-9A@mail.gmail.com \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=majortomtosourcecontrol@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.