From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com,
stevex.yang@intel.com, Murphy Yang <murphyx.yang@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error
Date: Fri, 29 Mar 2024 09:26:23 +0100 [thread overview]
Message-ID: <CAJFAV8yiOgFd=L=YMK8jR5184YFTNbFDJG8SR4yH_Vi+wbX7LQ@mail.gmail.com> (raw)
In-Reply-To: <20201123070523.21661-1-murphyx.yang@intel.com>
Hello,
On Mon, Nov 23, 2020 at 8:08 AM Murphy Yang <murphyx.yang@intel.com> wrote:
>
> If enable hardware outer UDP TX offload checksum, it doesn't take effect
> when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
>
> In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT'
> equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware
> can calculate the outer tunneling UDP checksum.
>
> Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
>
> Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> index 5fbd68eafc..9769e216bf 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
> *cd_tunneling |= (tx_offload.l2_len >> 1) <<
> ICE_TXD_CTX_QW0_NATLEN_S;
>
> - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
> - (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
> + /**
> + * Calculate the tunneling UDP checksum.
> + * Shall be set only if L4TUNT = 01b and EIPT is not zero
> + */
> + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
drivers/net/ice/base/ice_lan_tx_rx.h: ICE_TX_CTX_EIPT_NONE = 0x0,
So this check above is always true...
I suspect the intent was:
if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE)
> (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
> *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
> }
> --
> 2.17.1
>
--
David Marchand
prev parent reply other threads:[~2024-03-29 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 7:05 [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error Murphy Yang
2020-11-23 8:30 ` Xie, WeiX
2020-12-11 2:08 ` Zhang, Qi Z
2024-03-29 8:26 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yiOgFd=L=YMK8jR5184YFTNbFDJG8SR4yH_Vi+wbX7LQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=murphyx.yang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.