From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org, yuying.zhang@intel.com, xiaoyun.li@intel.com,
stevex.yang@intel.com, beilei.xing@intel.com,
qi.z.zhang@intel.com, Jie Wang <jie1x.wang@intel.com>,
stable@dpdk.org, Kevin Traynor <ktraynor@redhat.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix forward outer IPv6 VXLAN packets
Date: Fri, 29 Mar 2024 09:16:07 +0100 [thread overview]
Message-ID: <CAJFAV8yEeuHNxUraJNt7cUFRvFJa41p9Q8xmD3QGW8H4m+0cvA@mail.gmail.com> (raw)
In-Reply-To: <20211105033705.285200-1-jie1x.wang@intel.com>
Hello Bruce, John,
On Fri, Nov 5, 2021 at 4:39 AM Jie Wang <jie1x.wang@intel.com> wrote:
>
> Testpmd forwards packets in checksum mode that it need to calculate
> the checksum of each layer's protocol. Then it will fill flags and
> header length into mbuf.
>
> In process_outer_cksums, HW calculates the outer checksum if
> tx_offloads contains outer UDP checksum otherwise SW calculates
> the outer checksum.
>
> When tx_offloads contains outer UDP checksum or outer IPv4 checksum,
> mbuf will be filled with correct header length.
>
> This patch added outer UDP checksum in tx_offload_capa and
> I40E_TX_OFFLOAD_MASK, when we set csum hw outer-udp on that the
> engine can forward outer IPv6 VXLAN packets.
>
> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
- There is a bz opened by a OVS user trying to offload geneve checksum.
https://bugs.dpdk.org/show_bug.cgi?id=1406
Reading the X7xx datasheet, parsing i40e_parse_tunneling_params() and
looking at the packets reported by the user, I understand that outer
udp checksum is actually *not* supported by net/i40e.
And so the change from this mail thread should be reverted as the
driver falsely claims support for this feature.
- I found some bits about X722 (5535087e6c56 ("i40e/base: add outer
UDP checksum for X722")) supporting this feature, but I did not find a
definition in the datasheet.
Besides, this I40E_TXD_CTX_QW0_L4T_CS_MASK is not used in the net/i40e tx path.
We need Intel to clear state what is supported or not, and send fixes
accordingly.
Thanks.
--
David Marchand
prev parent reply other threads:[~2024-03-29 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:08 [dpdk-dev] [PATCH] net/i40e: fix forward outer IPv6 VXLAN packets Jie Wang
2021-11-05 3:18 ` Xing, Beilei
2021-11-05 3:37 ` [dpdk-dev] [PATCH v2] " Jie Wang
2021-11-05 3:48 ` Xing, Beilei
2021-11-11 18:25 ` [dpdk-stable] " Ferruh Yigit
2024-03-29 8:16 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yEeuHNxUraJNt7cUFRvFJa41p9Q8xmD3QGW8H4m+0cvA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jie1x.wang@intel.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.