From: Tim Harvey <tharvey@gateworks.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de,
Angelo Dureghello <angelo@kernel-space.org>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Gaurav Jain <gaurav.jain@nxp.com>,
Michal Simek <michal.simek@amd.com>,
Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
Date: Fri, 26 Apr 2024 10:34:07 -0700 [thread overview]
Message-ID: <CAJ+vNU1sYMGMeJemEaMvEO4RNS_Yb-BZse3x6dXehjHL-+Gfkw@mail.gmail.com> (raw)
In-Reply-To: <8d75e195-d644-4436-8007-8476da589032@gmx.de>
On Fri, Apr 26, 2024 at 7:45 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 26.04.24 06:03, Marek Vasut wrote:
> > On 4/26/24 2:16 AM, Tim Harvey wrote:
> >
> >>> diff --git a/drivers/crypto/fsl/Makefile b/drivers/crypto/fsl/Makefile
> >>> index 7a2543e16cc..4fbce519a0b 100644
> >>> --- a/drivers/crypto/fsl/Makefile
> >>> +++ b/drivers/crypto/fsl/Makefile
> >>> @@ -6,6 +6,6 @@ obj-y += sec.o
> >>> obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
> >>> obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o
> >>> obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o
> >>> -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o
> >>> +obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o
> >>> obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o
> >>> obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o
> >>> --
> >>> 2.43.0
> >>>
> >>
> >> Marek,
> >
> > Hi,
> >
> >> Thanks - this series does solve the issue I am seeing in the SPL when
> >> enabling DM_RNG. Is this going to cause an issue for people who expect
> >> it to be currently enabled and now have to manually enable it?
> >
> > That's a good question. If I do '$ git grep FSL_CAAM_RNG' , there seem
> > to be no users, so I don't think we need to worry here, right ?
> >
> > With SPL_DM_RNG i.e. 1/3 I am a bit more concerned. But, looking at the
> > users that enable DM_RNG, I am not seeing any obvious ones that would
> > require SPL_DM_RNG too. What do you think ?
>
> Grepping for UCLASS_RNG should find usages.
>
> The only possible SPL usage seems to be in net/net_rand.h. Here a
> fallback to the mac address as seed exists.
>
> Best regards
>
> Heinrich
>
Hi Heinrich,
looks like its also used in lib/uuid.c by CONFIG_RANDOM_UUID and the
few configs have CONFIG_RANDOM_UUID=y do not have DM_RNG=y so not an
issue.
srand_mac is used in:
net/bootp.c which is CONFIG_CMD_BOOTP so not SPL
net/dhcpv6.c which is CONIFG_CMD_DHCP6 so not in SPL
net/net.c which is used by CONFIG_SPL_DM_ETH and the fallback you
refer to but 'git grep DM_RNG=y configs/ | cut -d: -f1 | xargs grep
SPL_DM_ETH' shows no results so I think this is ok right?
but I also see lib/efi_loader/efi_rng.c where UCLASS_RNG used by
efi_rng_protocol - I don't know anything about efi... is this going to
be used by SPL?
Best Regards,
Tim
next prev parent reply other threads:[~2024-04-26 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 23:02 [PATCH 1/3] rng: Introduce SPL_DM_RNG Marek Vasut
2024-04-25 23:02 ` [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG Marek Vasut
2024-04-26 0:16 ` Tim Harvey
2024-04-26 4:03 ` Marek Vasut
2024-04-26 14:39 ` Heinrich Schuchardt
2024-04-26 17:29 ` Marek Vasut
2024-04-26 17:34 ` Tim Harvey [this message]
2024-04-26 19:31 ` Heinrich Schuchardt
2024-04-29 9:02 ` [EXT] " Gaurav Jain
2024-04-29 12:32 ` Marek Vasut
2024-04-25 23:02 ` [PATCH 3/3] crypto/fsl: Differentiate between CAAM and DCP in Kconfig entry Marek Vasut
2024-05-05 19:12 ` [PATCH 1/3] rng: Introduce SPL_DM_RNG Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+vNU1sYMGMeJemEaMvEO4RNS_Yb-BZse3x6dXehjHL-+Gfkw@mail.gmail.com \
--to=tharvey@gateworks.com \
--cc=angelo@kernel-space.org \
--cc=clamor95@gmail.com \
--cc=emanuele.ghidoli@toradex.com \
--cc=festevam@gmail.com \
--cc=gaurav.jain@nxp.com \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.