* [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths
@ 2021-01-13 18:22 Barnabás Pőcze
2021-01-16 20:10 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Barnabás Pőcze @ 2021-01-13 18:22 UTC (permalink / raw
To: platform-driver-x86, Hans de Goede, Mark Gross, Ike Panhc
The documentation referred to non-existent device attributes under a non-existent
platform device. Update it with the current location of the attributes.
Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/Documentation/ABI/testing/sysfs-platform-ideapad-laptop b/Documentation/ABI/testing/sysfs-platform-ideapad-laptop
index fd2ac02bc5bd..e024678947c8 100644
--- a/Documentation/ABI/testing/sysfs-platform-ideapad-laptop
+++ b/Documentation/ABI/testing/sysfs-platform-ideapad-laptop
@@ -1,11 +1,11 @@
-What: /sys/devices/platform/ideapad/camera_power
+What: /sys/bus/platform/devices/VPC2004:*/camera_power
Date: Dec 2010
KernelVersion: 2.6.37
Contact: "Ike Panhc <ike.pan@canonical.com>"
Description:
Control the power of camera module. 1 means on, 0 means off.
-What: /sys/devices/platform/ideapad/fan_mode
+What: /sys/bus/platform/devices/VPC2004:*/fan_mode
Date: June 2012
KernelVersion: 3.6
Contact: "Maxim Mikityanskiy <maxtram95@gmail.com>"
@@ -18,7 +18,7 @@ Description:
* 2 -> Dust Cleaning
* 4 -> Efficient Thermal Dissipation Mode
-What: /sys/devices/platform/ideapad/touchpad
+What: /sys/bus/platform/devices/VPC2004:*/touchpad
Date: May 2017
KernelVersion: 4.13
Contact: "Ritesh Raj Sarraf <rrs@debian.org>"
@@ -27,7 +27,7 @@ Description:
* 1 -> Switched On
* 0 -> Switched Off
-What: /sys/bus/pci/devices/<bdf>/<device>/VPC2004:00/fn_lock
+What: /sys/bus/platform/devices/VPC2004:*/fn_lock
Date: May 2018
KernelVersion: 4.18
Contact: "Oleg Keri <ezhi99@gmail.com>"
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths
2021-01-13 18:22 [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths Barnabás Pőcze
@ 2021-01-16 20:10 ` Andy Shevchenko
2021-01-16 22:58 ` Barnabás Pőcze
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-01-16 20:10 UTC (permalink / raw
To: Barnabás Pőcze
Cc: Platform Driver, Hans de Goede, Mark Gross, Ike Panhc
On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze <pobrn@protonmail.com> wrote:
>
> The documentation referred to non-existent device attributes under a non-existent
> platform device. Update it with the current location of the attributes.
Fixes tag, please?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths
2021-01-16 20:10 ` Andy Shevchenko
@ 2021-01-16 22:58 ` Barnabás Pőcze
2021-01-17 20:57 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Barnabás Pőcze @ 2021-01-16 22:58 UTC (permalink / raw
To: Andy Shevchenko; +Cc: Platform Driver, Hans de Goede, Mark Gross, Ike Panhc
Hi
Thanks for the review.
2021. január 16., szombat 21:10 keltezéssel, Andy Shevchenko írta:
> On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze wrote:
> >
> > The documentation referred to non-existent device attributes under a non-existent
> > platform device. Update it with the current location of the attributes.
>
> Fixes tag, please?
>
I'm not sure which commit (if any) should be referenced. Do you think
the patch that removed the platform device - hence making the documented paths
incorrect - would be OK to reference here?
Thanks,
Barnabás Pőcze
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths
2021-01-16 22:58 ` Barnabás Pőcze
@ 2021-01-17 20:57 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-01-17 20:57 UTC (permalink / raw
To: Barnabás Pőcze
Cc: Platform Driver, Hans de Goede, Mark Gross, Ike Panhc
On Sun, Jan 17, 2021 at 12:58 AM Barnabás Pőcze <pobrn@protonmail.com> wrote:
> 2021. január 16., szombat 21:10 keltezéssel, Andy Shevchenko írta:
> > On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze wrote:
> > > The documentation referred to non-existent device attributes under a non-existent
> > > platform device. Update it with the current location of the attributes.
> >
> > Fixes tag, please?
> >
>
> I'm not sure which commit (if any) should be referenced. Do you think
> the patch that removed the platform device - hence making the documented paths
> incorrect - would be OK to reference here?
From your description it looks like the right one, the general rule is
to find a change after which this becomes broken / invalid.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-17 20:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 18:22 [PATCH v2 23/24] Documentation/ABI: sysfs-platform-ideapad-laptop: update device attribute paths Barnabás Pőcze
2021-01-16 20:10 ` Andy Shevchenko
2021-01-16 22:58 ` Barnabás Pőcze
2021-01-17 20:57 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.