From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Saravanan Sekar <sravanhome@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Sebastian Reichel <sre@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] mfd: mp2629: Add support for mps battery charger
Date: Sat, 28 Mar 2020 12:45:31 +0200 [thread overview]
Message-ID: <CAHp75Vdc4MxMnmd_h6eFfZAji=4fir7x7bq2MX1q50nAQ1eJ=Q@mail.gmail.com> (raw)
In-Reply-To: <20200328001154.17313-3-sravanhome@gmail.com>
On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
>
> mp2629 is a highly-integrated switching-mode battery charge management
> device for single-cell Li-ion or Li-polymer battery.
>
> Add MFD core enables chip access for ADC driver for battery readings,
> and a power supply battery-charger driver
...
> +#ifndef __MP2629_H__
> +#define __MP2629_H__
> +#include <linux/device.h>
> +#include <linux/regmap.h>
> +#include <linux/types.h>
None of these header is in use here.
struct device;
struct regmap;
would be enough.
> +struct mp2629_info {
> + struct device *dev;
> + struct regmap *regmap;
> +};
> +
> +#endif
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-28 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 0:11 [PATCH v5 0/5] Add battery charger driver support for MP2629 Saravanan Sekar
2020-03-28 0:11 ` [PATCH v5 1/5] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-03-28 0:11 ` [PATCH v5 2/5] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-03-28 10:45 ` Andy Shevchenko [this message]
2020-03-28 10:51 ` saravanan sekar
2020-03-28 11:06 ` Andy Shevchenko
2020-03-28 0:11 ` [PATCH v5 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-03-28 10:52 ` Andy Shevchenko
2020-03-28 17:51 ` Jonathan Cameron
2020-03-28 0:11 ` [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-03-28 11:02 ` Andy Shevchenko
2020-03-28 11:03 ` Andy Shevchenko
2020-03-28 11:29 ` saravanan sekar
2020-03-28 18:44 ` Andy Shevchenko
2020-03-29 10:34 ` saravanan sekar
2020-03-29 11:17 ` Andy Shevchenko
2020-03-28 0:11 ` [PATCH v5 5/5] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdc4MxMnmd_h6eFfZAji=4fir7x7bq2MX1q50nAQ1eJ=Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.