From: Yi Zhang <yi.zhang@redhat.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
linux-block <linux-block@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>
Subject: Re: [bug report] RIP: 0010:blk_flush_complete_seq+0x450/0x1060 observed during blktests nvme/tcp nvme/012
Date: Thu, 9 May 2024 14:15:04 +0800 [thread overview]
Message-ID: <CAHj4cs_+NaQ4eZQo1b8rRLsGPMgCKUyaOW8e5Rpi1AUW7vJ8rw@mail.gmail.com> (raw)
In-Reply-To: <87d1ac8a-df56-459d-a2f8-bcf940aa9e0b@nvidia.com>
Confirmed the issue was fixed with this patch.
https://lore.kernel.org/linux-block/20240501110907.96950-9-dlemoal@kernel.org/
On Sat, May 4, 2024 at 5:14 AM Chaitanya Kulkarni <chaitanyak@nvidia.com> wrote:
>
>
> >> This is something Damien added to his patch series. I just wonder, why I
> >> couldn't reproduce the failure, even with nvme-mpath enabled. I tried
> >> both nvme-tcp as well as nvme-loop without any problems.
> >
> > Not exactly sure.
> >
> > From what I see blk_flush_complete_seq() will only call
> > blk_flush_restore_request() and
> > panic is for error != 0. And if that is the case, any request with its
> > bios stolen must panic.
> >
> > However, nvme-mpath always ends a stolen request with error = 0.
> >
> > Seems that there is code that may override the request error status in
> > flush_end_io() but I cannot
> > see it in the trace...
>
>
> I confirm that after several tries I cannot reproduced it either with
> and without multi-pathing, blktests is passing without any errors for
> both nvme-loop and nvme-tcp ....
>
> -ck
>
>
--
Best Regards,
Yi Zhang
prev parent reply other threads:[~2024-05-09 6:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 13:17 [bug report] RIP: 0010:blk_flush_complete_seq+0x450/0x1060 observed during blktests nvme/tcp nvme/012 Yi Zhang
2024-04-26 8:30 ` [bug report][bisected] " Yi Zhang
2024-04-29 14:35 ` [bug report] " Johannes Thumshirn
2024-04-29 22:18 ` Chaitanya Kulkarni
2024-04-30 6:16 ` Johannes Thumshirn
2024-04-30 14:17 ` Yi Zhang
2024-05-03 7:59 ` Sagi Grimberg
2024-05-03 10:32 ` Johannes Thumshirn
2024-05-03 11:01 ` Sagi Grimberg
2024-05-03 21:14 ` Chaitanya Kulkarni
2024-05-09 6:15 ` Yi Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHj4cs_+NaQ4eZQo1b8rRLsGPMgCKUyaOW8e5Rpi1AUW7vJ8rw@mail.gmail.com \
--to=yi.zhang@redhat.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.