* pinctrl: sirf: switch driver to use gpiolib irqchip helpers
[not found] ` <5EB3BFCD089AD643B9BB63439F5FD5E9012BE8AD2D@SHAASIEXM01.ASIA.ROOT.PRI>
@ 2014-05-02 16:09 ` Barry Song
0 siblings, 0 replies; only message in thread
From: Barry Song @ 2014-05-02 16:09 UTC (permalink / raw
To: linux-arm-kernel
>
>
>> -----Original Message-----
>> From: Dan Carpenter [mailto:dan.carpenter at oracle.com]
>> Sent: Friday, May 02, 2014 6:56 PM
>> To: linus.walleij at linaro.org
>> Cc: Barry Song; linux-arm-kernel at lists.infradead.org
>> Subject: re: pinctrl: sirf: switch driver to use gpiolib irqchip helpers
>>
>> Hello Linus Walleij,
>>
>> The patch 7420d2d09b12: "pinctrl: sirf: switch driver to use gpiolib irqchip
>> helpers" from Apr 15, 2014, leads to the following static checker warning:
>>
>> drivers/pinctrl/sirf/pinctrl-sirf.c:578 sirfsoc_gpio_handle_irq()
>> warn: buffer overflow 'sgpio_chip.sgpio_bank' 5 <= 31
>>
>> drivers/pinctrl/sirf/pinctrl-sirf.c
>> 569 static void sirfsoc_gpio_handle_irq(unsigned int irq, struct irq_desc
>> *desc)
>> 570 {
>> 571 struct sirfsoc_gpio_bank *bank;
>> 572 u32 status, ctrl;
>> 573 int idx = 0;
>> 574 struct irq_chip *chip = irq_get_chip(irq);
>> 575 int i;
>> 576
>> 577 for (i = 0; i < SIRFSOC_GPIO_BANK_SIZE; i++) {
>>
>> Probably i < SIRFSOC_GPIO_NO_OF_BANKS (5) was intended here.
yes. it was a typo. i'll do a patch to fix it.
>>
>> 578 bank = &sgpio_chip.sgpio_bank[i];
>> 579 if (bank->parent_irq == irq)
>> 580 break;
>> 581 }
>>
>> regards,
>> dan carpenter
-barry
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-05-02 16:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140502105536.GA32382@mwanda>
[not found] ` <5EB3BFCD089AD643B9BB63439F5FD5E9012BE8AD2D@SHAASIEXM01.ASIA.ROOT.PRI>
2014-05-02 16:09 ` pinctrl: sirf: switch driver to use gpiolib irqchip helpers Barry Song
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.