From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0111DC48BCF for ; Sat, 12 Jun 2021 18:34:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 196B16120E for ; Sat, 12 Jun 2021 18:34:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 196B16120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B96C80412; Sat, 12 Jun 2021 20:34:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IaBG7HV3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7895380797; Sat, 12 Jun 2021 20:34:34 +0200 (CEST) Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 70BFA80377 for ; Sat, 12 Jun 2021 20:34:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x231.google.com with SMTP id a26so9617085oie.11 for ; Sat, 12 Jun 2021 11:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UtN95aQ9fHxz0bz5TqecdqyrJVUMAlJm9faME5wurPk=; b=IaBG7HV3qJI+A3PdYZ8OJpFF7NovsbStbcAsCbrLZgloviQ9jv83Cg3shKLoUbMs01 708LujX7MWZ8ogK3Xh64UYwMtT4yZHTz+oPOsF/76gE4BZk+jDI7hWd7zwENd2VhM+71 Mu4LjfSIEZ/lSZZLDOTg9HCmf1JxFo+YTHyyaMPtVNUyz7wLM8YxE0UElqgojyeQvy28 MBOdDC7X5MsnRMQILMJ9Nd2FlOecSidx7stPKRGpNvDSV0vW2QManTQFVrVVNkgADllQ 1XsUpUNGI3IBlZMo7t/unCexJftJ/AcNTMcKRzCZlltKc8KSVDkXLZXppgxVhubXczbK WJZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UtN95aQ9fHxz0bz5TqecdqyrJVUMAlJm9faME5wurPk=; b=feO/8z8/8UX6+jMhGHjYpYJS0trCitvyz1AtT3YyrC0xlc0i0e1zk6GdQNyeU0QYss /f3Wf0coubwpsG+ZleUyOzOOT8jcTydW0aEAw4mcz6TeD2andAEINhFmYbLmjiK2JjeR mWGXr0dsC2Dwq2tubYQUfBqPWf+totN6v5vy346djzmRlpqr6f7JITKZ2lNnTwh/Ta9/ QieeK9Q4wSrPtPFKbjixAATdQ5nn0WsAHt+z7Ah9SSVWvDHU05D00rXAog9d8cukiVft ZJjKVQpbXz8Ko6/7bj+uQf5FlRrp/RBlwojJwJhJqUXfr1a8cvwhuBUdvv4y3vJDykbN 0SxA== X-Gm-Message-State: AOAM5303WvhhHdvjFPbBfE8HBvMXkODTzJl5KCJ4o5Hmz779s9niZ4a+ LPAHhKOVvfRbmLNlMUfekOarizEM7cfCOIbkXUU= X-Google-Smtp-Source: ABdhPJz1uTZNoBXMgtGrMbxykBRrrJuOh3X0efTSGNUe3tMEHC1g24x45xTccUqKJmvJR+nAbLdz/3XP+kMePNg5s/s= X-Received: by 2002:aca:3b09:: with SMTP id i9mr6788120oia.92.1623522870045; Sat, 12 Jun 2021 11:34:30 -0700 (PDT) MIME-Version: 1.0 References: <20210530133409.1669336-1-daniil.stas@posteo.net> In-Reply-To: <20210530133409.1669336-1-daniil.stas@posteo.net> From: Ramon Fried Date: Sat, 12 Jun 2021 21:34:19 +0300 Message-ID: Subject: Re: [PATCH] net: dwc_eth_qos: Revert some changes of commit 3a97da12ee7b To: Daniil Stas Cc: U-Boot Mailing List , Ye Li , Fugang Duan , Peng Fan , Joe Hershberger , Patrice Chotard , Patrick Delaunay Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, May 30, 2021 at 4:28 PM Daniil Stas wrote: > > Revert some changes of commit 3a97da12ee7b ("net: dwc_eth_qos: add dwc > eqos for imx support") that were probably added by mistake. > > One of these changes can lead to received data corruption (enabling > FUP and FEP bits). Another causes invalid register rxq_ctrl0 settings > for some platforms. And another makes some writes at unknown memory > location. > > Fixes: 3a97da12ee7b ("net: dwc_eth_qos: add dwc eqos for imx support") > Signed-off-by: Daniil Stas > Cc: Ye Li > Cc: Fugang Duan > Cc: Peng Fan > Cc: Ramon Fried > Cc: Joe Hershberger > Cc: Patrice Chotard > Cc: Patrick Delaunay > --- > drivers/net/dwc_eth_qos.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > index 2f088c758f..b012bed517 100644 > --- a/drivers/net/dwc_eth_qos.c > +++ b/drivers/net/dwc_eth_qos.c > @@ -172,8 +172,6 @@ struct eqos_mtl_regs { > #define EQOS_MTL_RXQ0_OPERATION_MODE_RFA_MASK 0x3f > #define EQOS_MTL_RXQ0_OPERATION_MODE_EHFC BIT(7) > #define EQOS_MTL_RXQ0_OPERATION_MODE_RSF BIT(5) > -#define EQOS_MTL_RXQ0_OPERATION_MODE_FEP BIT(4) > -#define EQOS_MTL_RXQ0_OPERATION_MODE_FUP BIT(3) > > #define EQOS_MTL_RXQ0_DEBUG_PRXQ_SHIFT 16 > #define EQOS_MTL_RXQ0_DEBUG_PRXQ_MASK 0x7fff > @@ -1222,7 +1220,6 @@ static int eqos_start(struct udevice *dev) > } > > /* Configure MTL */ > - writel(0x60, &eqos->mtl_regs->txq0_quantum_weight - 0x100); > > /* Enable Store and Forward mode for TX */ > /* Program Tx operating mode */ > @@ -1236,9 +1233,7 @@ static int eqos_start(struct udevice *dev) > > /* Enable Store and Forward mode for RX, since no jumbo frame */ > setbits_le32(&eqos->mtl_regs->rxq0_operation_mode, > - EQOS_MTL_RXQ0_OPERATION_MODE_RSF | > - EQOS_MTL_RXQ0_OPERATION_MODE_FEP | > - EQOS_MTL_RXQ0_OPERATION_MODE_FUP); > + EQOS_MTL_RXQ0_OPERATION_MODE_RSF); > > /* Transmit/Receive queue fifo size; use all RAM for 1 queue */ > val = readl(&eqos->mac_regs->hw_feature1); > @@ -1314,12 +1309,6 @@ static int eqos_start(struct udevice *dev) > eqos->config->config_mac << > EQOS_MAC_RXQ_CTRL0_RXQ0EN_SHIFT); > > - clrsetbits_le32(&eqos->mac_regs->rxq_ctrl0, > - EQOS_MAC_RXQ_CTRL0_RXQ0EN_MASK << > - EQOS_MAC_RXQ_CTRL0_RXQ0EN_SHIFT, > - 0x2 << > - EQOS_MAC_RXQ_CTRL0_RXQ0EN_SHIFT); > - > /* Multicast and Broadcast Queue Enable */ > setbits_le32(&eqos->mac_regs->unused_0a4, > 0x00100000); > -- > 2.31.1 > Reviewed-by: Ramon Fried