From: Ramon Fried <rfried.dev@gmail.com>
To: Tim Harvey <tharvey@gateworks.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Joe Hershberger <joe.hershberger@ni.com>,
Stefan Roese <sr@denx.de>, Marek Vasut <marex@denx.de>
Subject: Re: [PATCH v2] cmd: net: add a 'net list' command to list network devs
Date: Mon, 14 Jun 2021 20:04:36 +0300 [thread overview]
Message-ID: <CAGi-RU+pG3=hHwKCLfx==7i7RA+PrZ3M6rsAe7Q57OjKbodERA@mail.gmail.com> (raw)
In-Reply-To: <CAJ+vNU2xLHcG3H8z7WbFMfkwAuchSjA6cLCGX_a-gmP7pnR=XQ@mail.gmail.com>
On Mon, Jun 14, 2021 at 6:36 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Sat, Jun 12, 2021 at 12:02 PM Ramon Fried <rfried.dev@gmail.com> wrote:
> >
> > Hi Tim.
> > The patch fails build in several boards (Malta variants):
> >
> > +cmd/net.c: In function 'do_net_list':
> > 42+cmd/net.c:487:34: error: initialization of 'const struct udevice *'
> > from incompatible pointer type 'struct eth_device *'
> > [-Werror=incompatible-pointer-types]
> > 43+ 487 | const struct udevice *current = eth_get_dev();
> > 44+ | ^~~~~~~~~~~
> >
>
> Ramon,
>
> Looks like my patch only works for DM_ETH. If I were to implement this
> for legacy eth it would probably be a mess as the device list is a
> static struct in net/eth_legacy.c. I'm not sure how to tell how many
> boards are out there that are not yet converted to DM_ETH and am not
> sure when legacy eth goes away. How about if I just add #ifdef
> CONFIG_DM_ETH around the whole thing and it isn't supported for legacy
> eth?
>
> Best Regards,
>
> Tim
Sounds good to me.
prev parent reply other threads:[~2021-06-14 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 19:52 [PATCH v2] cmd: net: add a 'net list' command to list network devs Tim Harvey
2021-06-12 18:26 ` Ramon Fried
2021-06-12 19:01 ` Ramon Fried
2021-06-14 15:36 ` Tim Harvey
2021-06-14 17:04 ` Ramon Fried [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGi-RU+pG3=hHwKCLfx==7i7RA+PrZ3M6rsAe7Q57OjKbodERA@mail.gmail.com' \
--to=rfried.dev@gmail.com \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=sr@denx.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.