* [PATCH] toshiba_acpi: Initialize hotkey_event_type variable
@ 2015-11-02 2:30 Azael Avalos
2015-11-04 0:44 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Azael Avalos @ 2015-11-02 2:30 UTC (permalink / raw
To: Darren Hart, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Azael Avalos, stable
Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
toshiba models") fixed an issue on some laptops regarding hotkeys
registration, however, if failed to address the initialization of the
hotkey_event_type variable, and thus, it can lead to potential
unwanted effects as the variable is being checked.
This patch initializes such variable to avoid such unwanted effects.
Cc: <stable@vger.kernel.org> # 4.1+
Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
Darren,
Sorry for sending this patch this late, I had a really busy week :-(
drivers/platform/x86/toshiba_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index beb709f..c013029 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
ret = toshiba_function_keys_get(dev, &dev->special_functions);
dev->kbd_function_keys_supported = !ret;
+ dev->hotkey_event_type = 0;
if (toshiba_acpi_setup_keyboard(dev))
pr_info("Unable to activate hotkeys\n");
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable
2015-11-02 2:30 [PATCH] toshiba_acpi: Initialize hotkey_event_type variable Azael Avalos
@ 2015-11-04 0:44 ` Darren Hart
2015-11-04 16:07 ` Azael Avalos
0 siblings, 1 reply; 3+ messages in thread
From: Darren Hart @ 2015-11-04 0:44 UTC (permalink / raw
To: Azael Avalos
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
stable
On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote:
> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
> toshiba models") fixed an issue on some laptops regarding hotkeys
> registration, however, if failed to address the initialization of the
> hotkey_event_type variable, and thus, it can lead to potential
> unwanted effects as the variable is being checked.
>
> This patch initializes such variable to avoid such unwanted effects.
>
> Cc: <stable@vger.kernel.org> # 4.1+
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> Darren,
>
> Sorry for sending this patch this late, I had a really busy week :-(
It's a trivial patch, so I'm not concerned with the timing. Thanks for getting
it out!
Unfortunately, it doesn't apply and appears to be whitespace mangled. Checkpatch
complains and tabs appear to have been replaced with spaces. Please check your
send mail mechanism and resend - possibly using git-send-email or something like
mutt -H PATCHNAME. Try sending to yourself first and verifying you can apply it.
Thanks,
>
> drivers/platform/x86/toshiba_acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c
> b/drivers/platform/x86/toshiba_acpi.c
> index beb709f..c013029 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
> ret = toshiba_function_keys_get(dev, &dev->special_functions);
> dev->kbd_function_keys_supported = !ret;
>
> + dev->hotkey_event_type = 0;
> if (toshiba_acpi_setup_keyboard(dev))
> pr_info("Unable to activate hotkeys\n");
>
> --
> 2.6.2
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable
2015-11-04 0:44 ` Darren Hart
@ 2015-11-04 16:07 ` Azael Avalos
0 siblings, 0 replies; 3+ messages in thread
From: Azael Avalos @ 2015-11-04 16:07 UTC (permalink / raw
To: Darren Hart
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
stable
Hi Darren,
2015-11-03 17:44 GMT-07:00 Darren Hart <dvhart@infradead.org>:
> On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote:
>> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
>> toshiba models") fixed an issue on some laptops regarding hotkeys
>> registration, however, if failed to address the initialization of the
>> hotkey_event_type variable, and thus, it can lead to potential
>> unwanted effects as the variable is being checked.
>>
>> This patch initializes such variable to avoid such unwanted effects.
>>
>> Cc: <stable@vger.kernel.org> # 4.1+
>> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
>> ---
>> Darren,
>>
>> Sorry for sending this patch this late, I had a really busy week :-(
>
> It's a trivial patch, so I'm not concerned with the timing. Thanks for getting
> it out!
>
> Unfortunately, it doesn't apply and appears to be whitespace mangled. Checkpatch
> complains and tabs appear to have been replaced with spaces. Please check your
> send mail mechanism and resend - possibly using git-send-email or something like
> mutt -H PATCHNAME. Try sending to yourself first and verifying you can apply it.
Ughh, sorry about this, I sent this email directly instead of git-send-email,
so the copy-paste might have changed something.
The version of git I'm currently using parses the stable address as
stable@vger.kernel.org#4.1+ and gsmtp complains about a malformed address...
I'll try to resend this patch ASAP.
>
> Thanks,
>
Cheers
Azael
--
-- El mundo apesta y vosotros apestais tambien --
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-04 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-02 2:30 [PATCH] toshiba_acpi: Initialize hotkey_event_type variable Azael Avalos
2015-11-04 0:44 ` Darren Hart
2015-11-04 16:07 ` Azael Avalos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.