From: Axel Lin <axel.lin@ingics.com>
To: Chen Feng <puck.chen@hisilicon.com>, Fei Wang <w.f@huawei.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Hao Fang <fanghao11@huawei.com>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: regulator: Question about hi655x ldo19 voltage table
Date: Sat, 12 Jun 2021 23:52:43 +0800 [thread overview]
Message-ID: <CAFRkauAcKy_h77UXuMGMM8KKsivcccVScBm-Xwu0Oc7ne4Wtkw@mail.gmail.com> (raw)
Hi,
Current code has below voltage table for ldo19:
static const unsigned int ldo19_voltages[] = {
1800000, 1850000, 1900000, 1750000,
2800000, 2850000, 2900000, 3000000,
};
The 1750000 looks unusual but I cannot find the datasheet to confirm it.
I found in the initial version of the patch submission, it has below
regulator-vset-table [1]
+ ldo19: regulator@a38 {
+ compatible = "hisilicon,hi655x-regulator-pmic";
+ regulator-name = "ldo19";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-initial-mode = <0x02>;
+ regulator-off-on-delay = <360>;
+ regulator-ctrl-regs = <0x02f 0x030 0x031>;
+ regulator-ctrl-mask = <0x2>;
+ regulator-vset-regs = <0x084>;
+ regulator-vset-mask = <0x3>;
+ regulator-n-vol = <8>;
+ regulator-vset-table = <1800000>,<1850000>,
+ <1900000>,<2750000>,
+ <2800000>,<2850000>,
+ <2900000>,<3000000>;
So I'm wondering if the 1750000 is a typo? (should be 2750000).
Can someone help to confirm this?
[1] https://lore.kernel.org/patchwork/patch/615156/
reply other threads:[~2021-06-12 15:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFRkauAcKy_h77UXuMGMM8KKsivcccVScBm-Xwu0Oc7ne4Wtkw@mail.gmail.com \
--to=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=fanghao11@huawei.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=w.f@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.