* [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15
@ 2023-06-20 13:46 Richard Henderson
2023-06-20 13:49 ` Richard Henderson
2023-06-23 10:40 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2023-06-20 13:46 UTC (permalink / raw
To: qemu-devel; +Cc: qemu-arm, Mark Rutland, Alex Bennée
Brown bag time: store instead of load results in uninitialized temp.
Reported-by: Mark Rutland <mark.rutland@arm.com>
Fixes: e6dd5e782be ("target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r")
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/translate-sve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index ff050626e6..225d358922 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4329,7 +4329,7 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs,
/* Predicate register stores can be any multiple of 2. */
if (len_remain >= 8) {
t0 = tcg_temp_new_i64();
- tcg_gen_st_i64(t0, base, vofs + len_align);
+ tcg_gen_ld_i64(t0, base, vofs + len_align);
tcg_gen_qemu_st_i64(t0, clean_addr, midx, MO_LEUQ | MO_ATOM_NONE);
len_remain -= 8;
len_align += 8;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15
2023-06-20 13:46 [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15 Richard Henderson
@ 2023-06-20 13:49 ` Richard Henderson
2023-06-23 10:40 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-06-20 13:49 UTC (permalink / raw
To: qemu-devel; +Cc: qemu-arm, Mark Rutland, Alex Bennée
On 6/20/23 15:46, Richard Henderson wrote:
> Brown bag time: store instead of load results in uninitialized temp.
>
> Reported-by: Mark Rutland<mark.rutland@arm.com>
> Fixes: e6dd5e782be ("target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r")
> Tested-by: Alex Bennée<alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson<richard.henderson@linaro.org>
> ---
> target/arm/tcg/translate-sve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1704
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15
2023-06-20 13:46 [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15 Richard Henderson
2023-06-20 13:49 ` Richard Henderson
@ 2023-06-23 10:40 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-06-23 10:40 UTC (permalink / raw
To: Richard Henderson; +Cc: qemu-devel, qemu-arm, Mark Rutland, Alex Bennée
On Tue, 20 Jun 2023 at 14:47, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Brown bag time: store instead of load results in uninitialized temp.
>
> Reported-by: Mark Rutland <mark.rutland@arm.com>
> Fixes: e6dd5e782be ("target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r")
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> --
Applied to target-arm.next (with the subject message typo
fixed and the Resolves: line added), thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-23 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 13:46 [PATCH] target/arm: Fix sve prediate store, 8 <= VQ <= 15 Richard Henderson
2023-06-20 13:49 ` Richard Henderson
2023-06-23 10:40 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.