From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8730BC48BDF for ; Tue, 15 Jun 2021 09:23:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36A596142E for ; Tue, 15 Jun 2021 09:23:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A596142E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lt5Hf-0003vG-28 for qemu-devel@archiver.kernel.org; Tue, 15 Jun 2021 05:22:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lt5G0-0002tk-Pe for qemu-devel@nongnu.org; Tue, 15 Jun 2021 05:21:16 -0400 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:39527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lt5Ft-0001xM-3g for qemu-devel@nongnu.org; Tue, 15 Jun 2021 05:21:16 -0400 Received: by mail-ed1-x529.google.com with SMTP id dj8so50122308edb.6 for ; Tue, 15 Jun 2021 02:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vanXQharyz7xIFSnoYJr8DMwoWsFpk2t3JK+LO7FrWU=; b=effw0CoixyZfBeHM0B5I5XFZGrdgEh9C4mwse5hvdpBcmom8ekNVvQObVTGP59Gdp/ m7iFzK0e+CU0A9LAapdWDJA/9gogj0h5vyPBaKTOJMHJZDlk6B5k6U0t5o3V/RW6RSAm aqeAp+nHq2t1cojNbpW2PRQbNY39qLMN7Tm7CIV+RnsupQSOwKFBL3auEhLzoNcVnpMn de0uXPnNRT7whoDhoMQsDOCMzowKodoJdTIeXEqJ3V/xCB3xi62hUIRoDv6UlyVBSVGA 1TdfYwI+GIvxb4PGqGCuUU12Hqol7oe00vNFgYsSx9o/bKjZvvju9ZF07gP7rM6u9tov h+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vanXQharyz7xIFSnoYJr8DMwoWsFpk2t3JK+LO7FrWU=; b=RwAjW0bYbaSo3klSavLjxSC20eH47kUhQCtb2bUU7ReOpAuMj0tZvMKXX1QNND4ME7 qf6Nhf1nz3EN2zEAcKrBGJvPzhHSnoAPmr9jqAWFCeq2u0LNvYjibk0DK00rmw4asm/0 4UAx1QfTvQTpAg4ggKwPbOQhV1dcSp2j2ERFOnCelWK3OgI8Dr6o7W23Cyc9QKhxOY3b r/YfeZ20meMC2GgtujgabUW4TuFgi8RWPEfeWkvFW3RzUnXjraEJWxcVc+0gmF6s5Hoe id/QV8mgMNkoVQ5EbCwwlPPuVshPLPihQcHqQaIHdzqBoVp10zHdYtGI01j6659glNSd 0sDg== X-Gm-Message-State: AOAM530HJ9FRMpL0tdZOoSv+ccOxuKPT8x17umqCm9vPGAe0LI131HKu Vz1vOfHvU0Hnw9gJnzOQqbg1YsCEulYF9oVrRTUQuQidG+E= X-Google-Smtp-Source: ABdhPJwG+/st6fLD2cH8dAEUDQuLcQxA0jMaePXPvXgP7vkNw0LUMgx934E5I2tI+24Mhg6EJJmZOEGrnhKPZdd1874= X-Received: by 2002:aa7:d755:: with SMTP id a21mr22325543eds.146.1623748867604; Tue, 15 Jun 2021 02:21:07 -0700 (PDT) MIME-Version: 1.0 References: <20210612195707.840217-1-richard.henderson@linaro.org> In-Reply-To: <20210612195707.840217-1-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 15 Jun 2021 10:20:33 +0100 Message-ID: Subject: Re: [PATCH] target/arm: Fix mte page crossing test To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Collingbourne , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 12 Jun 2021 at 20:57, Richard Henderson wrote: > > The test was off-by-one, because tag_last points to the > last byte of the tag to check, thus tag_last - prev_page > will equal TARGET_PAGE_SIZE when we use the first byte > of the next page. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/403 > Reported-by: Peter Collingbourne > Signed-off-by: Richard Henderson Applied to target-arm.next, thanks. -- PMM