From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
oss-drivers@netronome.com, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH bpf-next] tools: bpftool: fix warning on ignored return value for 'read'
Date: Wed, 20 Nov 2019 10:14:43 -0800 [thread overview]
Message-ID: <CAEf4BzYG=wFMJ_0RdLF53qhzpKWFf4jgM1r3b6sHoiTqgSE8Ew@mail.gmail.com> (raw)
In-Reply-To: <20191119111706.22440-1-quentin.monnet@netronome.com>
On Tue, Nov 19, 2019 at 3:18 AM Quentin Monnet
<quentin.monnet@netronome.com> wrote:
>
> When building bpftool, a warning was introduced by commit a94364603610
> ("bpftool: Allow to read btf as raw data"), because the return value
> from a call to 'read()' is ignored. Let's address it.
>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/bpf/bpftool/btf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
[...]
next prev parent reply other threads:[~2019-11-20 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:17 [PATCH bpf-next] tools: bpftool: fix warning on ignored return value for 'read' Quentin Monnet
2019-11-20 18:14 ` Andrii Nakryiko [this message]
2019-11-21 8:48 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYG=wFMJ_0RdLF53qhzpKWFf4jgM1r3b6sHoiTqgSE8Ew@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.