From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD106C48BE5 for ; Sat, 12 Jun 2021 13:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 999DA610A0 for ; Sat, 12 Jun 2021 13:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbhFLNfI (ORCPT ); Sat, 12 Jun 2021 09:35:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbhFLNfH (ORCPT ); Sat, 12 Jun 2021 09:35:07 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB318C061574 for ; Sat, 12 Jun 2021 06:33:07 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id w31so2305026pga.6 for ; Sat, 12 Jun 2021 06:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=kkOz4/i5zkzyVPTKWg39IK/HWEgMrL9zXxvikEQEVTtUod29kMfdGqcWoaDfyCMlYO OQQzJd/J0+23gs9/NKFipZlTk7Awviicwc2aCgNFt43XfQn/190dgYrIqE4v9IagCIOK AwylwXL6JLY1AEl3UQ4u0Q99u/mp6UnNG/CNKZn413JQi2HIOGBCeaH56eta+G5OswqZ 5JGpJQ/oI3B+6RAGYxenCw1WINzPe1TCHScNqR2ORfJnSv88WyWJ7JRIB0HXnXVmJrpS 147Dit7Bviiwba3DqlBce9NWwQ3PJEg7ZvZLOThgLuo+Y7j+yo///3L8hmCEShi06tkL /q5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=Tdae9SH1Bs3Kl5PIu8OCjOqo54+0jRNPuLVJ5GMzsanGJ3wBkMAn/SD5fZBmGtK7Xt q3SeUp6Nw3hQZdAW9bDJRdQCM4ugE1yKo8bqlsjtwN5PzAHV/JveSnmhuv/5yAEx1hrT CuLQCXEKQAek0YsZgScFbzUpuJgJGx6bLJb1MDlqrp5v4hFaPG1zfuxNIuxzowVS6QXN ZBFieiy4Hok5wEn87LpdBWJpVLp4PPTAHdMIlgSTZiQTe2Q1h5iR61PnJRuFXm41Of6K iW3/8mhzC7oH7T+PxpgTQDB9/OArWtu6TIuWfLNEtrbktvVXSRVYZ6sIR1Tku9YifHaV 0XVQ== X-Gm-Message-State: AOAM532u7hgwKgHe6fYY5RkYBbw89SbrvbcEjoarj6NVwmk9J9dGpVcU f7zJT41z2bLhW+4z+5tPMmiyYNGyVSQn3xrUa1w= X-Google-Smtp-Source: ABdhPJzaXwq+agQL2AlHlBr3G1cfDRdHqcnICZBjnuHuO89La+HnzeFKLp339if3uODrOsoOoDvF9lUXeGMayXlPRYE= X-Received: by 2002:a63:f815:: with SMTP id n21mr8634604pgh.2.1623504785601; Sat, 12 Jun 2021 06:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20210612110014.GA1211@raspberrypi> <87eed7tk24.wl-maz@kernel.org> In-Reply-To: <87eed7tk24.wl-maz@kernel.org> From: Austin Kim Date: Sat, 12 Jun 2021 22:32:54 +0900 Message-ID: Subject: Re: [PATCH] KVM: arm64: vgic: declear local variable 'flags' before for loop starts To: Marc Zyngier Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Linux Kernel Mailing List , =?UTF-8?B?6rmA64+Z7ZiE?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2021=EB=85=84 6=EC=9B=94 12=EC=9D=BC (=ED=86=A0) =EC=98=A4=ED=9B=84 8:10, M= arc Zyngier =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Sat, 12 Jun 2021 12:00:14 +0100, > Austin Kim wrote: > > > > From: Austin Kim > > > > Normally local variable 'flags' is defined out of for loop, > > when 'flags' is used as the second parameter in a call to > > spinlock_irq[save/restore] function. > > > > So it had better declear local variable 'flags' ahead of for loop. > > Why better? Reducing the scope of a variable is in general good > practice. Do you see any material advantage in moving this variable > out of the loop? Does the compiler generate better code? First all of, thanks for feedback. I checked how the compiler generate assembly code(before/after) using objdump utility. And then found out that compiler generates the same assembly code. ffff80001005f5c8 : ffff80001005f5c8: d503233f paciasp ... ffff80001005f63c: 97ffe9af bl ffff800010059cf8 ffff80001005f640: aa0003f3 mov x19, x0 ffff80001005f644: 943886c3 bl ffff800010e81150 <_raw_spin_lock_irqsav= e> Let me keep in mind how compiler generate assembly code with new patch, which leads to material advantage. BR, Austin Kim > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308C2C48BE5 for ; Sat, 12 Jun 2021 13:34:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D965761376 for ; Sat, 12 Jun 2021 13:34:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D965761376 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8bcjslGtDDSPTMtRcusuyMLypiIB1HCXwf1Bkh8ynzQ=; b=whP//wmtFngukT hXTB7MMAoifQsrv4nPR99Wzn/5nAmWFQPzZQ62WJh+s2pZ6rtom3rMqgmWulNYjSX/ojlwnXkCFD/ +7W8kqKdXrgF/l5oT5+9AM6ermTIrNNEO8vKq6xte4+r+RIFAb6ocave8gkqcKUC5y+G2rKSJoaSQ e8Fs0p8j3kBD9pHYWAvdZmjYzQaJzP3gW8uiRXflqUoq+v6xWtJQzzcSFc6PtnH1veUSvGzPwmhPZ /te7aSA9LOo27X0Suo1bLB9wHDkCagQ9Gjqnp56HE9HqD3dRBhogUvxZXwu5dk8PrMrq+2vvsEu/w ZLQDUREPyHx0MoGq/24w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls3lA-008aJW-Pd; Sat, 12 Jun 2021 13:33:12 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls3l7-008aIk-Jc for linux-arm-kernel@lists.infradead.org; Sat, 12 Jun 2021 13:33:11 +0000 Received: by mail-pg1-x534.google.com with SMTP id e33so86458pgm.3 for ; Sat, 12 Jun 2021 06:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=kkOz4/i5zkzyVPTKWg39IK/HWEgMrL9zXxvikEQEVTtUod29kMfdGqcWoaDfyCMlYO OQQzJd/J0+23gs9/NKFipZlTk7Awviicwc2aCgNFt43XfQn/190dgYrIqE4v9IagCIOK AwylwXL6JLY1AEl3UQ4u0Q99u/mp6UnNG/CNKZn413JQi2HIOGBCeaH56eta+G5OswqZ 5JGpJQ/oI3B+6RAGYxenCw1WINzPe1TCHScNqR2ORfJnSv88WyWJ7JRIB0HXnXVmJrpS 147Dit7Bviiwba3DqlBce9NWwQ3PJEg7ZvZLOThgLuo+Y7j+yo///3L8hmCEShi06tkL /q5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=VoQ/9K+75oHzR6zlZm3vKpxMj/ykoYxvNBg0l4blm5yYcO6w1TPoZs8smm9zVbFwhz OIWORA7kKEsvvHW/R0DtouNctQUp1/i63rBgYHUmen6Gg0APAV066xDQJ1uOmyvkmwDK wnuIV6kCJdnDQtyULCe0+b5aEvvuIp2D+UAlR94+rkjCAlciq4SYBZGyapyrn5bV5Vut 5J5tdKW522MOYnP2eLiT252yayjK+VN2cP9IQfCj2gdJgqgDE+TSdTBmOj/n83MAEDZb SDdZN4Ulk3+dfKxdpG1LZcGM9M2suIe5EgYB/bU03iT/ICLDHGpUAR0hS3lWK+JE5vYR nXXQ== X-Gm-Message-State: AOAM530Vn67zHOh/qU5G4w1nsfJ7f0rMOEr2vwmE2uPd7wZAFNkyX29k JHshFhA6ELgCXZmC7hU6s/8w2Z4z092YD2cXD5J1uheQWSx/Fi/J X-Google-Smtp-Source: ABdhPJzaXwq+agQL2AlHlBr3G1cfDRdHqcnICZBjnuHuO89La+HnzeFKLp339if3uODrOsoOoDvF9lUXeGMayXlPRYE= X-Received: by 2002:a63:f815:: with SMTP id n21mr8634604pgh.2.1623504785601; Sat, 12 Jun 2021 06:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20210612110014.GA1211@raspberrypi> <87eed7tk24.wl-maz@kernel.org> In-Reply-To: <87eed7tk24.wl-maz@kernel.org> From: Austin Kim Date: Sat, 12 Jun 2021 22:32:54 +0900 Message-ID: Subject: Re: [PATCH] KVM: arm64: vgic: declear local variable 'flags' before for loop starts To: Marc Zyngier Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Linux Kernel Mailing List , =?UTF-8?B?6rmA64+Z7ZiE?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210612_063309_673743_F0015927 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjAyMeuFhCA27JuUIDEy7J28ICjthqApIOyYpO2bhCA4OjEwLCBNYXJjIFp5bmdpZXIgPG1hekBr ZXJuZWwub3JnPuuLmOydtCDsnpHshLE6Cj4KPiBPbiBTYXQsIDEyIEp1biAyMDIxIDEyOjAwOjE0 ICswMTAwLAo+IEF1c3RpbiBLaW0gPGF1c3RpbmRoLmtpbUBnbWFpbC5jb20+IHdyb3RlOgo+ID4K PiA+IEZyb206IEF1c3RpbiBLaW0gPGF1c3Rpbi5raW1AbGdlLmNvbT4KPiA+Cj4gPiBOb3JtYWxs eSBsb2NhbCB2YXJpYWJsZSAnZmxhZ3MnIGlzIGRlZmluZWQgb3V0IG9mIGZvciBsb29wLAo+ID4g d2hlbiAnZmxhZ3MnIGlzIHVzZWQgYXMgdGhlIHNlY29uZCBwYXJhbWV0ZXIgaW4gYSBjYWxsIHRv Cj4gPiBzcGlubG9ja19pcnFbc2F2ZS9yZXN0b3JlXSBmdW5jdGlvbi4KPiA+Cj4gPiBTbyBpdCBo YWQgYmV0dGVyIGRlY2xlYXIgbG9jYWwgdmFyaWFibGUgJ2ZsYWdzJyBhaGVhZCBvZiBmb3IgbG9v cC4KPgo+IFdoeSBiZXR0ZXI/IFJlZHVjaW5nIHRoZSBzY29wZSBvZiBhIHZhcmlhYmxlIGlzIGlu IGdlbmVyYWwgZ29vZAo+IHByYWN0aWNlLiBEbyB5b3Ugc2VlIGFueSBtYXRlcmlhbCBhZHZhbnRh Z2UgaW4gbW92aW5nIHRoaXMgdmFyaWFibGUKPiBvdXQgb2YgdGhlIGxvb3A/IERvZXMgdGhlIGNv bXBpbGVyIGdlbmVyYXRlIGJldHRlciBjb2RlPwoKRmlyc3QgYWxsIG9mLCB0aGFua3MgZm9yIGZl ZWRiYWNrLgoKSSBjaGVja2VkIGhvdyB0aGUgY29tcGlsZXIgZ2VuZXJhdGUgYXNzZW1ibHkgY29k ZShiZWZvcmUvYWZ0ZXIpIHVzaW5nCm9iamR1bXAgdXRpbGl0eS4KQW5kIHRoZW4gZm91bmQgb3V0 IHRoYXQgY29tcGlsZXIgZ2VuZXJhdGVzIHRoZSBzYW1lIGFzc2VtYmx5IGNvZGUuCgo8Y29tcGls ZXIgdmVyc2lvbjogZ2NjLWxpbmFyby03LjUuMC0yMDE5LjEyLXg4Nl82NF9hYXJjaDY0PgoKZmZm ZjgwMDAxMDA1ZjVjOCA8dmdpY19tbWlvX3JlYWRfcGVuZGluZz46CmZmZmY4MDAwMTAwNWY1Yzg6 ICAgZDUwMzIzM2YgICAgcGFjaWFzcAouLi4KZmZmZjgwMDAxMDA1ZjYzYzogICA5N2ZmZTlhZiAg ICBibCAgZmZmZjgwMDAxMDA1OWNmOCA8dmdpY19nZXRfaXJxPgpmZmZmODAwMDEwMDVmNjQwOiAg IGFhMDAwM2YzICAgIG1vdiB4MTksIHgwCmZmZmY4MDAwMTAwNWY2NDQ6ICAgOTQzODg2YzMgICAg YmwgIGZmZmY4MDAwMTBlODExNTAgPF9yYXdfc3Bpbl9sb2NrX2lycXNhdmU+CgpMZXQgbWUga2Vl cCBpbiBtaW5kIGhvdyBjb21waWxlciBnZW5lcmF0ZSBhc3NlbWJseSBjb2RlIHdpdGggbmV3IHBh dGNoLAp3aGljaCBsZWFkcyB0byBtYXRlcmlhbCBhZHZhbnRhZ2UuCgpCUiwKQXVzdGluIEtpbQoK Pgo+IFRoYW5rcywKPgo+ICAgICAgICAgTS4KPgo+IC0tCj4gV2l0aG91dCBkZXZpYXRpb24gZnJv bSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F30C48BE5 for ; Sat, 12 Jun 2021 13:40:05 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 398A76138C for ; Sat, 12 Jun 2021 13:40:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 398A76138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 98C9249D50; Sat, 12 Jun 2021 09:40:04 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@gmail.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xH8aGOFm00Ss; Sat, 12 Jun 2021 09:40:02 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9695F40874; Sat, 12 Jun 2021 09:40:02 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D3CCB4086D for ; Sat, 12 Jun 2021 09:33:08 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 58hh6Z87pJF5 for ; Sat, 12 Jun 2021 09:33:06 -0400 (EDT) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9C32D40630 for ; Sat, 12 Jun 2021 09:33:06 -0400 (EDT) Received: by mail-pf1-f182.google.com with SMTP id k15so6806129pfp.6 for ; Sat, 12 Jun 2021 06:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=kkOz4/i5zkzyVPTKWg39IK/HWEgMrL9zXxvikEQEVTtUod29kMfdGqcWoaDfyCMlYO OQQzJd/J0+23gs9/NKFipZlTk7Awviicwc2aCgNFt43XfQn/190dgYrIqE4v9IagCIOK AwylwXL6JLY1AEl3UQ4u0Q99u/mp6UnNG/CNKZn413JQi2HIOGBCeaH56eta+G5OswqZ 5JGpJQ/oI3B+6RAGYxenCw1WINzPe1TCHScNqR2ORfJnSv88WyWJ7JRIB0HXnXVmJrpS 147Dit7Bviiwba3DqlBce9NWwQ3PJEg7ZvZLOThgLuo+Y7j+yo///3L8hmCEShi06tkL /q5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3wRiFAQA4e7Yl+ksEnUziylD3jK+gtjCHkmYNeOuE6c=; b=NmLrOhBwnkpS/SBKOnoq6547X98/Pggsju48BU6L7LiEq7XyUCGKSS5WFAw2T1XkCk scHc2SO14pbgc/oO9wZQUfLlby81TmHgLhDYUtdpnCdu50TMrP5maT+FXGSWOA4lhKxI 90LbIpF5qwr0ben30tUCn/dBIg6R9KbaQ+yLAojdUPGAwt/+rTsaXfDT5F/2bWIfD8SP gF38mMPn3hjDObKm4E7YdL22OZtJHztJOwfYCDi6FTybBoBp26K/1387aZ2q31W79gb/ lt1gCW0Vkn9LPBfld54/H7Kal2S8TOc4wODZJaWlkV7c+9wMgLAV2bx3E94NQwx9DiuR ynkA== X-Gm-Message-State: AOAM532mWFfD7PPN3JkDNdcf93oyBdwu3Jc1hsY2Ud+SxA02pJMuPkrS EkWadICnxN12Qz3x9Bvq9EktPjryxPd4ZFDDtp0= X-Google-Smtp-Source: ABdhPJzaXwq+agQL2AlHlBr3G1cfDRdHqcnICZBjnuHuO89La+HnzeFKLp339if3uODrOsoOoDvF9lUXeGMayXlPRYE= X-Received: by 2002:a63:f815:: with SMTP id n21mr8634604pgh.2.1623504785601; Sat, 12 Jun 2021 06:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20210612110014.GA1211@raspberrypi> <87eed7tk24.wl-maz@kernel.org> In-Reply-To: <87eed7tk24.wl-maz@kernel.org> From: Austin Kim Date: Sat, 12 Jun 2021 22:32:54 +0900 Message-ID: Subject: Re: [PATCH] KVM: arm64: vgic: declear local variable 'flags' before for loop starts To: Marc Zyngier X-Mailman-Approved-At: Sat, 12 Jun 2021 09:40:02 -0400 Cc: will@kernel.org, catalin.marinas@arm.com, Linux Kernel Mailing List , =?UTF-8?B?6rmA64+Z7ZiE?= , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu MjAyMeuFhCA27JuUIDEy7J28ICjthqApIOyYpO2bhCA4OjEwLCBNYXJjIFp5bmdpZXIgPG1hekBr ZXJuZWwub3JnPuuLmOydtCDsnpHshLE6Cj4KPiBPbiBTYXQsIDEyIEp1biAyMDIxIDEyOjAwOjE0 ICswMTAwLAo+IEF1c3RpbiBLaW0gPGF1c3RpbmRoLmtpbUBnbWFpbC5jb20+IHdyb3RlOgo+ID4K PiA+IEZyb206IEF1c3RpbiBLaW0gPGF1c3Rpbi5raW1AbGdlLmNvbT4KPiA+Cj4gPiBOb3JtYWxs eSBsb2NhbCB2YXJpYWJsZSAnZmxhZ3MnIGlzIGRlZmluZWQgb3V0IG9mIGZvciBsb29wLAo+ID4g d2hlbiAnZmxhZ3MnIGlzIHVzZWQgYXMgdGhlIHNlY29uZCBwYXJhbWV0ZXIgaW4gYSBjYWxsIHRv Cj4gPiBzcGlubG9ja19pcnFbc2F2ZS9yZXN0b3JlXSBmdW5jdGlvbi4KPiA+Cj4gPiBTbyBpdCBo YWQgYmV0dGVyIGRlY2xlYXIgbG9jYWwgdmFyaWFibGUgJ2ZsYWdzJyBhaGVhZCBvZiBmb3IgbG9v cC4KPgo+IFdoeSBiZXR0ZXI/IFJlZHVjaW5nIHRoZSBzY29wZSBvZiBhIHZhcmlhYmxlIGlzIGlu IGdlbmVyYWwgZ29vZAo+IHByYWN0aWNlLiBEbyB5b3Ugc2VlIGFueSBtYXRlcmlhbCBhZHZhbnRh Z2UgaW4gbW92aW5nIHRoaXMgdmFyaWFibGUKPiBvdXQgb2YgdGhlIGxvb3A/IERvZXMgdGhlIGNv bXBpbGVyIGdlbmVyYXRlIGJldHRlciBjb2RlPwoKRmlyc3QgYWxsIG9mLCB0aGFua3MgZm9yIGZl ZWRiYWNrLgoKSSBjaGVja2VkIGhvdyB0aGUgY29tcGlsZXIgZ2VuZXJhdGUgYXNzZW1ibHkgY29k ZShiZWZvcmUvYWZ0ZXIpIHVzaW5nCm9iamR1bXAgdXRpbGl0eS4KQW5kIHRoZW4gZm91bmQgb3V0 IHRoYXQgY29tcGlsZXIgZ2VuZXJhdGVzIHRoZSBzYW1lIGFzc2VtYmx5IGNvZGUuCgo8Y29tcGls ZXIgdmVyc2lvbjogZ2NjLWxpbmFyby03LjUuMC0yMDE5LjEyLXg4Nl82NF9hYXJjaDY0PgoKZmZm ZjgwMDAxMDA1ZjVjOCA8dmdpY19tbWlvX3JlYWRfcGVuZGluZz46CmZmZmY4MDAwMTAwNWY1Yzg6 ICAgZDUwMzIzM2YgICAgcGFjaWFzcAouLi4KZmZmZjgwMDAxMDA1ZjYzYzogICA5N2ZmZTlhZiAg ICBibCAgZmZmZjgwMDAxMDA1OWNmOCA8dmdpY19nZXRfaXJxPgpmZmZmODAwMDEwMDVmNjQwOiAg IGFhMDAwM2YzICAgIG1vdiB4MTksIHgwCmZmZmY4MDAwMTAwNWY2NDQ6ICAgOTQzODg2YzMgICAg YmwgIGZmZmY4MDAwMTBlODExNTAgPF9yYXdfc3Bpbl9sb2NrX2lycXNhdmU+CgpMZXQgbWUga2Vl cCBpbiBtaW5kIGhvdyBjb21waWxlciBnZW5lcmF0ZSBhc3NlbWJseSBjb2RlIHdpdGggbmV3IHBh dGNoLAp3aGljaCBsZWFkcyB0byBtYXRlcmlhbCBhZHZhbnRhZ2UuCgpCUiwKQXVzdGluIEtpbQoK Pgo+IFRoYW5rcywKPgo+ICAgICAgICAgTS4KPgo+IC0tCj4gV2l0aG91dCBkZXZpYXRpb24gZnJv bSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBs aXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1h bi9saXN0aW5mby9rdm1hcm0K