From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020F6C432BE for ; Mon, 30 Aug 2021 20:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D540F60F5C for ; Mon, 30 Aug 2021 20:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234811AbhH3UJB (ORCPT ); Mon, 30 Aug 2021 16:09:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234634AbhH3UJA (ORCPT ); Mon, 30 Aug 2021 16:09:00 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E47EC06175F for ; Mon, 30 Aug 2021 13:08:06 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id j15so17502378ila.1 for ; Mon, 30 Aug 2021 13:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0RtSe3tPXjpOd0ru72YE33BChLV62/Ie8i3PXYdqo+I=; b=YN8ribrXpRm7FNv4ZI5E2n4zz36a4faIdX+Ua6lNeUTqzla9RlyJBG3EfB0uEdskEn BNNB7hsiTrDVB5euYOicZNKvhwFmChfyxLtoz8W3VfmuQom3evvkZbMwP/+DW3+985lE lPJGcJFB+PNRcH82klgyMod8NN8UM9GXgbJ+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0RtSe3tPXjpOd0ru72YE33BChLV62/Ie8i3PXYdqo+I=; b=Vo9FELbPZ/8iYdM+F907gG8db2oQHPBMXGT0HCnvY1l/hAuJIVi3IFTKOyQmgRHHTE /7TKPtMnbo5UkwPGtoAZCaOyBJ3W6GqkfvTCHs4KVMOVXBB3VCiTO3ZD00ZMG3VI35au 7T7rA4RZfA0hqWKkNUXkmxDrTwdQ0CkIsW8zVad4G9LJLBQJ3gn5Hqz1ZPMPUbG/aLpM 5DXoSX35ea0ouYU/SZ6PbR3BbUtjh5jOKv9bflG128tvUcPNXNbiZu33dj71zMLs/9ba C0quwfJux7k4ehvf/FfMy3xd0tnx3G42LlVxBE9qqNnzUWwEyVKtihxRWWU5i+5ITp6A Vz5w== X-Gm-Message-State: AOAM531EwDUGwNEUT60+7yendgAZ53vHgmicR7oSVSGFBTFnMM2ilb/Z eTPzx/E+V1xtF50pcl+Ef5VaF4QpZhia+A== X-Google-Smtp-Source: ABdhPJyPL9hjkJctbf9KLwcpaUJT7MBMZh3/M1GzCvCHl2Kx+pQiq7TKDObM2FiAmpRP90+ZMTgzkQ== X-Received: by 2002:a05:6e02:130e:: with SMTP id g14mr17874125ilr.81.1630354085074; Mon, 30 Aug 2021 13:08:05 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id p15sm9745952ilc.12.2021.08.30.13.08.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 13:08:04 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id y18so21600132ioc.1 for ; Mon, 30 Aug 2021 13:08:03 -0700 (PDT) X-Received: by 2002:a5d:8acf:: with SMTP id e15mr19403264iot.184.1630354083438; Mon, 30 Aug 2021 13:08:03 -0700 (PDT) MIME-Version: 1.0 References: <1630346073-7099-1-git-send-email-sanm@codeaurora.org> <1630346073-7099-2-git-send-email-sanm@codeaurora.org> In-Reply-To: <1630346073-7099-2-git-send-email-sanm@codeaurora.org> From: Doug Anderson Date: Mon, 30 Aug 2021 13:07:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: usb: qcom,dwc3: Add multi-pd bindings for dwc3 qcom To: Sandeep Maheswaram Cc: Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Matthias Kaehlcke , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux USB List , LKML , Pratham Pratap Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Aug 30, 2021 at 10:55 AM Sandeep Maheswaram wrote: > > Add multi pd bindings to set performance state for cx domain > to maintain minimum corner voltage for USB clocks. > > Signed-off-by: Sandeep Maheswaram > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index e70afc4..838d9c4 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -41,7 +41,18 @@ properties: > > power-domains: > description: specifies a phandle to PM domain provider node > - maxItems: 1 > + minItems: 1 > + items: > + - description: optional,cx power domain > + - description: USB gdsc power domain You need to re-order the above. The optional one needs to be second, not first. > + power-domain-names: > + items: > + - const: cx > + - const: usb_gdsc Why do you need the names at all? The ordering of power-domains is well defined and there are no holes in it and there are no legacy reasons for having the names (like there are for clocks), so you should drop. This is much like reg-names and I always point people to this message from Rob Herring about reg-names: https://lore.kernel.org/r/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/ You'll have to change your driver to use dev_pm_domain_attach_by_id() but that should be fine. -Doug