From: Elijah Newren <newren@gmail.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: Re: [PATCH] multimail: stop shipping a copy
Date: Thu, 10 Jun 2021 08:40:53 -0700 [thread overview]
Message-ID: <CABPp-BEQs=n2YhZGVNvLAUVedO1rnWaM=DXYMvVwqDnst3s-sQ@mail.gmail.com> (raw)
In-Reply-To: <1554066605.61418500.1623333784687.JavaMail.zimbra@matthieu-moy.fr>
On Thu, Jun 10, 2021 at 7:03 AM Matthieu Moy <git@matthieu-moy.fr> wrote:
>
> "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>:
>
> > On Thu, Jun 10 2021, Johannes Schindelin via GitGitGadget wrote:
> >
> > > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > > The multimail project is developed independently and has its own project
> > > page. Traditionally, we shipped a copy in contrib/.
> >
> > > However, such a copy is prone to become stale, and users are much better
> > > served to be directed to the actual project instead.
> >
> > Let's CC its maintainer / other people who've actively contributed to
> > it. I've taken the liberty to do that.
>
> Thanks.
I only authored ~2% of the commits in git-multimail, compared to
Matthieu's ~55% and Michael's ~32%. So I'm not sure my opinion should
matter, even if I had a strong opinion.
And I don't have a strong opinion. git-multimail was awesome and very
helpful for a few years, but it did everything I needed as of 2015 and
I didn't really contribute further because it was perfect for my needs
by that point. (Well, okay, I did apparently contribute 563c41ed05ae
(Ficks a phew simpul speling erors., 2019-11-04) after 2015, but those
were just typo fixes in comments, not particularly important.)
Also, back when I did use it, I always used the version from upstream
rather than the copy from git.
> > Having written a system in the past that made use of git-multimail.py
> > (and sourced it from git.git's copy) I'd think a better direction would
> > be to keep this and modify githooks(5) to actively recommend it over the
> > older and less featureful post-receive-email script.
Recommending git-multimail over the existing post-receive-email script
makes a lot of sense; git-multimail is much, much better.
> I'm all for recommending it in githooks, but this can be done by pointing
> to GitHub's URL instead of a local path. Actually the sample script could
> look like
>
> # Fetch git-multimail.py from https://github.com/git-multimail/git-multimail/
> # adapt and uncomment the following line:
> #exec /path/to/git_multimail.py
This seems like a good idea.
next prev parent reply other threads:[~2021-06-10 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:29 [PATCH] multimail: stop shipping a copy Johannes Schindelin via GitGitGadget
2021-06-10 10:04 ` Ævar Arnfjörð Bjarmason
2021-06-10 14:03 ` Matthieu Moy
2021-06-10 15:40 ` Elijah Newren [this message]
2021-06-10 10:31 ` Johannes Schindelin
2021-06-10 16:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BEQs=n2YhZGVNvLAUVedO1rnWaM=DXYMvVwqDnst3s-sQ@mail.gmail.com' \
--to=newren@gmail.com \
--cc=avarab@gmail.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.