From: Tomasz Figa <tfiga@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ricardo Ribalda <ribalda@chromium.org>
Subject: Re: [PATCH v9 00/22] uvcvideo: Fix v4l2-compliance errors
Date: Tue, 25 May 2021 17:06:35 +0900 [thread overview]
Message-ID: <CAAFQd5AegMJCrcV7Qpb0oUQLjSiDa+Q7=ojrZs+z+WDSwLq6Ng@mail.gmail.com> (raw)
In-Reply-To: <20210326095840.364424-1-ribalda@chromium.org>
Hi everyone,
On Fri, Mar 26, 2021 at 6:58 PM Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> *v4l2-compliance -m /dev/media0 -a -f
> Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0
> Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2
> Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
> Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102,
> Failed: 6, Warnings: 2
>
> After fixing all of them we go down to:
>
> Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0
> Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
> Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
> Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108,
> Failed: 0, Warnings: 0
>
> YES, NO MORE WARNINGS :)
>
> Note that we depend on:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20210317143453.483470-1-ribalda@chromium.org/
>
> With Hans patch we can also pass v4l2-compliance -s.
>
> Changelog from v8 (Thanks to Hans)
> - 3 patches from Hans
> - Add Reviewed-by
>
> Hans Verkuil (4):
> uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE
> uvcvideo: improve error handling in uvc_query_ctrl()
> uvcvideo: don't spam the log in uvc_ctrl_restore_values()
> uvc: use vb2 ioctl and fop helpers
>
> Ricardo Ribalda (18):
> media: v4l2-ioctl: Fix check_ext_ctrls
> media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
> media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
> media: v4l2-ioctl: S_CTRL output the right value
> media: uvcvideo: Remove s_ctrl and g_ctrl
> media: uvcvideo: Set capability in s_param
> media: uvcvideo: Return -EIO for control errors
> media: uvcvideo: refactor __uvc_ctrl_add_mapping
> media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
> media: uvcvideo: Use dev->name for querycap()
> media: uvcvideo: Set unique vdev name based in type
> media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE
> media: uvcvideo: Use control names from framework
> media: uvcvideo: Check controls flags before accessing them
> media: uvcvideo: Set error_idx during ctrl_commit errors
> media: uvcvideo: Return -EACCES to inactive controls
> media: docs: Document the behaviour of uvcdriver
> media: uvcvideo: Downgrade control error messages
>
> .../userspace-api/media/v4l/vidioc-g-ctrl.rst | 5 +
> .../media/v4l/vidioc-g-ext-ctrls.rst | 5 +
> drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 -
> drivers/media/usb/uvc/uvc_ctrl.c | 343 +++++++++++----
> drivers/media/usb/uvc/uvc_driver.c | 22 +-
> drivers/media/usb/uvc/uvc_metadata.c | 10 +-
> drivers/media/usb/uvc/uvc_queue.c | 143 -------
> drivers/media/usb/uvc/uvc_v4l2.c | 389 +++---------------
> drivers/media/usb/uvc/uvc_video.c | 51 ++-
> drivers/media/usb/uvc/uvcvideo.h | 54 +--
> drivers/media/v4l2-core/v4l2-ioctl.c | 67 +--
> 11 files changed, 444 insertions(+), 649 deletions(-)
>
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
Any comments on this? Could we have this merged?
Thanks,
Tomasz
prev parent reply other threads:[~2021-05-25 8:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:58 [PATCH v9 00/22] uvcvideo: Fix v4l2-compliance errors Ricardo Ribalda
2021-03-26 9:58 ` [PATCH v9 01/22] media: v4l2-ioctl: Fix check_ext_ctrls Ricardo Ribalda
2021-06-10 16:19 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 02/22] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL Ricardo Ribalda
2021-06-10 17:29 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 03/22] media: uvcvideo: " Ricardo Ribalda
2021-06-10 16:21 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 04/22] media: v4l2-ioctl: S_CTRL output the right value Ricardo Ribalda
2021-06-10 16:23 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 05/22] media: uvcvideo: Remove s_ctrl and g_ctrl Ricardo Ribalda
2021-06-10 16:24 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 06/22] media: uvcvideo: Set capability in s_param Ricardo Ribalda
2021-03-26 9:58 ` [PATCH v9 07/22] media: uvcvideo: Return -EIO for control errors Ricardo Ribalda
2021-03-26 9:58 ` [PATCH v9 08/22] media: uvcvideo: refactor __uvc_ctrl_add_mapping Ricardo Ribalda
2021-03-26 9:58 ` [PATCH v9 09/22] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS Ricardo Ribalda
2021-06-10 16:42 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 10/22] media: uvcvideo: Use dev->name for querycap() Ricardo Ribalda
2021-06-10 16:44 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 11/22] media: uvcvideo: Set unique vdev name based in type Ricardo Ribalda
2021-06-10 16:45 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 12/22] media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE Ricardo Ribalda
2021-06-10 16:48 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 13/22] media: uvcvideo: Use control names from framework Ricardo Ribalda
2021-06-10 16:50 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 14/22] media: uvcvideo: Check controls flags before accessing them Ricardo Ribalda
2021-06-10 16:55 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 15/22] media: uvcvideo: Set error_idx during ctrl_commit errors Ricardo Ribalda
2021-06-10 17:05 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 16/22] media: uvcvideo: Return -EACCES to inactive controls Ricardo Ribalda
2021-03-27 11:23 ` Hans Verkuil
2021-06-10 17:28 ` Laurent Pinchart
2021-06-10 18:40 ` Ricardo Ribalda
2021-06-10 19:47 ` Ricardo Ribalda Delgado
2021-03-26 9:58 ` [PATCH v9 17/22] media: docs: Document the behaviour of uvcdriver Ricardo Ribalda
2021-03-27 11:19 ` Hans Verkuil
2021-03-27 12:01 ` Ricardo Ribalda
2021-03-27 12:03 ` Hans Verkuil
2021-06-10 17:08 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 18/22] media: uvcvideo: Downgrade control error messages Ricardo Ribalda
2021-03-27 11:19 ` Hans Verkuil
2021-06-10 16:59 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 19/22] uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE Ricardo Ribalda
2021-03-27 12:26 ` Ricardo Ribalda Delgado
2021-03-26 9:58 ` [PATCH v9 20/22] uvcvideo: improve error handling in uvc_query_ctrl() Ricardo Ribalda
2021-06-10 17:14 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 21/22] uvcvideo: don't spam the log in uvc_ctrl_restore_values() Ricardo Ribalda
2021-06-10 16:57 ` Laurent Pinchart
2021-03-26 9:58 ` [PATCH v9 22/22] uvc: use vb2 ioctl and fop helpers Ricardo Ribalda
2021-04-02 2:50 ` Tomasz Figa
2021-05-25 8:06 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAFQd5AegMJCrcV7Qpb0oUQLjSiDa+Q7=ojrZs+z+WDSwLq6Ng@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.