From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D940814F9C4 for ; Thu, 29 Feb 2024 15:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709222085; cv=none; b=GmSBrbshOp8xiLNwMSctZa+/k59G4f8OFu1DwDuBg7/GHUaWiJlqGV0tQE8AdIUEDYUqrrWuTwZYSEfedj8n2yPa7H0YvzWXSQ28YanvrleVMdzW0skpGHTvprQ7BcpvMtM2WKg4yNtIJCdAh/jDttVFsMQng1D1G5MLEIOAgDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709222085; c=relaxed/simple; bh=Fmj50ebsiQKgGvbsywVhM6Fhx/1ciNoD0BmuFWzRd6E=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AWBl4YMpiLuPUHQ5WMKCBHQCXQ0zMiEeKeCbkpYnDXFn+X47ZEre95kCNIOzSUQJf6elnGCi8Tdn4Z5qOcjmGHmLP3B2dmAu2cfMvvkOf4MLrDa4BI1VJGSrXoSR5yOhaXpbgE/2QS9FGsdZQfNIx8rj2t11RfgqIrQX5n87Jkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LkLhu3GD; arc=none smtp.client-ip=209.85.219.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LkLhu3GD" Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dcdb210cb6aso1181375276.2 for ; Thu, 29 Feb 2024 07:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709222082; x=1709826882; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Srh+6tdz7RM48Lhk9oPRVhCIVS8iBO4HPXxfynqBJNE=; b=LkLhu3GDxO2Dj6qxqEGHBUNlFajjGSFSXBICxbIxx5wMCUK9MyTLFF3pT+6rh3qPeT z/xFryjAMJtN3TX95x2hp91kcT0Ba4tYs+WM56eWQ98IBs+YfZdw78CHn0bU7nEYGlYx GyTQdi6oCYPXYM/viNtia9rFXuvw9fjgcjQ85r0iGduD1uN4pPGsTVSEzLBCqYpWErt5 jxfEtZQq02+d1dntOTlmykRLNqxxUkBjyHr87zvPvejjsbgVXwG5HUghH/B9+fZX0Qws 94SZYV+z1AgIwgI8g+3LvvhIGky4P8WxA4HG5oi8phBeXBf0MzEacP+S343Wk/ADWqTE SmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709222082; x=1709826882; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Srh+6tdz7RM48Lhk9oPRVhCIVS8iBO4HPXxfynqBJNE=; b=BCSSu4ApqeiYQs1jXBy6jN/tzJhq93jrUWUVHhre0QQnYXxpdzlE9pneMN+y6XNcNT k18Fkova1nxsVRKE6rQB2oFNSoOBlThnjOyi0Duo+eXgxeBeBEmucc+4FTfoE3SAOFkY 5jrEBLfLNIqrrXyl21v4IMfB+kHStMldPI5eRKtKx2hbAnFqo1T2xIqMIUYvHSRFQbwk AIhv/44Ou7zKtFvT8lRsKpwz2XkDLs7Mo7rgqjamC/I9Lrxx1EWZ+S/4HX7BVjHJgE/k auOCgQ4yxUDxfLg1U30f0HaguH9Wjh/cOATlZJxB5isby4BWZqd7SeMuoqMl1/gVO3O8 B+dA== X-Forwarded-Encrypted: i=1; AJvYcCVaMyTj/JyV5gHygvaL/HJNV8qDAgDd6CY9Xl7oBWvWowZyAUbUOmVkJsFXJcZ+W57kM9NUpUy0hPMAzZzAuhZXiY73Ke8XV4kBkMYa X-Gm-Message-State: AOJu0Yz5R4JtE/IHrpRmgQfWp21zRoSk2ZO8jtbdfkQEIq4kz9/tayA0 EQY6Jvc/4Tb53O6gsPG9R7ESScqdI9ug7oeBbWwsz/G2JO2QoBkht1gR20r75NeqfNmPkvWNJiv /kTKZ3ac17UwBQplG4akt4QDnYn4oR4o9/VlXQw== X-Google-Smtp-Source: AGHT+IGrY7X4RTDo8QjDtQgZG99mLAi+VyuWqElpCArGZNMLwpnq8A2MweEnHlDSd6Qps3WvhnJlp7ZvAlcScgpu2bM= X-Received: by 2002:a25:2e46:0:b0:dc6:e622:f4e with SMTP id b6-20020a252e46000000b00dc6e6220f4emr2493033ybn.14.1709222081918; Thu, 29 Feb 2024 07:54:41 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240229-topic-sm8x50-upstream-phy-combo-typec-mux-v1-0-07e24a231840@linaro.org> <20240229-topic-sm8x50-upstream-phy-combo-typec-mux-v1-4-07e24a231840@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 29 Feb 2024 17:54:30 +0200 Message-ID: Subject: Re: [PATCH RFT 4/7] phy: qcom: qmp-combo: register a typec mux to change the QPHY_MODE To: neil.armstrong@linaro.org Cc: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Thu, 29 Feb 2024 at 17:47, Neil Armstrong wrote: > > On 29/02/2024 16:25, Dmitry Baryshkov wrote: > > On Thu, 29 Feb 2024 at 15:08, Neil Armstrong wrote: > >> > >> Register a typec mux in order to change the PHY mode on the Type-C > >> mux events depending on the mode and the svid when in Altmode setup. > >> > >> The DisplayPort phy should be left enabled if is still powered on > >> by the DRM DisplayPort controller, so bail out until the DisplayPort > >> PHY is not powered off. > >> > >> The Type-C Mode/SVID only changes on plug/unplug, and USB SAFE states > >> will be set in between of USB-Only, Combo and DisplayPort Only so > >> this will leave enough time to the DRM DisplayPort controller to > >> turn of the DisplayPort PHY. > > > > I think this is not fully correct. Please correct me if I'm wrong, but > > it is possible to switch between USB / USB+DP / DP-only at runtime. > > See the Status Update and Configure commands. > > Yes, but the current implementation is still valid because we need to > have the DP powered-off before changing the PHY mode. Even for switching between 2 lane and 4 lane modes? I'll check how my USB-A+DP dongles work with respect to the altmode configuration. > > I never encountered such setup and I have no idea how to test this. > > > > >> > >> Signed-off-by: Neil Armstrong -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24BE8C48BF6 for ; Thu, 29 Feb 2024 15:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H5+ayyBWjB4JJyN5mn8Yu8aRADDe0OJcGaxkIxfnGWE=; b=DUDCUvGNdpLVYQ b355hvuGtNhpmPLJXRaiAO8mphVmqg21mRQ2SSW4tlFcYnVA54rTrTgtrmm4Efs17e0HEfQxOD2rK v+n/J6gUnM1Ud2uHM2mduHjmOvFGz0dnGSzY+nXzwSMUPwbo5mMfQn8hrCGjsfXtNafYWvpdbx9B1 xG8BPw+7s7ruEuXEvbS2ZUqS8LS0US5gcKs6cqAJP87bkFTML+9oEK928NB9oiypboYcykni1rovI 5+qzjqJCDT7oSI54qiUuZxSyPFvmrqw2r1o+TyrUDN8MnBTRgbQKGzhd0F0Pny2tH0nhQWv86XaQt ZuYBT2TKBJStonbyuRQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfikK-0000000E9ZH-1rF2; Thu, 29 Feb 2024 15:54:56 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfik9-0000000E9Tk-0EyL for linux-phy@lists.infradead.org; Thu, 29 Feb 2024 15:54:53 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-dcdb210cb6aso1181377276.2 for ; Thu, 29 Feb 2024 07:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709222082; x=1709826882; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Srh+6tdz7RM48Lhk9oPRVhCIVS8iBO4HPXxfynqBJNE=; b=XCqIB/uhuC7BzWvrC7CSbpwq2BdYEwGWD4dhW5m7S72R5u5DnKc43nV9ZUtvAbkT9O ogjXlnlThufZKXSyLRgtKOANMlK4VyX+Y408SogAJs/FOC4R0ksd+8gNIyqUhjJDTupe K+dTfxgztaD3qI0G8LRDV2aa85CCk74NSWt2IJR3B4P7P2p/lzkGklP4ZU1HH9UhD+2b 4nz20tQcZC+xs2/JjHJ3sNhv2X/R46XM9LOIqtENaTW+IQBfqM9IAMB0M/eJm1qB0H5Z QfGaUIb5CmPhFjEPEopf2JuugZIT7lCIECyadh8dQ6xEd6w2z3Me3xPpWkEJeKBQA5pc yfKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709222082; x=1709826882; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Srh+6tdz7RM48Lhk9oPRVhCIVS8iBO4HPXxfynqBJNE=; b=VrpNsdVSxgz/nNFaLJuo29aIxSi/hK8tsAPmJenDDFK3hHtjj84y5hu8tHoIdyj9vy NkUzxBw6VW4GYthH197vqDF1eYVtrQ1RDJAdR/P5WiWYsnHuTOk9ZOKeUma3YyXhuFU4 mTeuFnK5l7+rS05Lsr1RGLIaqz19pszAOOZ4qgW1B7S10no2vdU3A5clkCZ4WnUAeA+q 9nOo68Rdowg4vRbn7UFZLN0tXq5nA0993gRquEveFElKAG3/CyLLXPEGx4aRsFaf3/oR rQDm24MJtuGeZih9wZRUvF+7lk27F7JWeIShK19v1adN9IcrP/Z+feBlk9zWh7FO5vFt 8wWg== X-Forwarded-Encrypted: i=1; AJvYcCXxPEUluxdIaTDzh9WtzT66XSvMlxYZJtkUoUAV9xP+R6AE3YFRrPo+XPW/v7fP4/XWgkAiEk5z5iDF/ZDE21bcIImQsoEiPg9bvjLuhQ== X-Gm-Message-State: AOJu0YzlpizZDo01QkW0z1zE/KZ0jPB2y7swqrfXeTGDHcqgA4HeInmm ia81RYuADcruUd3umXChaB5k9fVkABK+HWVEmbVc/asrTyvg8QS4KbuigtL7/iqUJ7Zvu7tdXCa I+wfhLHyitmpxS32c9KlkmSxxpVuwf+5JRHqr5g== X-Google-Smtp-Source: AGHT+IGrY7X4RTDo8QjDtQgZG99mLAi+VyuWqElpCArGZNMLwpnq8A2MweEnHlDSd6Qps3WvhnJlp7ZvAlcScgpu2bM= X-Received: by 2002:a25:2e46:0:b0:dc6:e622:f4e with SMTP id b6-20020a252e46000000b00dc6e6220f4emr2493033ybn.14.1709222081918; Thu, 29 Feb 2024 07:54:41 -0800 (PST) MIME-Version: 1.0 References: <20240229-topic-sm8x50-upstream-phy-combo-typec-mux-v1-0-07e24a231840@linaro.org> <20240229-topic-sm8x50-upstream-phy-combo-typec-mux-v1-4-07e24a231840@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 29 Feb 2024 17:54:30 +0200 Message-ID: Subject: Re: [PATCH RFT 4/7] phy: qcom: qmp-combo: register a typec mux to change the QPHY_MODE To: neil.armstrong@linaro.org Cc: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_075445_536634_0F6DE87F X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, 29 Feb 2024 at 17:47, Neil Armstrong wrote: > > On 29/02/2024 16:25, Dmitry Baryshkov wrote: > > On Thu, 29 Feb 2024 at 15:08, Neil Armstrong wrote: > >> > >> Register a typec mux in order to change the PHY mode on the Type-C > >> mux events depending on the mode and the svid when in Altmode setup. > >> > >> The DisplayPort phy should be left enabled if is still powered on > >> by the DRM DisplayPort controller, so bail out until the DisplayPort > >> PHY is not powered off. > >> > >> The Type-C Mode/SVID only changes on plug/unplug, and USB SAFE states > >> will be set in between of USB-Only, Combo and DisplayPort Only so > >> this will leave enough time to the DRM DisplayPort controller to > >> turn of the DisplayPort PHY. > > > > I think this is not fully correct. Please correct me if I'm wrong, but > > it is possible to switch between USB / USB+DP / DP-only at runtime. > > See the Status Update and Configure commands. > > Yes, but the current implementation is still valid because we need to > have the DP powered-off before changing the PHY mode. Even for switching between 2 lane and 4 lane modes? I'll check how my USB-A+DP dongles work with respect to the altmode configuration. > > I never encountered such setup and I have no idea how to test this. > > > > >> > >> Signed-off-by: Neil Armstrong -- With best wishes Dmitry -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy