* Annoying and insane pci kernel messages..
@ 2014-08-21 0:15 Linus Torvalds
0 siblings, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2014-08-21 0:15 UTC (permalink / raw
To: Bjorn Helgaas; +Cc: linux-pci@vger.kernel.org
So I don't know when this started happening, and it may well be an
age-old issue, possibly made worse by configurations copied from
distro makers that enable various random PCI hotplug logic, but my
laptop dmesg is full of these annoying and worthless messages after
suspend/resume:
...
pci 0000:00:00.0: no hotplug settings from platform
pci 0000:00:00.0: using default PCI settings
i915 0000:00:02.0: no hotplug settings from platform
i915 0000:00:02.0: using default PCI settings
...
basically repeating mindlessly for each PCI device. It's insane. It
adds zero value. Why do we print out those inane messages?
The reason _seems_ to be that some ACPI hotplug logic basically ends
up doing "pci_configure_slot()" on every PCI slot, whether something
is hotpluggable or not. Trust me, those things aren't. Printing
pointless hotplug information for them is just crazy, and takes up
kernel message space and hides _real_ messages for no good reason.
Lookie here:
[torvalds@vaio linux]$ dmesg | grep "no hotplug settings" | wc
1006 8658 71574
yeah, that's a thousand lines of crap. There's another 568 lines of
the "using default PCI settings". In fact, there's *more* of this, but
there's been so much of it that it's scrolled off the kernel message
buffer.
Could we please not do this?
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Annoying and insane pci kernel messages..
@ 2014-08-21 0:17 Linus Torvalds
2014-08-22 5:27 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2014-08-21 0:17 UTC (permalink / raw
To: Bjorn Helgaas; +Cc: linux-pci@vger.kernel.org
[ Oops, my mail client ended up picking an old address for Bjorn, so
resending with the correct one ]
So I don't know when this started happening, and it may well be an
age-old issue, possibly made worse by configurations copied from
distro makers that enable various random PCI hotplug logic, but my
laptop dmesg is full of these annoying and worthless messages after
suspend/resume:
...
pci 0000:00:00.0: no hotplug settings from platform
pci 0000:00:00.0: using default PCI settings
i915 0000:00:02.0: no hotplug settings from platform
i915 0000:00:02.0: using default PCI settings
...
basically repeating mindlessly for each PCI device. It's insane. It
adds zero value. Why do we print out those inane messages?
The reason _seems_ to be that some ACPI hotplug logic basically ends
up doing "pci_configure_slot()" on every PCI slot, whether something
is hotpluggable or not. Trust me, those things aren't. Printing
pointless hotplug information for them is just crazy, and takes up
kernel message space and hides _real_ messages for no good reason.
Lookie here:
[torvalds@vaio linux]$ dmesg | grep "no hotplug settings" | wc
1006 8658 71574
yeah, that's a thousand lines of crap. There's another 568 lines of
the "using default PCI settings". In fact, there's *more* of this, but
there's been so much of it that it's scrolled off the kernel message
buffer.
Could we please not do this?
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Annoying and insane pci kernel messages..
2014-08-21 0:17 Annoying and insane pci kernel messages Linus Torvalds
@ 2014-08-22 5:27 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-08-22 5:27 UTC (permalink / raw
To: Linus Torvalds; +Cc: linux-pci@vger.kernel.org, Rafael J. Wysocki
[+cc Rafael]
On Wed, Aug 20, 2014 at 7:17 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> [ Oops, my mail client ended up picking an old address for Bjorn, so
> resending with the correct one ]
>
> So I don't know when this started happening, and it may well be an
> age-old issue, possibly made worse by configurations copied from
> distro makers that enable various random PCI hotplug logic, but my
> laptop dmesg is full of these annoying and worthless messages after
> suspend/resume:
>
> ...
> pci 0000:00:00.0: no hotplug settings from platform
> pci 0000:00:00.0: using default PCI settings
> i915 0000:00:02.0: no hotplug settings from platform
> i915 0000:00:02.0: using default PCI settings
> ...
>
> basically repeating mindlessly for each PCI device. It's insane. It
> adds zero value. Why do we print out those inane messages?
>
> The reason _seems_ to be that some ACPI hotplug logic basically ends
> up doing "pci_configure_slot()" on every PCI slot, whether something
> is hotpluggable or not. Trust me, those things aren't. Printing
> pointless hotplug information for them is just crazy, and takes up
> kernel message space and hides _real_ messages for no good reason.
>
> Lookie here:
>
> [torvalds@vaio linux]$ dmesg | grep "no hotplug settings" | wc
> 1006 8658 71574
>
> yeah, that's a thousand lines of crap. There's another 568 lines of
> the "using default PCI settings". In fact, there's *more* of this, but
> there's been so much of it that it's scrolled off the kernel message
> buffer.
>
> Could we please not do this?
Yeah, this really seems broken. It's not really news if the firmware
doesn't supply settings, so we could just drop the printk. On the
other hand, it *might* be news if it *does* supply settings, so maybe
we should reverse the sense. But I want to look at it a little more
because it seems like we shouldn't even be calling
pci_configure_slot() that many times to begin with.
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-22 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 0:17 Annoying and insane pci kernel messages Linus Torvalds
2014-08-22 5:27 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-08-21 0:15 Linus Torvalds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.