From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: RE: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC stats during probe
Date: Fri, 29 Mar 2024 09:06:33 +0000 [thread overview]
Message-ID: <BY3PR18MB4707F7B23CFD2E7014163F7EA03A2@BY3PR18MB4707.namprd18.prod.outlook.com> (raw)
In-Reply-To: <SJ2PR18MB56355935E211C00939AE81A0A23A2@SJ2PR18MB5635.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, March 12, 2024 3:44 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
Subbaraya
> Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC
> stats during probe
>
> On Fri, 8 Mar 2024 23:45:44 +0530 Sai Krishna wrote:
> > @@ -3048,6 +3065,9 @@ static int otx2_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >
> > otx2_qos_init(pf, qos_txqs);
> >
> > + /* reset CGX/RPM MAC stats */
> > + otx2_reset_mac_stats(pf);
> > +
> > return 0;
>
> Looks suspicious, all sort of resets should be usually done before the
> netdev / devlink instances are registered. As soon as you register
> those they may get brought up and used (including synchronously by an in-
kernel user).
Agreed to your point, will send V4 patch with the suggested change. Apologies for delayed acknowledgement, as I overlooked the review mail.
> --
> pw-bot: cr
prev parent reply other threads:[~2024-03-29 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 18:15 [net-next PATCH v3] octeontx2-pf: Reset MAC stats during probe Sai Krishna
2024-03-11 9:23 ` Simon Horman
2024-03-11 22:14 ` Jakub Kicinski
[not found] ` <SJ2PR18MB56355935E211C00939AE81A0A23A2@SJ2PR18MB5635.namprd18.prod.outlook.com>
2024-03-29 9:06 ` Sai Krishna Gajula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY3PR18MB4707F7B23CFD2E7014163F7EA03A2@BY3PR18MB4707.namprd18.prod.outlook.com \
--to=saikrishnag@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.