From: "Chen, Jiqian" <Jiqian.Chen@amd.com>
To: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Chen, Jiqian" <Jiqian.Chen@amd.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: Re: [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit
Date: Fri, 12 Apr 2024 06:10:09 +0000 [thread overview]
Message-ID: <BL1PR12MB5849DCAB96600C27C2BDC35BE7042@BL1PR12MB5849.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CACGkMEuzcVRfLY+axEP3QXb9TwYq_c=jLZRB5++EwyGWLv0YcQ@mail.gmail.com>
On 2024/4/8 12:56, Jason Wang wrote:
>>>> I will set the default value of No_Soft_Reset bit to true in next version according to your opinion.
>>>> About the compatibility of old machine types, which types should I consider? Does the same as x-pcie-pm-init(hw_compat_2_8)?
>>>> Forgive me for not knowing much about compatibility.
>>>
>>> "x" means no compatibility at all, please drop the "x" prefix. And it
>>> looks more safe to start as "false" by default.
>>>
>>> Thanks
>>
>>
>> Not sure I agree. External flags are for when users want to tweak them.
>> When would users want it to be off?
>
> If I understand the suspending status proposal correctly, there are at
> least 1 device that is not safe. And this series does not mention
> which device it has tested.
I only tested virtio-gpu with my patch, I will mention this in "commit message" in next version.
>
> It means if we enable it unconditionally, guests may break.
Make sense, will keep " No_Soft_Reset bit " false by default. And add some comments in the codes to describe what you considered.
>
> Thanks
>
>> What is done here is I feel sane, just add machine compat machinery
>> to change to off for old machine types.
--
Best regards,
Jiqian Chen.
next prev parent reply other threads:[~2024-04-12 6:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 10:39 [RFC QEMU PATCH v8 0/1] S3 support Jiqian Chen
2024-03-28 10:39 ` [RFC QEMU PATCH v8 1/2] virtio-pci: only reset pm state during resetting Jiqian Chen
2024-03-28 10:39 ` [RFC QEMU PATCH v8 2/2] virtio-pci: implement No_Soft_Reset bit Jiqian Chen
2024-03-28 10:57 ` Michael S. Tsirkin
2024-03-28 11:08 ` Chen, Jiqian
2024-03-28 12:36 ` Michael S. Tsirkin
2024-03-29 7:00 ` Chen, Jiqian
2024-03-29 7:20 ` Jason Wang
2024-03-29 8:00 ` Chen, Jiqian
2024-03-29 10:38 ` Jason Wang
2024-04-02 2:56 ` Chen, Jiqian
2024-03-29 10:44 ` Michael S. Tsirkin
2024-04-02 3:03 ` Chen, Jiqian
2024-04-07 3:20 ` Jason Wang
2024-04-07 11:49 ` Michael S. Tsirkin
2024-04-08 4:56 ` Jason Wang
2024-04-12 6:10 ` Chen, Jiqian [this message]
2024-04-12 6:04 ` Chen, Jiqian
2024-04-12 6:41 ` Jason Wang
2024-04-12 6:49 ` Chen, Jiqian
2024-04-12 5:59 ` Chen, Jiqian
2024-04-12 6:42 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR12MB5849DCAB96600C27C2BDC35BE7042@BL1PR12MB5849.namprd12.prod.outlook.com \
--to=jiqian.chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.